From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF48A43D0A; Wed, 20 Mar 2024 21:25:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64748427E5; Wed, 20 Mar 2024 21:25:38 +0100 (CET) Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) by mails.dpdk.org (Postfix) with ESMTP id 3AD14402CE for ; Wed, 20 Mar 2024 21:25:37 +0100 (CET) Received: by mail-oo1-f48.google.com with SMTP id 006d021491bc7-59fb0b5b47eso97177eaf.3 for ; Wed, 20 Mar 2024 13:25:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1710966336; x=1711571136; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+hXw5I7NmOfw911RUktvQZjAc8p0Ke+5bEx6reVKawY=; b=QJKIR7TB/+RPhd3lfA8+Bn105Rxp/9pEY775wJFyrRCUhcBEzkfoz2UmE6SeKXHZOW G/DjHyTX9Yz9lMm5FlY0xXCYGMVO3IeLOrCRO4B5aTG05o2UlQhrqyaesUcLPTmh1zC1 Q+5SITD25a2m04Kv7Ib/jdUiayNvDwukiAhyo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710966336; x=1711571136; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+hXw5I7NmOfw911RUktvQZjAc8p0Ke+5bEx6reVKawY=; b=Im/RNzTxZWExcVNosgnp/ny4tyaGGVUDb0DOC/nb/JjOycx/TpZ6JhKqLSWqpaAltz i54bys+Z/AzkRsLQK7htbzW3Gus7pPo8WDLzxd42nTSQ46XIDXA/IRP83qQH5Ff9AnBx m5tfTudRjMFVhRu4r6fJt2LQuMrYK6B7oTkMpbIPyIiNWmTUNBmn34uc/HPygBXjM7/H iDC3Gks7XnixYr1TBfxFXb2bh0P4Bm4up2jUA0a136fQzZozseTZlWI1HzGVnb3oxdER EH0SUF+SLvPD9J3wGK+acOG2FvHsGgP0+R8V7h5TtmYxr2GJoQs1sFOl8HU1zSWiFxCe rgoQ== X-Forwarded-Encrypted: i=1; AJvYcCWqf9KcPT6gts4aAFiCh2W0521wRw7HBq0+7i9g5jZkNLxDb2UNmDLACAqaMCddWu3rszyeke0o6ENbq0Q= X-Gm-Message-State: AOJu0Yyv05Czb/8ZI+hI1w2vuzfKgFzaK7Viq3GCOAvqf7WVwdKWT6bb OlF2tqKC9HnUt56vYdfHlheEw9rPQiPplFFpgBAVwJBMBSN4APcO/OlcC+mAETRm2lZiDKldvaZ WsSRQPdHoFGklyU/DMWeSFlBYTvs+fqzRTCYSbA== X-Google-Smtp-Source: AGHT+IHo2UvQo9gUAsrLdbA2MUxsZ6cm5gIQCRfzOYYccDdJtywdNAAyLRLUdi9roUWFrJA63B+XM/ZwkrrcfUdL6tM= X-Received: by 2002:a05:6820:218:b0:5a4:756e:761 with SMTP id bw24-20020a056820021800b005a4756e0761mr6828482oob.9.1710966336411; Wed, 20 Mar 2024 13:25:36 -0700 (PDT) MIME-Version: 1.0 References: <20240318092109.87656-1-shperetz@nvidia.com> <62669854-8add-4fdd-b882-a63d78f0d6e8@amd.com> <46653254-c995-4de0-82fa-2531ed4cfaa0@amd.com> In-Reply-To: <46653254-c995-4de0-82fa-2531ed4cfaa0@amd.com> From: Patrick Robb Date: Wed, 20 Mar 2024 16:25:25 -0400 Message-ID: Subject: Re: [PATCH] app/testpmd: fix auto completion for indirect list action To: Ferruh Yigit Cc: Gregory Etelson , Shani Peretz , "dev@dpdk.org" , Maayan Kashani , Ori Kam , Aman Singh , Yuying Zhang , "ci@dpdk.org" , Honnappa Nagarahalli Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Mar 20, 2024 at 6:08=E2=80=AFAM Ferruh Yigit = wrote: > > On 3/20/2024 6:06 AM, Gregory Etelson wrote: > > Hello Ferruh, > > > >>BUT overall how can we catch issues like this in the feature, we don't > >>have a good way to test testpmd flow commands. > >>@Ori, @Gregory, do you have any idea? > >>cc'ed CI mail list too. > > > > We have a tool for unit tests based on the testpmd. > > The tool details are here: > > https://drive.google.com/drive/folders/1cHrPwx4fUJ6ibUCtHd4kNKsrmmvQvvO= j?usp=3Ddrive_link . > > There's also a short description here: > > https://inbox.dpdk.org/ci/2a287ee7-cda4-f2ab-a4e6-a47021f8573f@nvidia.c= om/ > > > > Consider an option when a code patch is accompanied with a short test > > script that validates that patch functionality. > > DPDK CI can run the script to verify that the patch functions correctly= . A similar idea has been proposed for DTS. I believe the plan is at the end of 2024 techboard is going to discuss adding this as a requirement for patches affecting certain components in DPDK. So a change related to the new feature must come with an accompanied /dts testsuite addition at the same time. > > > > > > Thanks Gregory, I missed this proposal, we need something to verify flow > APIs, so +1 to the effort. > What is the status of incorporating this feature into dts? The DTS 24.07 roadmap does not include testsuites verifying flow APIs, but if work proceeds at a good pace and there is space for it, we can look at writing something for 24.07. Otherwise it falls to 24.11 or 25.03. Sorry, I know that's pretty far out. > > > But I guess it won't catch this issue, as it uses full flow commands. > This issue is related to the testpmd command parsing code. I wonder if > we can find a way to verify testpmd parsing code? >