Re: [PATCH v2] dts: testpmd link check on port start

[Patrick Robb <probb@iol.unh.edu>]

[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]

On Thu, Nov 6, 2025 at 12:15 PM Dean Marx <dmarx@iol.unh.edu> wrote:

> On Wed, Nov 5, 2025 at 2:50 PM Patrick Robb <probb@iol.unh.edu> wrote:
> >
> > In addition, the interval in
> > between checking the link state has been reduced in
> > order to speed up the execution.
> >
> > Signed-off-by: Patrick Robb <probb@iol.unh.edu>
> > Tested-by: Patrick Robb <probb@iol.unh.edu>
>
> <snip>
> >              if "Link status: up" in port_info:
> >                  break
> > -            time.sleep(0.5)
> > +            time.sleep(0.25)
>
> What's the rationale for changing this, just wondering?
>

See the commit blurb above - there will be many function calls to functions
which are decorated with _requires_started_ports during the DTS execution.
That means every time that happens it will enter the block you see above.
If we add .5 seconds to each of these function calls, it will slow down the
execution. It probably isn't a huge deal but the downside of decreasing the
time interval is pretty much nothing.


>
> Reviewed-by: Dean Marx <dmarx@iol.unh.edu>
>

[-- Attachment #2: Type: text/html, Size: 1944 bytes --]