From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60FB448A5B; Thu, 6 Nov 2025 19:01:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B7AB4021F; Thu, 6 Nov 2025 19:01:42 +0100 (CET) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mails.dpdk.org (Postfix) with ESMTP id 830ED4013F for ; Thu, 6 Nov 2025 19:01:40 +0100 (CET) Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-7a9c64dfa6eso1102096b3a.3 for ; Thu, 06 Nov 2025 10:01:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1762452100; x=1763056900; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Tds+UbPqqsx2rMkxSkf18PfWcxX2BUfVzgWLxtRXddw=; b=gzweklUU5n++vXI56nCDk44bRlZRIoY+phGEYx6V75T15IbTY7DsOd+TqfkHjiHH02 iBTeOm3FBSPFBBm4TxGxaDPi3pw38AgFVTbqSw/tzGZ3cTvQjh9p+T41q2n8m0RvLiKh Pi48OjeGaWjato3Zmc8fqXCGeFH+tTr7C3w4I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762452100; x=1763056900; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Tds+UbPqqsx2rMkxSkf18PfWcxX2BUfVzgWLxtRXddw=; b=tvObS9xBoGA5E6F1zPYbNeB7ZcDJQAmLO3jf8HLDQsVQ2/mjIgFFB13vB7hM1X3ATc uw5RFwnK7oB+62zi2DF4Pe+B0AolTjCCugUbsL8oREwsg8AQCq5H+7O6NgBj5lAU7yT7 jpmnNcq6o7vm8Q4MOIU6GN6kQO0TDlzLMFSG0mZB8XP3I6Xb0rZZJArzQvTCAt1TLrpi raS555OP+DUTCPLXDb32IZtN2HINPnbOdWL0LLUnRhcYadJFZS7jHfM2l24j20SQ0Zg6 k5Aa/FVGT17snDQexNvswi/VRhFUaxfRvQ1e+z/fpSy6SRaxjZo/9MH03feIWtTox6dG hTKg== X-Forwarded-Encrypted: i=1; AJvYcCX1DV1BOlSarFQCwtJqfhNak5s1DdwqRQ+Pz2oHXNveGtf2uTvORRtP7kpl0eAZXYk4jJE=@dpdk.org X-Gm-Message-State: AOJu0YzNNkIzjB0ON6R6bdNcN2G6HkSYVKtlO2dLjXwV0FzAjLl9rhZP DCU1juvOvxCh/tAYzts0zXY6gNmvzXL4a+5ZGmGpwoCqQTITgJ2BcEnYROPewOq4bKGnQXdmFLP /+ou93KmJQskoGALhieTrvGOwHJkL6HqrBWstu7tUBw== X-Gm-Gg: ASbGnctVfkgYJmRDMiG1O0Mm6pa159RG4Jn7XX3hdwXH3FKpf2PxD5gvBlkpZe+Enu9 LoWDots9kfb97uevPASI/pChY4eBi+WbOvD8AzUiLSCbij3w3eTd9EvL/cRt6h3Xc+F6fTXa9Q2 XIHCOUO05o3Iy9TErphciJbH1T9WbB750Ly5C2BwvXnOt7EVV/tT1K3/0CvDPVMmv07DCZg/UFs 1DvSMKuaKj29mVdYaR+1XHgZwSZ2gvXy1pmm0Wp3raFm5aX3YrxPJ6df6ScsyRiXHO8N7eBuUDp S4gGqvdIrJn9f/It2fJvC+V2U7o= X-Google-Smtp-Source: AGHT+IEAJpv1v/QzfSSsNt5jSkCVXtnhmlsSfZVuZ2ET8/KoAC3Umn7J8IBhCSZtNlgxXVEwCMWbEaHu+2oiBg5Ljwg= X-Received: by 2002:a05:6a20:3d86:b0:341:84ee:7597 with SMTP id adf61e73a8af0-3522a76d896mr556699637.47.1762452099336; Thu, 06 Nov 2025 10:01:39 -0800 (PST) MIME-Version: 1.0 References: <20250908014154.82938-1-probb@iol.unh.edu> <20251105194925.1507334-1-probb@iol.unh.edu> In-Reply-To: From: Patrick Robb Date: Thu, 6 Nov 2025 13:00:30 -0500 X-Gm-Features: AWmQ_bkXLafUygRCtq_IAXKCtJVkYkRjkMFxwOgjuRyrqk0R590x_7S7m-mKaVE Message-ID: Subject: Re: [PATCH v2] dts: testpmd link check on port start To: Dean Marx Cc: Luca.Vizzarro@arm.com, dev@dpdk.org, Paul.Szczepanek@arm.com, abailey@iol.unh.edu Content-Type: multipart/alternative; boundary="000000000000509c6b0642f0db50" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000509c6b0642f0db50 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Nov 6, 2025 at 12:15=E2=80=AFPM Dean Marx wrote= : > On Wed, Nov 5, 2025 at 2:50=E2=80=AFPM Patrick Robb w= rote: > > > > In addition, the interval in > > between checking the link state has been reduced in > > order to speed up the execution. > > > > Signed-off-by: Patrick Robb > > Tested-by: Patrick Robb > > > > if "Link status: up" in port_info: > > break > > - time.sleep(0.5) > > + time.sleep(0.25) > > What's the rationale for changing this, just wondering? > See the commit blurb above - there will be many function calls to functions which are decorated with _requires_started_ports during the DTS execution. That means every time that happens it will enter the block you see above. If we add .5 seconds to each of these function calls, it will slow down the execution. It probably isn't a huge deal but the downside of decreasing the time interval is pretty much nothing. > > Reviewed-by: Dean Marx > --000000000000509c6b0642f0db50 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Nov 6, = 2025 at 12:15=E2=80=AFPM Dean Marx <dmarx@iol.unh.edu> wrote:
On Wed, Nov 5, 2025 at 2:50=E2=80=AFPM Patrick Robb <<= a href=3D"mailto:probb@iol.unh.edu" target=3D"_blank">probb@iol.unh.edu= > wrote:
>
> In addition, the interval in
> between checking the link state has been reduced in
> order to speed up the execution.
>
> Signed-off-by: Patrick Robb <probb@iol.unh.edu>
> Tested-by: Patrick Robb <probb@iol.unh.edu>

<snip>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if "Link status: = up" in port_info:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 break > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 time.sleep(0.5)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 time.sleep(0.25)

What's the rationale for changing this, just wondering?

See the commit blurb above - there will be many functi= on calls to functions which are decorated with _requires_started_ports duri= ng the DTS execution. That means every time that happens it will enter the = block you see above. If we add .5 seconds to each of these function calls, = it will slow down the execution. It probably isn't a huge deal but the = downside of decreasing the time interval is pretty much nothing.
= =C2=A0

Reviewed-by: Dean Marx <dmarx@iol.unh.edu>
--000000000000509c6b0642f0db50--