From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FE5645C05; Tue, 29 Oct 2024 02:20:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D2A94014F; Tue, 29 Oct 2024 02:20:50 +0100 (CET) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mails.dpdk.org (Postfix) with ESMTP id 35B4140144 for ; Tue, 29 Oct 2024 02:20:49 +0100 (CET) Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-71e3fce4a60so3491953b3a.0 for ; Mon, 28 Oct 2024 18:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1730164848; x=1730769648; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OVtv+glcfRElrBMLIYbFKm5F+xcilNf+l09QQ1tj+V8=; b=gwDHhWOaxw+MuHMCnJzgUVCaqF9hHL7nC2eDRY/67VqR4cq0Rv5SpOzhiOSKdKdrNa gUcQVbUCLipgu4LtHELyy2KD274H0rf8V3pQgxaoxjLjNS70BtOJ5GvUf6SB80n/5C6U JcyPgotg6y6VY+UQhRst33KXF0wF+CcabF0K0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730164848; x=1730769648; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OVtv+glcfRElrBMLIYbFKm5F+xcilNf+l09QQ1tj+V8=; b=oG2CYXwmxrY6a0GyOJC8bbozrEmXyWHY0XqQCt5uLuLgDAteDGlx5JObOYaJ0XsSp7 f4H5M52k0de8xrd92sKvf0cA939tIb0wKxDll7FFwCwvrBXjwfwPWixmB97bg1EXFcGl 6IVWXTACXFOXlNBW43k/HgS7uAdBnub13BmUUO5dAcRZdqPwO82HHf1ea3x7PK6BBbbV 27O5NaN/ydjPeCeYYoQg34DMDdl7DptCDZ+kg3BbXCkTB6fzNz+vz9ac4nVv2AdjJrzW KspKUV/mb64fkuPSMhzi9AcLWzB3Q9j7q3uddbh99jlDs9BJFlzSFASnOCFuiTwX8asU gaCA== X-Gm-Message-State: AOJu0Yx5i4phoQMUykW8GP0KwMCv6f83ZN6AZpXhZj955Y+ajWBuAkwF Sc5wtPYBOVzk7DfoxnoX99QlCOwyLVWMJDQncn/qOYILukscq1IvmchNzsBr9SOMjoz5t8pqfct bGlMCPXD2w/BiKcyi41wPQIWOpTit2yS17U3EsQ== X-Google-Smtp-Source: AGHT+IE9M8i6m/sUtLs48nnvkph5gViqPgCpzHejEQkQDGFPF7UqKCnAcM+SJSBSXu7hJ6dpkre9gnGGv8LUXg4B6ig= X-Received: by 2002:a05:6a00:3d4c:b0:71e:cc7:c511 with SMTP id d2e1a72fcca58-72063059fffmr15676120b3a.23.1730164848127; Mon, 28 Oct 2024 18:20:48 -0700 (PDT) MIME-Version: 1.0 References: <20240930160204.19582-1-tomas.durovec@pantheon.tech> <20241021134935.1210500-1-luca.vizzarro@arm.com> <20241021134935.1210500-6-luca.vizzarro@arm.com> In-Reply-To: <20241021134935.1210500-6-luca.vizzarro@arm.com> From: Patrick Robb Date: Mon, 28 Oct 2024 21:19:08 -0400 Message-ID: Subject: Re: [PATCH v2 5/7] dts: add support for externally compiled DPDK To: Luca Vizzarro Cc: dev@dpdk.org, Paul Szczepanek , =?UTF-8?B?VG9tw6HFoSDEjnVyb3ZlYw==?= Content-Type: multipart/alternative; boundary="0000000000002d0d610625936500" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000002d0d610625936500 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Oct 21, 2024 at 9:50=E2=80=AFAM Luca Vizzarro wrote: > From: Tom=C3=A1=C5=A1 =C4=8Eurovec > > Enable the user to use either a DPDK source tree directory or a > tarball, with and without a pre-built build directory. These can be > stored on either SUT node or the DTS host. The DPDK build setup or the > pre-built binaries can be specified through the configuration file, > the command line arguments or environment variables. > > Signed-off-by: Tom=C3=A1=C5=A1 =C4=8Eurovec > Signed-off-by: Luca Vizzarro > --- > dts/conf.yaml | 24 +- > dts/framework/config/__init__.py | 123 ++++++- > dts/framework/config/conf_yaml_schema.json | 62 +++- > dts/framework/config/types.py | 17 +- > dts/framework/exception.py | 4 +- > dts/framework/remote_session/dpdk_shell.py | 2 +- > dts/framework/runner.py | 8 +- > dts/framework/settings.py | 200 +++++++++-- > dts/framework/test_result.py | 23 +- > dts/framework/testbed_model/node.py | 22 +- > dts/framework/testbed_model/os_session.py | 63 +++- > dts/framework/testbed_model/posix_session.py | 39 ++- > dts/framework/testbed_model/sut_node.py | 351 +++++++++++++------ > 13 files changed, 732 insertions(+), 206 deletions(-) > > diff --git a/dts/conf.yaml b/dts/conf.yaml > index 814744a1fc..8a65a481d6 100644 > --- a/dts/conf.yaml > +++ b/dts/conf.yaml > @@ -5,12 +5,24 @@ > test_runs: > # define one test run environment > - dpdk_build: > - arch: x86_64 > - os: linux > - cpu: native > - # the combination of the following two makes CC=3D"ccache gcc" > - compiler: gcc > - compiler_wrapper: ccache > + # dpdk_tree: Commented out because `tarball` is defined. > Should this key name be extended to clarify the desired value is a path, and whether it is absolute or relative? +1 to Dean's concerns about using the tarball without --tarball flag if dpdk_tree is commented out and tarball is defined. Reviewed-by: Patrick Robb --0000000000002d0d610625936500 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Oct 21, 2024 at 9:50=E2=80=AF= AM Luca Vizzarro <luca.vizzarro= @arm.com> wrote:
From: Tom=C3=A1=C5=A1 =C4=8Eurovec <tomas.durovec@pantheon.tech&= gt;

Enable the user to use either a DPDK source tree directory or a
tarball, with and without a pre-built build directory. These can be
stored on either SUT node or the DTS host. The DPDK build setup or the
pre-built binaries can be specified through the configuration file,
the command line arguments or environment variables.

Signed-off-by: Tom=C3=A1=C5=A1 =C4=8Eurovec <tomas.durovec@pantheon.tech= >
Signed-off-by: Luca Vizzarro <luca.vizzarro@arm.com>
---
=C2=A0dts/conf.yaml=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 24 +-
=C2=A0dts/framework/config/__init__.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0| 123 ++++++-
=C2=A0dts/framework/config/conf_yaml_schema.json=C2=A0 =C2=A0|=C2=A0 62 +++= -
=C2=A0dts/framework/config/types.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 |=C2=A0 17 +-
=C2=A0dts/framework/exception.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A04 +-
=C2=A0dts/framework/remote_session/dpdk_shell.py=C2=A0 =C2=A0|=C2=A0 =C2=A0= 2 +-
=C2=A0dts/framework/runner.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A08 +-
=C2=A0dts/framework/settings.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 200 +++++++++--
=C2=A0dts/framework/test_result.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0|=C2=A0 23 +-
=C2=A0dts/framework/testbed_model/node.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= |=C2=A0 22 +-
=C2=A0dts/framework/testbed_model/os_session.py=C2=A0 =C2=A0 |=C2=A0 63 +++= -
=C2=A0dts/framework/testbed_model/posix_session.py |=C2=A0 39 ++-
=C2=A0dts/framework/testbed_model/sut_node.py=C2=A0 =C2=A0 =C2=A0 | 351 +++= ++++++++++------
=C2=A013 files changed, 732 insertions(+), 206 deletions(-)

diff --git a/dts/conf.yaml b/dts/conf.yaml
index 814744a1fc..8a65a481d6 100644
--- a/dts/conf.yaml
+++ b/dts/conf.yaml
@@ -5,12 +5,24 @@
=C2=A0test_runs:
=C2=A0 =C2=A0# define one test run environment
=C2=A0 =C2=A0- dpdk_build:
-=C2=A0 =C2=A0 =C2=A0 arch: x86_64
-=C2=A0 =C2=A0 =C2=A0 os: linux
-=C2=A0 =C2=A0 =C2=A0 cpu: native
-=C2=A0 =C2=A0 =C2=A0 # the combination of the following two makes CC=3D&qu= ot;ccache gcc"
-=C2=A0 =C2=A0 =C2=A0 compiler: gcc
-=C2=A0 =C2=A0 =C2=A0 compiler_wrapper: ccache
+=C2=A0 =C2=A0 =C2=A0 # dpdk_tree: Commented out because `tarball` is defin= ed.

Should this key name be extended to= clarify the desired value is a path, and whether it is absolute or relativ= e?
=C2=A0
+1 to Dean's concerns about using the tar= ball without --tarball flag if dpdk_tree is commented out and tarball is de= fined.

Reviewed-by: Patrick Robb <probb@iol.unh.edu>

--0000000000002d0d610625936500--