From: Patrick Robb <probb@iol.unh.edu>
To: Luca Vizzarro <Luca.Vizzarro@arm.com>
Cc: Paul.Szczepanek@arm.com, dev@dpdk.org, dmarx@iol.unh.edu,
npratte@iol.unh.edu, thomas.wilks@arm.com
Subject: Re: [PATCH 1/2] dts: include smoke tests in tests config
Date: Thu, 3 Apr 2025 09:42:45 -0400 [thread overview]
Message-ID: <CAJvnSUBZF2A04C_vhtj2w8-KA2xMo3hXs71huSfK2hbht9Pygg@mail.gmail.com> (raw)
In-Reply-To: <98bbf31f-adda-43e0-acbe-f4e4765883db@arm.com>
[-- Attachment #1: Type: text/plain, Size: 519 bytes --]
Thanks Luca for the info - there is also 1 other fix needed. I'll send a v2.
On Thu, Apr 3, 2025 at 9:45 AM Luca Vizzarro <Luca.Vizzarro@arm.com> wrote:
> Hi Patrick,
>
> this looks good, easy and quick fix. I am afraid that you can't append
> to an `Iterable` type though. I've also confirmed this with mypy:
>
> Unsupported left operand type for + ("Iterable[TestSuiteConfig]")
>
> I guess the easiest fix is to just change the argument type to `list`
> from `Iterable`.
>
> Best,
> Luca
>
>
[-- Attachment #2: Type: text/html, Size: 872 bytes --]
next prev parent reply other threads:[~2025-04-03 13:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 2:30 [PATCH 0/2] dts: smoke test bugfixes Patrick Robb
2025-04-03 2:30 ` [PATCH 1/2] dts: include smoke tests in tests config Patrick Robb
2025-04-03 13:45 ` Luca Vizzarro
2025-04-03 13:42 ` Patrick Robb [this message]
2025-04-03 2:30 ` [PATCH 2/2] dts: update dpdk-devbind script regex Patrick Robb
2025-04-03 13:45 ` Luca Vizzarro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJvnSUBZF2A04C_vhtj2w8-KA2xMo3hXs71huSfK2hbht9Pygg@mail.gmail.com \
--to=probb@iol.unh.edu \
--cc=Luca.Vizzarro@arm.com \
--cc=Paul.Szczepanek@arm.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=npratte@iol.unh.edu \
--cc=thomas.wilks@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).