From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5AC841D9E; Tue, 28 Feb 2023 16:52:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A709E40EE6; Tue, 28 Feb 2023 16:52:42 +0100 (CET) Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) by mails.dpdk.org (Postfix) with ESMTP id 2BE934021F for ; Tue, 28 Feb 2023 16:52:41 +0100 (CET) Received: by mail-ot1-f51.google.com with SMTP id 32-20020a9d0323000000b0069426a71d79so229554otv.10 for ; Tue, 28 Feb 2023 07:52:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=eY561iBZ+kQE4FXqFJtQ1Gyy3ASdZJ3BYrZ7UiR0V1M=; b=aOiauZ4OtepMVfN7XWkE0Sn2YpuoBvXJBqFQHh1DwVsQ7YDXrG0GE1tuVmv2XdwNhq kmUYvjZ6uE7OJdeaKLn5Mv/0CyZg+esvqkAxcqvBU97tumAdas2F1bYFpARO079WJOhi zcqh+qB+r8VbOyqUrMOU03H/89X/h6t/oSoyY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eY561iBZ+kQE4FXqFJtQ1Gyy3ASdZJ3BYrZ7UiR0V1M=; b=d+6HS/WU/cpX2h5QOLRKmblr+mB6SCvNh031pzD2r2UYEa6HlTHDBmNFrdZSPfkLWK D6CE+XawMU65VstJek9trfKg/fj50x6reULdDt0ieXUfmnkwP3fDbyLfcoUQrrTP+GG1 Xl2sY9QoYotkVouXQpBHpAn0SkG4UUjq/bO6QMkgiVdxXA6li8jSbpDalJRg/kMNtnts xVLsVeNbCGokFwABmX5GO8C1izJcU+x6HWe11wOYe2ireiBqrvxwcEryQdnKDbOTbq5A DSjcFzXygUU3ZuVSOkJQ5d0CStLCKhhzBuOeEeJhuh85BvPiz0ourlsNf1cbaWjArnO+ ySzA== X-Gm-Message-State: AO0yUKW0+PDlBoVOKNTCIiKNAPPqsoVXr5CWLoYsOgXoRWCCvGIKisZO T83eae4SRvtzAtp2nb9w/5FdQ/lZSyKh29w+cz5/aQ== X-Google-Smtp-Source: AK7set9SsIuBA5LADo/x9X4Ms0YVmKzCLmAr3TRT20riFJtKRv303ApWDjkniGdgA6IjK34JJhSEmq+IBUbA0C6hUxU= X-Received: by 2002:a05:6830:2468:b0:68b:cd1e:1ef1 with SMTP id x40-20020a056830246800b0068bcd1e1ef1mr1087851otr.7.1677599560420; Tue, 28 Feb 2023 07:52:40 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Patrick Robb Date: Tue, 28 Feb 2023 10:52:29 -0500 Message-ID: Subject: Re: [EXT] Re: [v1, 00/10] fips_validation application improvements To: Akhil Goyal Cc: "Dooley, Brian" , Gowrishankar Muthukrishnan , "dev@dpdk.org" , Anoob Joseph , Jerin Jacob Kollanukkaran , Jeremy Spewock , Lincoln Lavoie Content-Type: multipart/alternative; boundary="000000000000dfe83f05f5c49510" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000dfe83f05f5c49510 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Akhil, One 2023 goal for UNH is implementing an email based retesting framework. Once that work is completed, you will be able to trigger a retest yourself under circumstances where waiting for dependent patches is needed. On Tue, Feb 28, 2023 at 10:02=E2=80=AFAM Akhil Goyal w= rote: > Hi Patrick, > > > > The issue reported by CI in below link is not an issue, as the patchset > was dependent on another patch which is already merged. Now we are > observing a new issue which is coming only on CentOS I believe. > > CI reports are not useful in case there are dependent patches. There > should be a way maintainer/developer can retrigger the CI as required whe= n > other patches are merged. > > > > This issue got skipped as I personally do not test on CentOS and CI > results are not meaningful when there were dependent patches. > > Below is the log for the compilation issue observed now on TOT when these > patches are applied which is not visible in the below link. > > > > > OS: CentOS79-64 > > > Target: x86_64-native-linuxapp-gcc > > > FAILED: examples/dpdk-fips_validation.p/fips_validation_main.c.o > > > gcc -Iexamples/dpdk-fips_validation.p -Iexamples -I../examples - > > > Iexamples/fips_validation -I../examples/fips_validation > -I../examples/common - > > > I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include - > > > Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include= - > > > I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal > -I../lib/eal > > > -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics > -Ilib/telemetry - > > > I../lib/telemetry -Ilib/mempool -I../lib/mempool -Ilib/ring > -I../lib/ring -Ilib/net - > > > I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/ethdev -I../lib/ethdev > -Ilib/meter - > > > I../lib/meter -Ilib/cmdline -I../lib/cmdline -Ilib/cryptodev > -I../lib/cryptodev - > > > Ilib/rcu -I../lib/rcu -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Wex= tra > - > > > Werror -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat - > > > Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing- > > > prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith > -Wsign- > > > compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-missing-field- > > > initializers -D_GNU_SOURCE -march=3Dnative -DUSE_OPENSSL - > > > DALLOW_EXPERIMENTAL_API -MD -MQ examples/dpdk- > > > fips_validation.p/fips_validation_main.c.o -MF examples/dpdk- > > > fips_validation.p/fips_validation_main.c.o.d -o examples/dpdk- > > > fips_validation.p/fips_validation_main.c.o -c > ../examples/fips_validation/main.c > > > ../examples/fips_validation/main.c: In function 'fips_mct_shake_test': > > > ../examples/fips_validation/main.c:2438:5: error: dereferencing > type-punned > > > pointer will break strict-aliasing rules [-Werror=3Dstrict-aliasing] > > > (*(uint16_t *)rightmost % range); > > > ^ > > > > > > Regards, > > Akhil > > > ------------------------------ > > Hello Akhil and Gowrishankar, > > > > We saw the same issue with running the fips sample app under CI testing > here at the UNH Community Lab: > http://mails.dpdk.org/archives/test-report/2023-February/350635.html > . > We reported a warn because it failed on the compilation stage (as opposed > to a failure of the actual sample app run). > > > > On the other hand, we are excited to see this patch again with the > compilation part resolved. I sent an email to the dev mailing list a few > weeks ago for our fips sample app CI testing regarding where we could and > could not provide test vector coverage, and it appears this patch series > may resolve our ciphertext issue with AES-GCM test vector and more issues > with the sample app. So - looking forward to seeing a patch like this bei= ng > merged when stable! > > > > Best, > > Patrick Robb > > > > > > > > > > On Tue, Feb 28, 2023 at 2:39=E2=80=AFAM Akhil Goyal = wrote: > > Hi Gowrishankar, > > > > > > > Subject: [v1, 00/10] fips_validation application improvements > > > > > > > > This patch series adds support for SHA3, SHAKE, AES-CCM JSON test > vectors > > > > and fixes existing algorithms to support NIST test vectors. > > > > > > > > Gowrishankar Muthukrishnan (10): > > > > examples/fips_validation: fix MCT output for SHA > > > > examples/fips_validation: add SHA3 validation > > > > examples/fips_validation: fix integer parse in test case > > > > examples/fips_validation: add SHAKE validation > > > > examples/fips_validation: add CCM JSON validation > > > > examples/fips_validation: add ECDSA keygen support > > > > examples/fips_validation: add SHA3 algorithms in ECDSA test > > > > examples/fips_validation: fix AES GCM validation tests > > > > examples/fips_validation: fix AES XTS to read seq number > > > > examples/fips_validation: add extra space in JSON buffer > > > > > > > > doc/guides/sample_app_ug/fips_validation.rst | 7 +- > > > > examples/fips_validation/fips_validation.c | 31 ++- > > > > examples/fips_validation/fips_validation.h | 10 +- > > > > .../fips_validation/fips_validation_ccm.c | 132 ++++++++++++ > > > > .../fips_validation/fips_validation_ecdsa.c | 56 +++++ > > > > .../fips_validation/fips_validation_gcm.c | 12 +- > > > > .../fips_validation/fips_validation_hmac.c | 8 + > > > > .../fips_validation/fips_validation_sha.c | 91 ++++++-- > > > > .../fips_validation/fips_validation_xts.c | 13 +- > > > > examples/fips_validation/main.c | 196 > +++++++++++++----- > > > > 10 files changed, 467 insertions(+), 89 deletions(-) > > > > > > > > -- > > > > 2.25.1 > > > > > > Series-acked-by: Brian Dooley > > > > Series Applied to dpdk-next-crypto > The series is showing compilation issues, please fix it. The series is > removed from the tree. > > > > > -- > > Patrick Robb > > Technical Service Manager > > UNH InterOperability Laboratory > > 21 Madbury Rd, Suite 100, Durham, NH 03824 > > www.iol.unh.edu > > > > > --=20 Patrick Robb Technical Service Manager UNH InterOperability Laboratory 21 Madbury Rd, Suite 100, Durham, NH 03824 www.iol.unh.edu --000000000000dfe83f05f5c49510 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Akhil,

One 2023 goal for UNH is impl= ementing an email based retesting framework. Once that work is completed, y= ou will be able to trigger a retest yourself under circumstances where wait= ing for dependent patches is needed.=C2=A0

On Tue, Feb 28, 2023 at 10:= 02=E2=80=AFAM Akhil Goyal <gakhil@= marvell.com> wrote:

Hi Patrick,

=C2=A0

The issue reported by CI in below link is not an iss= ue, as the patchset was dependent on another patch which is already merged.= Now we are observing a new issue which is coming only on CentOS I believe.=

CI reports are not useful in case there are dependen= t patches. There should be a way maintainer/developer can retrigger the CI = as required when other patches are merged.

=C2=A0

This issue got skipped as I personally do not test o= n CentOS and CI results are not meaningful when there were dependent patche= s.

Below is the log for the compilation issue observed = now on TOT when these patches are applied which is not visible in the below= link.

=C2=A0

> OS: CentOS79-64<= u>

> Target: x86_64-native-l= inuxapp-gcc

> FAILED: examples/dpdk-f= ips_validation.p/fips_validation_main.c.o

> gcc -Iexamples/dpdk-fip= s_validation.p -Iexamples -I../examples -

> Iexamples/fips_validati= on -I../examples/fips_validation -I../examples/common -

> I. -I.. -Iconfig -I../c= onfig -Ilib/eal/include -I../lib/eal/include -

> Ilib/eal/linux/include = -I../lib/eal/linux/include -Ilib/eal/x86/include -

> I../lib/eal/x86/include= -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal<= /p>

> -Ilib/kvargs -I../lib/k= vargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry -

> I../lib/telemetry -Ilib= /mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/net -

> I../lib/net -Ilib/mbuf = -I../lib/mbuf -Ilib/ethdev -I../lib/ethdev -Ilib/meter -

> I../lib/meter -Ilib/cmd= line -I../lib/cmdline -Ilib/cryptodev -I../lib/cryptodev -

> Ilib/rcu -I../lib/rcu -= D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Wextra -

> Werror -O3 -include rte= _config.h -Wcast-qual -Wdeprecated -Wformat -

> Wformat-nonliteral -Wfo= rmat-security -Wmissing-declarations -Wmissing-

> prototypes -Wnested-ext= erns -Wold-style-definition -Wpointer-arith -Wsign-

> compare -Wstrict-protot= ypes -Wundef -Wwrite-strings -Wno-missing-field-

> initializers -D_GNU_SOU= RCE -march=3Dnative -DUSE_OPENSSL -

> DALLOW_EXPERIMENTAL_API= -MD -MQ examples/dpdk-

> fips_validation.p/fips_= validation_main.c.o -MF examples/dpdk-

> fips_validation.p/fips_= validation_main.c.o.d -o examples/dpdk-

> fips_validation.p/fips_= validation_main.c.o -c ../examples/fips_validation/main.c

> ../examples/fips_valida= tion/main.c: In function 'fips_mct_shake_test':

> ../examples/fips_valida= tion/main.c:2438:5: error: dereferencing type-punned

> pointer will break stri= ct-aliasing rules [-Werror=3Dstrict-aliasing]

>=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 (*(uint16_t *)rightmost % range);

>=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 ^

=C2=A0

=C2=A0

Regards,

Akhil

=C2=A0

Hello Akhil and Gowrishankar,

=C2=A0

We saw the same issue with running the fips sample a= pp under CI testing here at the UNH Community Lab:=C2=A0http://mails= .dpdk.org/archives/test-report/2023-February/350635.html. We reported a warn because it failed on the compilation stage (as opposed = to a failure of the actual sample app run).

=C2=A0

On the other hand, we are excited to see this patch = again with the compilation part resolved. I sent an email to the dev mailin= g list a few weeks ago for our fips sample app CI testing regarding where w= e could and could not provide test vector coverage, and it appears this patch series may resolve our cipherte= xt issue with AES-GCM test vector and more issues with the sample app. So -= looking forward to seeing a patch like this being merged when stable!=C2= =A0

=C2=A0

Best,

Patrick Robb

=C2=A0

=C2=A0



=C2=A0

On Tue, Feb 28, 2023 at 2:39=E2=80=AFAM Akhil Goyal = <gakhil@marvell.= com> wrote:

Hi Gowrishankar,
> >
> > > Subject: [v1, 00/10] fips_validation application improvement= s
> > >
> > > This patch series adds support for SHA3, SHAKE, AES-CCM JSON= test vectors
> > > and fixes existing algorithms to support NIST test vectors.<= br> > > >
> > > Gowrishankar Muthukrishnan (10):
> > >=C2=A0 =C2=A0examples/fips_validation: fix MCT output for SHA=
> > >=C2=A0 =C2=A0examples/fips_validation: add SHA3 validation > > >=C2=A0 =C2=A0examples/fips_validation: fix integer parse in t= est case
> > >=C2=A0 =C2=A0examples/fips_validation: add SHAKE validation > > >=C2=A0 =C2=A0examples/fips_validation: add CCM JSON validatio= n
> > >=C2=A0 =C2=A0examples/fips_validation: add ECDSA keygen suppo= rt
> > >=C2=A0 =C2=A0examples/fips_validation: add SHA3 algorithms in= ECDSA test
> > >=C2=A0 =C2=A0examples/fips_validation: fix AES GCM validation= tests
> > >=C2=A0 =C2=A0examples/fips_validation: fix AES XTS to read se= q number
> > >=C2=A0 =C2=A0examples/fips_validation: add extra space in JSO= N buffer
> > >
> > >=C2=A0 doc/guides/sample_app_ug/fips_validation.rst=C2=A0 |= =C2=A0 =C2=A07 +-
> > >=C2=A0 examples/fips_validation/fips_validation.c=C2=A0 =C2= =A0 |=C2=A0 31 ++-
> > >=C2=A0 examples/fips_validation/fips_validation.h=C2=A0 =C2= =A0 |=C2=A0 10 +-
> > >=C2=A0 .../fips_validation/fips_validation_ccm.c=C2=A0 =C2=A0= =C2=A0| 132 ++++++++++++
> > >=C2=A0 .../fips_validation/fips_validation_ecdsa.c=C2=A0 =C2= =A0|=C2=A0 56 +++++
> > >=C2=A0 .../fips_validation/fips_validation_gcm.c=C2=A0 =C2=A0= =C2=A0|=C2=A0 12 +-
> > >=C2=A0 .../fips_validation/fips_validation_hmac.c=C2=A0 =C2= =A0 |=C2=A0 =C2=A08 +
> > >=C2=A0 .../fips_validation/fips_validation_sha.c=C2=A0 =C2=A0= =C2=A0|=C2=A0 91 ++++++--
> > >=C2=A0 .../fips_validation/fips_validation_xts.c=C2=A0 =C2=A0= =C2=A0|=C2=A0 13 +-
> > >=C2=A0 examples/fips_validation/main.c=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 196 +++++++++++++-----
> > >=C2=A0 10 files changed, 467 insertions(+), 89 deletions(-) > > >
> > > --
> > > 2.25.1
> >
> > Series-acked-by: Brian Dooley <brian.dooley@intel.com>
>
> Series Applied to dpdk-next-crypto
The series is showing compilation issues, please fix it. The series is remo= ved from the tree.


=C2=A0

--

Patrick Robb

Technical Service Manager

UNH InterOperability Laboratory

21 Madbury Rd, Suite 100, Durham, NH 03824

www.iol.unh.edu

=C2=A0



--

Pat= rick Robb

Technical Service Manager

UNH In= terOperability Laboratory

21 Madbury Rd, Suite 100, Durh= am, NH 03824

www.iol.unh.edu


--000000000000dfe83f05f5c49510--