From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D0B443E06; Fri, 5 Apr 2024 16:32:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4A3D402EC; Fri, 5 Apr 2024 16:32:24 +0200 (CEST) Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) by mails.dpdk.org (Postfix) with ESMTP id C87184028B for ; Fri, 5 Apr 2024 16:32:23 +0200 (CEST) Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-5a7d6bc81c6so1401520eaf.2 for ; Fri, 05 Apr 2024 07:32:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1712327543; x=1712932343; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gIq1aNtMVtIj9BslObXM/lQQIEvwCE/4GTzL9QQeNig=; b=hDjTuU4JX9mV046w6TKApawoj8HbuN96IHy1BDqIG5mRj4Z9fOdrHvJeR2qR76W9k8 jE6T+vcQdpAJzONPYukXY0o5ClrIwsXZt/4ucG4LUAQkkSHkl2a5hFhyygMcIrHet5nM hfGo82dP3sd8cAGLvtEEyQ8pSdeKPl9hqFbyY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712327543; x=1712932343; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gIq1aNtMVtIj9BslObXM/lQQIEvwCE/4GTzL9QQeNig=; b=UBwQgAQxk4JlZa6CnnUbMQaGe7IokZAnr37GpDcYmBch4/sLeHoIgC7Va4GN8Tt4O5 PsvSgh9r20b7DTvSZ+r0/35W9P/bNsGyQjkNNWivQSIRymKp0tySCXUYO+aPdAcK7HQT O879UVs2/JZKqihFx4nP21k8wKo0RzQPLw2x7gKDhukLcdeKcnLsOGG5J/kz5bpxCAcb 2KIge4ee1xeVawEag4VAWjaH/cOJFT2QDDRNDfcf//Z4+cqMPtuTcCAHxd2mwhN80qZl aXLl5mqrYvRzJrtDwBmuJ0LpmGvy5Facj+0T/bum6595uK6lAIru25igA2sIRLwFlX4I YhFw== X-Forwarded-Encrypted: i=1; AJvYcCXYdKjeCZDo/tJX3qTvWNP0eAdg5B7tmAZSiQCT9/tagkO3WBFUZk/0vLU9Df2ioMXG2XYwH4hS4PcNdjo= X-Gm-Message-State: AOJu0Ywr0nnJy10EyVKIb4de9bGwhR2n02k7Rnwhq/HUiEdiHDw15fHZ 6SGMrErgO4utv6WVzsJ5gfIBTSSgavHeXVAvgL6lD0qMQNmN1ZNGpaS0JHWEr1brlreiv0gni8B YMt+TxgFJACbMa/roE+6CxV+NJ1yRkjRw2Ppq7Q== X-Google-Smtp-Source: AGHT+IG2KKXhDf7IbptZbd9iEjMo18yDK9fl2IFAvwIYj8mcBSGbeaTPvmmNpDzdLOUiw4dfGJg/G2sxOmk5sKOnNaI= X-Received: by 2002:a05:6820:1e12:b0:5a7:c7e2:2818 with SMTP id dh18-20020a0568201e1200b005a7c7e22818mr1825309oob.1.1712327543046; Fri, 05 Apr 2024 07:32:23 -0700 (PDT) MIME-Version: 1.0 References: <20240403115541.2369-1-julien.meunier@nokia.com> In-Reply-To: From: Patrick Robb Date: Fri, 5 Apr 2024 10:32:11 -0400 Message-ID: Subject: Re: [PATCH] net/fm10k: fix cleanup during init failure To: Bruce Richardson Cc: Julien Meunier , Jing Chen , Jeff Shaw , Michael Qiu , dev@dpdk.org, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Recheck-request: iol-intel-Functional I see it's applied but I just want to clean up the record - checking for lab infra failure On Thu, Apr 4, 2024 at 6:39=E2=80=AFAM Bruce Richardson wrote: > > On Thu, Apr 04, 2024 at 11:18:16AM +0100, Bruce Richardson wrote: > > On Wed, Apr 03, 2024 at 01:55:41PM +0200, Julien Meunier wrote: > > > Cleanup was not done on this PMD if a error is seen during the init: > > > - possible memory leak due to a missing free > > > - interrupt handler was not disabled: if an IRQ is received after the > > > init, a SIGSEGV can be seen (private data stored in > > > rte_eth_devices[port_id] is pointing to NULL) > > > > > > Fixes: a6061d9e7075 ("fm10k: register PF driver") > > > Fixes: 4c287332c39a ("fm10k: add PF and VF interrupt handling") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Julien Meunier > > > > Changes LGTM > > > > Reviewed-by: Bruce Richardson > > There are CI failures flagged in patchwork, but they appear unrelated to > this patch itself. > > Patch applied to dpdk-next-net-intel. > Thanks, > /Bruce