DPDK patches and discussions
 help / color / mirror / Atom feed
From: Patrick Robb <probb@iol.unh.edu>
To: Dean Marx <dmarx@iol.unh.edu>
Cc: luca.vizzarro@arm.com, yoan.picchi@foss.arm.com,
	 Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com,
	dev@dpdk.org
Subject: Re: [PATCH v5 3/3] doc: revise coding guidelines section
Date: Wed, 16 Jul 2025 14:19:49 -0400	[thread overview]
Message-ID: <CAJvnSUCw3XKmd0jOUYJ5f+VVaG5ngJbpsWAJ7RPyonoJKgF75Q@mail.gmail.com> (raw)
In-Reply-To: <20250716135708.49233-3-dmarx@iol.unh.edu>

[-- Attachment #1: Type: text/plain, Size: 2030 bytes --]

On Wed, Jul 16, 2025 at 9:57 AM Dean Marx <dmarx@iol.unh.edu> wrote:

>
> +
> +* Document ``__init__()`` separately from the class docstring.
> +* If an abstract method simply implements a superclass definition without
> changes, refer to that superclass in the docstring.
> +* Document instance variables in the class docstring under an
> ``Attributes:`` section.
> +* For ``@dataclass`` classes, document instance-level attributes in
> ``Attributes:``, as they are generated from the class fields.
> +* Document class variables and Pydantic fields using ``#:``,
> +   placed above the type-annotated line. Descriptions may be omitted if
> the meaning is clear.
> +* Apply ``#:`` to ``Enum`` and ``TypedDict`` fields as well, so that
> autogenerated documentation includes their values.
> +* When referring to a parameter in a docstring, omit articles and enclose
> the parameter in single backticks (e.g., `` `param` ``),
>

There is actually a docs build failure on GHA from this line:
https://mails.dpdk.org/archives/test-report/2025-July/894788.html

One option would be to escape the backticks like \`. But, it's even better
to just drop the inline single and double backtick examples given that you
have an example block below which shows both. So, keep the bulleted
descriptions, but remove the examples in parenthesis.



> +   consistent with the `Python documentation style <
> https://docs.python.org/3/index.html>`_.
> +* Use double backticks (````value````) for literal values.
> +
> +Example::
> +
> +   def foo(greet: bool) -> None:
> +       """Demonstrates single and double backticks.
> +
> +       `greet` controls whether ``Hello World`` is printed.
> +
> +       Args:
> +           greet: Whether to print the ``Hello World`` message.
> +       """
> +       if greet:
> +           print("Hello World")
> +
> +The maximum line length for docstrings must match that of the code.
>
>
>  How To Write a Test Suite
>  -------------------------
>
>
>
>

[-- Attachment #2: Type: text/html, Size: 2852 bytes --]

  reply	other threads:[~2025-07-16 18:25 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-27 15:37 [PATCH v1 1/3] dts: rewrite README Dean Marx
2025-05-27 15:37 ` [PATCH v1 2/3] dts: rewrite dts rst Dean Marx
2025-05-28 21:25   ` Patrick Robb
2025-05-29 12:27     ` Paul Szczepanek
2025-06-03 17:28   ` [PATCH v2 1/2] dts: rewrite README Dean Marx
2025-06-03 17:28     ` [PATCH v2 2/2] dts: rewrite dts rst Dean Marx
2025-06-25  4:07       ` Patrick Robb
2025-07-09 19:57         ` Thomas Monjalon
2025-07-11 14:58           ` Patrick Robb
2025-06-25  4:06     ` [PATCH v2 1/2] dts: rewrite README Patrick Robb
2025-07-11 17:24     ` [PATCH v3 1/3] " Dean Marx
2025-07-11 17:24       ` [PATCH v3 2/3] doc: rephrase terminology in dts.rst Dean Marx
2025-07-14 14:10         ` Patrick Robb
2025-07-11 17:24       ` [PATCH v3 3/3] doc: revise coding guidelines section Dean Marx
2025-07-14 16:22         ` Patrick Robb
2025-07-11 21:22       ` [PATCH v3 1/3] dts: rewrite README Patrick Robb
2025-07-14 14:47         ` Dean Marx
2025-07-14 17:13       ` [PATCH v4 " Dean Marx
2025-07-14 17:13         ` [PATCH v4 2/3] doc: rephrase terminology in dts.rst Dean Marx
2025-07-14 17:13         ` [PATCH v4 3/3] doc: revise coding guidelines section Dean Marx
2025-07-15 22:25           ` Patrick Robb
2025-07-15 21:52         ` [PATCH v4 1/3] dts: rewrite README Patrick Robb
2025-07-16 13:57         ` [PATCH v5 " Dean Marx
2025-07-16 13:57           ` [PATCH v5 2/3] doc: rephrase terminology in dts.rst Dean Marx
2025-07-16 13:57           ` [PATCH v5 3/3] doc: revise coding guidelines section Dean Marx
2025-07-16 18:19             ` Patrick Robb [this message]
2025-07-16 18:25           ` [PATCH v6 1/3] dts: rewrite README Dean Marx
2025-07-16 18:25             ` [PATCH v6 2/3] doc: rephrase terminology in dts.rst Dean Marx
2025-07-16 18:25             ` [PATCH v6 3/3] doc: revise coding guidelines section Dean Marx
2025-07-16 20:53             ` [PATCH v7 1/3] dts: rewrite README Dean Marx
2025-07-16 20:53               ` [PATCH v7 2/3] doc: rephrase terminology in dts.rst Dean Marx
2025-07-16 20:54               ` [PATCH v7 3/3] doc: revise coding guidelines section Dean Marx
2025-07-16 21:58                 ` Patrick Robb
2025-05-27 15:37 ` [PATCH v1 3/3] dts: fix doc generation bug Dean Marx
2025-05-28 20:28   ` Patrick Robb
2025-05-29 12:28     ` Paul Szczepanek
2025-05-28 20:40 ` [PATCH v1 1/3] dts: rewrite README Patrick Robb
2025-05-29 12:27   ` Paul Szczepanek
2025-05-29 12:40 ` Paul Szczepanek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJvnSUCw3XKmd0jOUYJ5f+VVaG5ngJbpsWAJ7RPyonoJKgF75Q@mail.gmail.com \
    --to=probb@iol.unh.edu \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=dmarx@iol.unh.edu \
    --cc=luca.vizzarro@arm.com \
    --cc=paul.szczepanek@arm.com \
    --cc=yoan.picchi@foss.arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).