From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DB1643E06; Fri, 5 Apr 2024 16:30:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED298402CE; Fri, 5 Apr 2024 16:30:11 +0200 (CEST) Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) by mails.dpdk.org (Postfix) with ESMTP id 3A1234028B for ; Fri, 5 Apr 2024 16:30:10 +0200 (CEST) Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-5a46abf093cso1276761eaf.2 for ; Fri, 05 Apr 2024 07:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1712327409; x=1712932209; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DKwXR8kHkq/9AX2CjHPV5Wg/G41O27r0DvagxZKOofU=; b=IX07DT0Z0UGY9Ixim/wrAEr+ro7VlESEQ/D+l9PcSt2c76UHq2dpKuXoBgLassTyrV GXisNfc83pi+QivzcMc3FPLfm7sLYks//8A1+oxL4NMWlX96WPLvNBtIzp21X9XEx26b 8ajqGoAF4S9RaHRQCme8yto7K2t1aHWxeyP1Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712327409; x=1712932209; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DKwXR8kHkq/9AX2CjHPV5Wg/G41O27r0DvagxZKOofU=; b=G+ih1TrhQ+695ViHgJ/wlV5rHaztoa6knKPAZjABQpcP/CQvB+bM/3OEvBrOMQqps0 Gv6+SaX7lud97aiv7IDj/jJtQg4K5Iarzs1phaPO1TEd2oNRFrIdFh9YclwAYCX0GiK3 pskmpxRvAvXh6cQG2YTaRpssMLUGzKrl0QfpwZFMb5JB8Cb2/tJ9fugkwyNz7Cul8at9 BezCR7i/OGpcL9Hph9R4Ay7Nek6gOLMt3YMhqqhj+pwOJ8E9B57RllBnrYoG5D+9Ukfk 0WSNvooXwjqRpf6mwSjmrfWAksxn0mwmEbS21thJXHmkdWeD9YDb/Ou9Kz+DTniBQ7og PzaQ== X-Forwarded-Encrypted: i=1; AJvYcCWYeiSN2UPNu2jxR7G29Y0R/YjQWda39hqsNtH0gvJ2pcOn9BKHgQm924pE51WG5prfeEEwwBBeLNdgCMA= X-Gm-Message-State: AOJu0Yxq0xSu30QFa5l643riPRoFLfCnYS7UZP7/ic+WzL0twQ6cHjxj wJ0NQJAEWpwd/9tpcehkESPHMsS4+qhjJxXg5MXQakXkkEnQPUqUSwlG+tFEuIntxBNN/iBTFLS XPP8Wu4w5l9WJEM/yuhYojinmwibI7zMntBU7og== X-Google-Smtp-Source: AGHT+IFdTKzBIwOXtYqeOu5XPcEr0p1yEHXpNnPz0yFOt/v9VEDmRAyW7QlHYXhIeU5XNnvY2lgouXGgYzjHuz+Pkxk= X-Received: by 2002:a4a:384c:0:b0:5a5:639a:2fb0 with SMTP id o12-20020a4a384c000000b005a5639a2fb0mr1332959oof.7.1712327409573; Fri, 05 Apr 2024 07:30:09 -0700 (PDT) MIME-Version: 1.0 References: <1712076948-25853-1-git-send-email-roretzla@linux.microsoft.com> <1712168600-17289-1-git-send-email-roretzla@linux.microsoft.com> <20240403145136.449ef6e0@hermes.local> In-Reply-To: <20240403145136.449ef6e0@hermes.local> From: Patrick Robb Date: Fri, 5 Apr 2024 10:29:58 -0400 Message-ID: Subject: Re: [PATCH v2] build: exclude rather than include libs in MSVC build To: Stephen Hemminger Cc: Tyler Retzlaff , dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Andrew Rybchenko , Bruce Richardson , Chengwen Feng , Honnappa Nagarahalli , Kevin Laatz , Srikanth Yalavarthi , Vladimir Medvedkin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Recheck-request: iol-intel-Functional checking for lab infra failure On Wed, Apr 3, 2024 at 5:51=E2=80=AFPM Stephen Hemminger wrote: > > On Wed, 3 Apr 2024 11:23:19 -0700 > Tyler Retzlaff wrote: > > > Some libraries that could be built with MSVC were not being built. > > > > Switch from explicit include to exclude of libs to get immediate CI > > coverage of libraries that already work with MSVC Windows builds. > > > > With this change we now get immediate CI build coverage for the libs > > meter, timer, pci, cfgfile > > > > v2: > > * add a few more explicit exclusions for now as they are known to requ= ire > > more than trivial work and avoid needing to disable them later as th= e > > dependent libraries are enabled. > > If you need to do another revision, it might be good idea to add comment > to the meson.build file when doing exclusions as to what is missing.