From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D2E6A00C2; Thu, 8 Dec 2022 17:07:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4AE940E28; Thu, 8 Dec 2022 17:07:10 +0100 (CET) Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by mails.dpdk.org (Postfix) with ESMTP id C694F40A7E for ; Thu, 8 Dec 2022 17:07:08 +0100 (CET) Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-1443a16b71cso2291148fac.13 for ; Thu, 08 Dec 2022 08:07:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=m/nXdX2ymd2vWXhnf6dqVufW2VqD04Z3k1SZxpnQbU0=; b=Mzv7tkpHSbYhiTFJ/nAmbS9OmIfQwpoFDL8TvE4gv4YaCq3jT7yeIFdH9j4AOejFGC nPIvPscjJH+3LL4tBROg7ZBSbz3jgVJiMYjtGM5MWAThQHc+S/ArJDXDpEFauwB0D7rk igkc8Tc7K4WhWDI38TWwbVL8FFo2/1coUNUys= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=m/nXdX2ymd2vWXhnf6dqVufW2VqD04Z3k1SZxpnQbU0=; b=54R7tTGB/DwSEE0y6VvvczBunKV+lJxh8NhfdMvmaMzoG33O3S2gMEfVIbU4VwE72g LSa+bZUO5g1wgnwLxarJoX9XrYMl+Pj6iV5PDEB1vQ3AMcgfMnRWxHX05lgum/BdKolI HCPjEOntzo4HiPOCRLGVA0o3z+4OHhwOJvIgsANDYilWlpLH+xfl7Noz2HdErQ39HsVu UTnVQtuY+7eSUmzCzWCALOnTEuZ4uC0vvOyGO81aTLOjobNR6PjpnNxQC66csHVTF05c fuBqTZRCITZVY8msCnkFS89i2c3/v2kYFr5eTWV37fWvt6CWs1UTGl7gtgjgyo4uOGrt 0Egw== X-Gm-Message-State: ANoB5pkNtqSxB+wYPCSN6+IQ2M71sMPJJiTg66s79HQPiZ5kQJUb0BPQ vFh+2RI8qSFUVyam6CuA5sGcmMn7qNjFRGKaBdvMCg== X-Google-Smtp-Source: AA0mqf6yVKisUpoOCWtSydSFoIYigdEZSQwzg943X/Xbt0EWneqv+zimuWwxw5KH+kU2XtzLuddtpdN32l+qHsFVRXc= X-Received: by 2002:a05:6870:4b4b:b0:131:be7a:3415 with SMTP id ls11-20020a0568704b4b00b00131be7a3415mr40563327oab.269.1670515627882; Thu, 08 Dec 2022 08:07:07 -0800 (PST) MIME-Version: 1.0 References: <20221129140032.35940-1-david.marchand@redhat.com> <16994d83-8f31-1ee6-94b5-abfefb8566fb@amd.com> <4188342.mogB4TqSGs@thomas> In-Reply-To: <4188342.mogB4TqSGs@thomas> From: Patrick Robb Date: Thu, 8 Dec 2022 11:06:57 -0500 Message-ID: Subject: Re: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted To: Thomas Monjalon Cc: Ferruh Yigit , David Marchand , Akhil Goyal , "ci@dpdk.org" , Andrew Rybchenko , Ajit Khaparde , Qi Zhang , Jerin Jacob Kollanukkaran , Raslan Darawsheh , Maxime Coquelin , "Xia, Chenbo" , Luca Boccassi , Kevin Traynor , Christian Ehrhardt , "Xueming(Steven) Li" , "dev@dpdk.org" , "stable@dpdk.org" , Bruce Richardson , Michael Santana , =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= , Aaron Conole Content-Type: multipart/alternative; boundary="00000000000097942f05ef533a03" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000097942f05ef533a03 Content-Type: text/plain; charset="UTF-8" Thomas - thanks for the response. We will proceed with making the necessary changes for using v22.11.1. On Thu, Dec 8, 2022 at 8:22 AM Thomas Monjalon wrote: > I'm sorry Patrick that it gives you more work. > Your proposals below don't look possible because a tag is something fixed > forever. > We had an ABI issue in the initial tag so we cannot use the tag v22.11 as > planned. > I don't see how we can better plan except having more tests on release > candidates. > > > 07/12/2022 19:00, Patrick Robb: > > Hello, > > > > Community Lab team members are wondering whether it is possible to bump > > v22.11 to include at least this patch. We have an existing codebase which > > relies on a vXX.XX scheme for producing ABI references. We parse that out > > at different places in our code, so fixing this to handle vXX.XX.X will > > require some changes on our end. We can do that, but it puts the timeline > > on turning on ABI testing at the community lab back some. A v22.11 tagged > > release with this patch would allow for us to turn on ABI testing > > immediately. There was also a suggestion that having the "base" tag (like > > the simple v22.11) point to the latest revision is a more standard > version > > naming approach and may be more intuitive than what is being used > currently. > > > > If that is not possible, we will update our code to be able to refer to a > > vXX.XX.X tag for producing the ABI reference. If we adopt this approach, > we > > would like to request that with future releases, a "vXX.XX.0" tag could > > always be made available for us to produce ABI references from. That way, > > we can prepare for turning on ABI testing knowing beforehand the tag name > > we will be using. > > > > On Tue, Dec 6, 2022 at 7:25 AM Ferruh Yigit > wrote: > > > > > On 12/6/2022 10:18 AM, David Marchand wrote: > > > > On Tue, Dec 6, 2022 at 11:13 AM Ferruh Yigit > > > wrote: > > > >> On 12/5/2022 3:37 PM, Thomas Monjalon wrote: > > > >>> 05/12/2022 14:47, Akhil Goyal: > > > >>>> But adding a tag on same repo is more convenient from developer > point > > > of view. > > > >>>> However, it is my personal view, others may differ. > > > >>> > > > >>> From developer point of view, you should use > > > devtools/test-meson-builds.sh > > > >>> which does the "git clone" for you. > > > >>> > > > >>> This is what I have in ~/.config/dpdk/devel.config > > > >>> export DPDK_ABI_REF_DIR=$root/dpdk-build/abiref > > > >>> export DPDK_ABI_REF_VERSION=v22.11.1 > > > >>> > > > >> > > > >> Does it help to update 'test-meson-builds.sh' to use an environment > > > >> variable to select which repo to clone? > > > >> If so, I can send a patch for it. > > > > > > > > I was wondering too... > > > > I would expect most maintainers have the stable repo in their config > > > > but it would not hurt to handle the case when they don't for others. > > > > > > > > +1 > > > > > > Sent following if it helps: > > > https://patches.dpdk.org/project/dpdk/list/?series=26015 > > > > > > -- Patrick Robb Technical Service Manager UNH InterOperability Laboratory 21 Madbury Rd, Suite 100, Durham, NH 03824 www.iol.unh.edu --00000000000097942f05ef533a03 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thomas - thanks for the response. We will proceed with mak= ing the necessary changes for using v22.11.1.

On Thu, Dec 8, 2022 at 8:22 AM= Thomas Monjalon <thomas@monjalon= .net> wrote:
I'm sorry Patrick that it gives you more work.
Your proposals below don't look possible because a tag is something fix= ed forever.
We had an ABI issue in the initial tag so we cannot use the tag v22.11 as p= lanned.
I don't see how we can better plan except having more tests on release = candidates.


07/12/2022 19:00, Patrick Robb:
> Hello,
>
> Community Lab team members are wondering whether it is possible to bum= p
> v22.11 to include at least this patch. We have an existing codebase wh= ich
> relies on a vXX.XX scheme for producing ABI references. We parse that = out
> at different places in our code, so fixing this to handle vXX.XX.X wil= l
> require some changes on our end. We can do that, but it puts the timel= ine
> on turning on ABI testing at the community lab back some. A v22.11 tag= ged
> release with this patch would allow for us to turn on ABI testing
> immediately. There was also a suggestion that having the "base&qu= ot; tag (like
> the simple v22.11) point to the latest revision is a more standard ver= sion
> naming approach and may be more intuitive than what is being used curr= ently.
>
> If that is not possible, we will update our code to be able to refer t= o a
> vXX.XX.X tag for producing the ABI reference. If we adopt this approac= h, we
> would like to request that with future releases, a "vXX.XX.0"= ; tag could
> always be made available for us to produce ABI references from. That w= ay,
> we can prepare for turning on ABI testing knowing beforehand the tag n= ame
> we will be using.
>
> On Tue, Dec 6, 2022 at 7:25 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote:
>
> > On 12/6/2022 10:18 AM, David Marchand wrote:
> > > On Tue, Dec 6, 2022 at 11:13 AM Ferruh Yigit <ferruh.yigit@amd.com>=
> > wrote:
> > >> On 12/5/2022 3:37 PM, Thomas Monjalon wrote:
> > >>> 05/12/2022 14:47, Akhil Goyal:
> > >>>> But adding a tag on same repo is more convenient= from developer point
> > of view.
> > >>>> However, it is my personal view, others may diff= er.
> > >>>
> > >>> From developer point of view, you should use
> > devtools/test-meson-builds.sh
> > >>> which does the "git clone" for you.
> > >>>
> > >>> This is what I have in ~/.config/dpdk/devel.config > > >>> export DPDK_ABI_REF_DIR=3D$root/dpdk-build/abiref > > >>> export DPDK_ABI_REF_VERSION=3Dv22.11.1
> > >>>
> > >>
> > >> Does it help to update 'test-meson-builds.sh' to= use an environment
> > >> variable to select which repo to clone?
> > >> If so, I can send a patch for it.
> > >
> > > I was wondering too...
> > > I would expect most maintainers have the stable repo in thei= r config
> > > but it would not hurt to handle the case when they don't= for others.
> > >
> > > +1
> >
> > Sent following if it helps:
> > https://patches.dpdk.org/project= /dpdk/list/?series=3D26015







--

Patrick Rob= b

Technical Service Manager

UNH InterOpera= bility Laboratory

21 Madbury Rd, Suite 100, Durham, NH 0= 3824

www.iol.unh.edu


--00000000000097942f05ef533a03--