From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5EA7242FAB; Tue, 1 Aug 2023 02:39:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E74CF40A7D; Tue, 1 Aug 2023 02:39:44 +0200 (CEST) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) by mails.dpdk.org (Postfix) with ESMTP id 28806400D5 for ; Tue, 1 Aug 2023 02:39:43 +0200 (CEST) Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-6bca3588edbso936777a34.0 for ; Mon, 31 Jul 2023 17:39:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1690850382; x=1691455182; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=W278oxGPT/K5dQ5JKjNHn0SiDujBotCD/3JSz+Rb+AM=; b=BazXVx1y3PVY5mjZa5dY+ZtRNZiogleW+TlpzuFXh/qaiTDXOarFxq4tEyHV+zfqow mapfyqk8u+RpAQ418Ug2nw8N8CYvyvbW+GKudXcn7MRHLGGkYm+U8FY1xzGeZOZt6v1w ggHX23L37XGMWHeWzWJBtBIQrxnIl2nOCgO24= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690850382; x=1691455182; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W278oxGPT/K5dQ5JKjNHn0SiDujBotCD/3JSz+Rb+AM=; b=Gmi8lexFpfe3agr9eSrOjL+JDf47HaUC2KSx1Dt8ZxjMqg0/+JITtjPZh+qePDaqMj LlgYBIyjahbK4GkFo/y+c3egYprXXQ8PpiELjLF13rufTXjIDtfhmlsK6NHI6vEYEbC8 wrBXSPmCgSetm3FkirHA8W0Ffdn0ZuK/X1SPQY37s3E0QrtFPGzx7Dt3HGtel3TvSbjo cTQZnIoqHgpsA//9EwWkIVKvZIuh57JvsaGQK1yMq5MoM5YVQyDIV6LCvWnY95VIPb6r vSXKJUzbWsIsPNJOlnklNnnWkm9j5CL0Jl4UrqpOIabzGbRGs5m3Q1wr4hgRNT1uiIAW z2ZA== X-Gm-Message-State: ABy/qLa4PBKFClPMd3S/EhchQa4dlkqqwwHAQ/ejSoN5S64Z9QLk3SKZ +1t5+N/HwwRJEVXjP9fJibd03wNwGflZWJqB6GQKHw== X-Google-Smtp-Source: APBJJlG/SS8fIQUbFth5qVxiep9j+HRxtN645PHidvyQI/IuWndsUPyA5bORGFDWGlxV1FmnOs9czU3v+uCgCLK1yog= X-Received: by 2002:a05:6870:4211:b0:1b7:4521:31f with SMTP id u17-20020a056870421100b001b74521031fmr11446607oac.18.1690850382253; Mon, 31 Jul 2023 17:39:42 -0700 (PDT) MIME-Version: 1.0 References: <20230731103858.1491751-1-bruce.richardson@intel.com> <20230731165810.3086571-1-bruce.richardson@intel.com> <20230731170539.GA22098@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20230731170539.GA22098@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: Patrick Robb Date: Mon, 31 Jul 2023 20:39:31 -0400 Message-ID: Subject: Re: [PATCH v3] build: update DPDK to use C11 standard To: Tyler Retzlaff Cc: Bruce Richardson , dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , david.marchand@redhat.com, thomas@monjalon.net Content-Type: multipart/alternative; boundary="0000000000006729540601d1c836" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000006729540601d1c836 Content-Type: text/plain; charset="UTF-8" Hi Bruce, I see some failures for this series for our Ubuntu 20.04 containers. And, our DTS testbeds which are on ubuntu 20.04 are skipping running testsuites because they can't compile DPDK. So, that's why it has some missing results for a couple of the Intel NICs. For context, I'll paste below where the compile job terminates in one of our containerized compile test runs. The GCC in use here is version 9.4, so it meets the requirements as described in your patch as far as I can tell. I'll check it out more tomorrow to see whether it's an infra failure, like some missing dependencies. Please let me know if we expect to have no issues with 20.04 or if this is anticipated. Thanks! [1638/2730] Generating symbol file 'drivers/a715181@@rte_net_ixgbe@sha /librte_net_ixgbe.so.24.0.symbols'. [1639/2730] Compiling C object 'drivers/a715181@@tmp_rte_net_mlx4@sta /net_mlx4_mlx4.c.o'. FAILED: drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o ccache cc -Idrivers/a715181@@tmp_rte_net_mlx4@sta -Idrivers -I../drivers -Idrivers/net/mlx4 -I../drivers/net/mlx4 -Ilib/ethdev -I../lib/ethdev -I. -I../ -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -I/usr/include/libnl3 -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -std=c11 -Wno-strict-prototypes -D_BSD_SOURCE -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -UPEDANTIC -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.mlx4 -MD -MQ 'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o' -MF 'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o.d' -o 'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o' -c ../drivers/net/mlx4/mlx4.c In file included from ../drivers/net/mlx4/mlx4_rxtx.h:27, from ../drivers/net/mlx4/mlx4.c:49: ../drivers/net/mlx4/mlx4_prm.h:111:8: error: redefinition of 'struct mlx4_wqe_lso_seg' 111 | struct mlx4_wqe_lso_seg { | ^~~~~~~~~~~~~~~~ In file included from ../drivers/net/mlx4/mlx4_glue.h:16, from ../drivers/net/mlx4/mlx4.c:46: /usr/include/infiniband/mlx4dv.h:410:8: note: originally defined here 410 | struct mlx4_wqe_lso_seg { | ^~~~~~~~~~~~~~~~ ninja: build stopped: subcommand failed. --0000000000006729540601d1c836 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Bruce,

I see some failures for this = series for our Ubuntu 20.04 containers. And, our DTS testbeds which are on = ubuntu 20.04 are skipping running testsuites=C2=A0because they can't co= mpile DPDK. So, that's why it has some missing results for a couple of = the Intel NICs. For context, I'll paste below where the compile job ter= minates=C2=A0in one of our containerized compile test runs. The GCC in use = here is version 9.4, so it meets the requirements as described in your patc= h as far as=C2=A0I can tell. I'll check it out more tomorrow to see whe= ther it's an infra failure, like some missing dependencies. Please let = me know if we expect to have no issues with 20.04 or if this is anticipated= .=C2=A0

Thanks!

[1638/273= 0] Generating symbol file 'drivers/a715181@@rte_net_ixgbe@sha/librte_ne= t_ixgbe.so.24.0.symbols'.
[1639/2730] Compiling C object 'driver= s/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o'.
FAILED: drivers/= a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o
ccache cc -Idrivers/a71= 5181@@tmp_rte_net_mlx4@sta -Idrivers -I../drivers -Idrivers/net/mlx4 -I../d= rivers/net/mlx4 -Ilib/ethdev -I../lib/ethdev -I. -I../ -Iconfig -I../config= -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/ea= l/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/co= mmon -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvarg= s -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics -Ilib/telemetry = -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/me= mpool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter = -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci= -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -I/usr/include/libnl= 3 -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Winval= id-pch -Wextra -Werror -std=3Dc11 -O3 -include rte_config.h -Wcast-qual -Wd= eprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarat= ions -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer= -arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-addr= ess-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initializer= s -D_GNU_SOURCE -fPIC -march=3Dnative -DALLOW_EXPERIMENTAL_API -DALLOW_INTE= RNAL_API -Wno-format-truncation -std=3Dc11 -Wno-strict-prototypes -D_BSD_SO= URCE -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=3D600 -UPEDANTIC -DRTE_LOG_DEFAULT_L= OGTYPE=3Dpmd.net.mlx4 -MD -MQ 'drivers/a715181@@tmp_rte_net_mlx4@sta/ne= t_mlx4_mlx4.c.o' -MF 'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx= 4_mlx4.c.o.d' -o 'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_ml= x4.c.o' -c ../drivers/net/mlx4/mlx4.c
In file included from ../drive= rs/net/mlx4/mlx4_rxtx.h:27,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0from ../drivers/net/mlx4/mlx4.c:49:
../drivers/net/m= lx4/mlx4_prm.h:111:8: error: redefinition of 'struct mlx4_wqe_lso_seg&#= 39;
=C2=A0 111 | struct mlx4_wqe_lso_seg {
=C2=A0 =C2=A0 =C2=A0 | =C2= =A0 =C2=A0 =C2=A0 =C2=A0^~~~~~~~~~~~~~~~
In file included from ../driver= s/net/mlx4/mlx4_glue.h:16,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0from ../drivers/net/mlx4/mlx4.c:46:
/usr/include/infini= band/mlx4dv.h:410:8: note: originally defined here
=C2=A0 410 | struct m= lx4_wqe_lso_seg {
=C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A0 =C2=A0 =C2=A0^~~~= ~~~~~~~~~~~~
ninja: build stopped: subcommand failed.
--0000000000006729540601d1c836--