From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F33843CEE; Tue, 19 Mar 2024 18:30:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CCC3140ECF; Tue, 19 Mar 2024 18:30:25 +0100 (CET) Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) by mails.dpdk.org (Postfix) with ESMTP id 899F540298 for ; Tue, 19 Mar 2024 18:30:24 +0100 (CET) Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-5a1fa3cf5eeso2597275eaf.3 for ; Tue, 19 Mar 2024 10:30:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1710869424; x=1711474224; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5Tz2QpSDypbebxpOpps6EAcvV2C1TIGVChywAuYitSM=; b=iiZyv/RG9wYb1i1ZafhoPvSq29ROVUjuSMp5AMQPI8Qari7ySWEklSOa5Tam6u3UFw 2tP0RfktWF8QzZ8z8Fy9NPPSjAi6HT38MUvSWR/QncjEjiriOz1SYODmnS/wFg7Pd7r7 g1vBii/NWy6AKBkZzAInkHjglYX3kYz19YmQg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710869424; x=1711474224; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5Tz2QpSDypbebxpOpps6EAcvV2C1TIGVChywAuYitSM=; b=fjMUoJJ/IK9t3XvaroqL1d8O0xuGeI0s0gFmWg18BXWcU91TSikPmsCUoCNlwmLV8Y bwer2g0cECyEQovN1J4z91PMW8yX0e4DRh5Ha9NIAn7Oin/vD5gS60JQO5Z9PyrUauRd +ebBr+maKTbTvKisJQEd1VcTCA3x3xroWFyNH3en3Ia/gxozwyaWNS9VPsHi+ZSAInTK 3pE10vfpoUVfDDSa2NzejyKuwrnYS1sSxg3g3HDCU5wo1gn3nqEqyiJeSfTR7JC/jG75 LwKRLS81V3ybBBIepNhXP/wpSLRC3iDje6OMVWNvuCcilWqPACoQDDYCuNeRoLau3MoO hIuA== X-Forwarded-Encrypted: i=1; AJvYcCWrjYFb79j09aO76fCxZfmEAKheCosXAA8h7+OugklPv2rQzBYZ6iYuXwThXkbEQ5wsLuV5AJBDt5GJJ0U= X-Gm-Message-State: AOJu0YyYSbVtKPEq4C3orQcas/YJlvsEOR+wilM5bK+MXOEsmnnISxI+ nLzsajDCC8QsdwcTV964mm6JRHjgyD8ETW1X+orxoICdbZd0b0CU9lf5Huvlg4cufQc0GQEKxE7 YKCQraHzkm1HpeGcMWabEW6iCVTEOvqbGnURINw== X-Google-Smtp-Source: AGHT+IHLaBl04RKUevuOsKy5fIWtwkjW65xcsVcRVAgMExOgbyiF2zVtuzmOloHJU+3BzpArc7IJGvA9QzrI6xHNgNA= X-Received: by 2002:a05:6820:1623:b0:5a4:2b8d:d642 with SMTP id bb35-20020a056820162300b005a42b8dd642mr17413803oob.7.1710869423876; Tue, 19 Mar 2024 10:30:23 -0700 (PDT) MIME-Version: 1.0 References: <2640cd5b-ea3d-cd74-d5c0-eb776e880b13@loongson.cn> <0e26774c-db4d-61d3-88d9-f505be59c083@loongson.cn> In-Reply-To: <0e26774c-db4d-61d3-88d9-f505be59c083@loongson.cn> From: Patrick Robb Date: Tue, 19 Mar 2024 13:30:13 -0400 Message-ID: Subject: Re: Email based retest request process: proposal for new pull/re-apply feature To: zhoumin Cc: Adam Hassick , Aaron Conole , ci@dpdk.org, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Mar 19, 2024 at 4:37=E2=80=AFAM zhoumin wrote= : > > > One more thing I want to confirm is whether we should apply the patch > onto the branch commit which existed at the time when that patch was > submitted or onto the latest tip of branch if users request doing > rebase. Users probably request a recheck with `rebase` when the CI lab > chose a wrong branch onto which apply the patch. I worry we may > encounter conflicts when apply the patch onto the latest commit of the > target branch if that branch is just updated before the request. > > That's a good edge case to think about... but I also think if the patch no longer applies cleanly on tip of intended branch, then we would be correct to report an apply failure there. And then the submitter should refactor their patch so it applies, and submit again. So I think the process is like A) If retest is requested without rebase key, then retest "original" dpdk artifact (either by re-using the existing tarball (unh lab) or tracking the commit from submit time and re-applying onto dpdk at that commit (loongson)). B) If rebase key is included, apply to tip of the indicated branch. If, because the branch has changed, the patch no longer applies, then we can report an apply failure. Then, submitter has to refactor their patch and resubmit. In either case, report the new results with an updated test result in the email (i.e. report "_Testing PASS RETEST #1" instead of "_Testing PASS" in the email body).