[PATCH] common/mlx5: fix dependency detection on Windows

[PATCH] common/mlx5: fix dependency detection on Windows

[David Marchand]

Don't *require* mlx5dev library when testing its presence.

Fixes: 85c51a4ffab8 ("common/mlx5: get Windows dependency from standard variables")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/common/mlx5/windows/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/common/mlx5/windows/meson.build b/drivers/common/mlx5/windows/meson.build
index f60daed840..c3bd3aac26 100644
--- a/drivers/common/mlx5/windows/meson.build
+++ b/drivers/common/mlx5/windows/meson.build
@@ -7,7 +7,7 @@ if not cc.has_header('mlx5devx.h')
     subdir_done()
 endif
 
-devxlib = cc.find_library('mlx5devx', required: true)
+devxlib = cc.find_library('mlx5devx', required: false)
 if not devxlib.found()
     build = false
     reason = 'missing dependency, "mlx5devx"'
-- 
2.49.0

Re: [PATCH] common/mlx5: fix dependency detection on Windows

[David Marchand]

On Fri, Jun 13, 2025 at 10:10 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> Don't *require* mlx5dev library when testing its presence.

For the record, this was seen in a UNH env that seems to have
partially installed mlx5 dependencies.

Has header "mlx5devx.h" : YES
drivers\common\mlx5\windows\meson.build:10:0: ERROR: C shared or
static library 'mlx5devx' not found

>
> Fixes: 85c51a4ffab8 ("common/mlx5: get Windows dependency from standard variables")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand

Re: [PATCH] common/mlx5: fix dependency detection on Windows

[Patrick Robb]

[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]

Good catch David on this system having a partial install of mlx5dev
header/library.

NVIDIA guys, do any of you have a link to the current install procedure or
package? If not I can probably find whatever is correct. Thanks.

Either way we'll update devx on the Windows system Monday - thanks for your
patience.

On Fri, Jun 13, 2025 at 5:42 AM David Marchand <david.marchand@redhat.com>
wrote:

> On Fri, Jun 13, 2025 at 10:10 AM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > Don't *require* mlx5dev library when testing its presence.
>
> For the record, this was seen in a UNH env that seems to have
> partially installed mlx5 dependencies.
>
> Has header "mlx5devx.h" : YES
> drivers\common\mlx5\windows\meson.build:10:0: ERROR: C shared or
> static library 'mlx5devx' not found
>
> >
> > Fixes: 85c51a4ffab8 ("common/mlx5: get Windows dependency from standard
> variables")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
>
> --
> David Marchand
>
>

[-- Attachment #2: Type: text/html, Size: 1601 bytes --]