From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3C8145C05; Tue, 29 Oct 2024 02:29:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D82E4014F; Tue, 29 Oct 2024 02:29:46 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 4499340144 for ; Tue, 29 Oct 2024 02:29:45 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-20ca7fc4484so33461395ad.3 for ; Mon, 28 Oct 2024 18:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1730165384; x=1730770184; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BXqlfQN5gd0srQxMTXD+h1Z3p0di3kI/onHmbi+RGxQ=; b=Ux469L6ki9//g60fdGwH11E/9NJmTMgqOzxnHc+mf++skkf91XPG/Oo9gQBAFVeqQq L6rVMzSuTvOVbJD0OL/gKkJkvAIn3yRyaoxzFDQhRBDlCMwXWaptCyoLE/xWm1T0A04A MGlPg2OlNIGotEArLu2s62y9L47A3eRmoDor8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730165384; x=1730770184; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BXqlfQN5gd0srQxMTXD+h1Z3p0di3kI/onHmbi+RGxQ=; b=SklpHjitaFd6rSIp1MUJzqraerTbPSb9va2RuvCCc3N1VvQ3SlPNLgrXsih5Af3riN aoxeAjz/L6BVlTG+VDPyfwtTCOl8NakBCw5eBR6BUpatfVIgLQhYGKrsGMy+sMD+Dlj9 tfEGM4I430zDi9tN9nCfQhqaOg/EJ1qgAgXTT+iphslhPMRb+9nOm6snNytvnGc9eFxH QaoHjN+619tEXn2ua+uaqj8vYMI4GGirhAN9G3yXMCKCmITSX86Uv75anJMmFQA7oauD 5e7/uOyXNiEXGuN0zwXuDed3Z2UQNJhK/NkOJ+8xUZCAUO+8Mt169TappCwHCZf0UGlD d8uQ== X-Gm-Message-State: AOJu0Yy3ZPRY7oFCY2+c+QD1yRPZndU5DMG23quzI/ln0bw+TISVaTDb 85ZQH7cWsj3pSh5w8sXKcuzK0aZCDtPm5Cs3aGLFgNSEJvxjIHhWgLopH3GFodFoF3rma3FVNxo dhVLVqSqeYaaqRtcXSC0tk0P9auHsJz7F6oIJ/w== X-Google-Smtp-Source: AGHT+IFIUs6woctpH9ZDfYFHfQ0GsmDtF89Fw1v75U8t1sjhfXexitPgwtA4W6YSXkzHm1HijBjo/7a67wMIuG7GS94= X-Received: by 2002:a05:6a21:a247:b0:1d9:76a3:a208 with SMTP id adf61e73a8af0-1d9a8505f8cmr13098584637.47.1730165384119; Mon, 28 Oct 2024 18:29:44 -0700 (PDT) MIME-Version: 1.0 References: <20240930160204.19582-1-tomas.durovec@pantheon.tech> <20241021134935.1210500-1-luca.vizzarro@arm.com> <20241021134935.1210500-8-luca.vizzarro@arm.com> In-Reply-To: <20241021134935.1210500-8-luca.vizzarro@arm.com> From: Patrick Robb Date: Mon, 28 Oct 2024 21:28:05 -0400 Message-ID: Subject: Re: [PATCH v2 7/7] dts: remove git ref option To: Luca Vizzarro Cc: dev@dpdk.org, Paul Szczepanek , =?UTF-8?B?VG9tw6HFoSDEjnVyb3ZlYw==?= Content-Type: multipart/alternative; boundary="0000000000001fa5630625938548" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000001fa5630625938548 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Oct 21, 2024 at 9:50=E2=80=AFAM Luca Vizzarro wrote: > From: Tom=C3=A1=C5=A1 =C4=8Eurovec > > Given the whole DPDK tree directory can now be copied to the nodes, > there is no more need to use the git ref option, as the tree can be > controlled directly by the user. > > Signed-off-by: Tom=C3=A1=C5=A1 =C4=8Eurovec > Signed-off-by: Luca Vizzarro > --- > doc/guides/tools/dts.rst | 9 --- > dts/framework/settings.py | 48 ++------------- > dts/framework/utils.py | 119 +------------------------------------- > 3 files changed, 7 insertions(+), 169 deletions(-) > > diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools/dts.rst > index 7b90c4856e..a00d987ece 100644 > --- a/doc/guides/tools/dts.rst > +++ b/doc/guides/tools/dts.rst > @@ -237,9 +237,6 @@ DTS is run with ``main.py`` located in the ``dts`` > directory after entering Poet > -t SECONDS, --timeout SECONDS > [DTS_TIMEOUT] The default timeout for all DTS > operations except for compiling DPDK. (default: 15) > -v, --verbose [DTS_VERBOSE] Specify to enable verbose > output, logging all messages to the console. (default: False) > - --revision ID, --rev ID, --git-ref ID > - [DTS_DPDK_REVISION_ID] Git revision ID to > test. Could be commit, tag, tree ID etc. To test local changes, first > - commit them, then use their commit ID. > (default: None) > --compile-timeout SECONDS > [DTS_COMPILE_TIMEOUT] The timeout for > compiling DPDK. (default: 1200) > --test-suite TEST_SUITE [TEST_CASES ...] > @@ -275,12 +272,6 @@ The minimum DTS needs is a config file and a > pre-built DPDK or DPDK > sources location which can be specified in said config file or on the > command line or environment variables. > > -Example command for running DTS with the template configuration and DPDK > tag v23.11: > - > -.. code-block:: console > - > - (dts-py3.10) $ ./main.py --git-ref v23.11 > - > I see this needs to go because of the --git-ref usage. Can this be replaced with a new example command? Perhaps even 2, one for each of --tarball and --dpdk-tree? Reviewed-by: Patrick Robb --0000000000001fa5630625938548 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Oct 21, 2024 at 9:50=E2=80=AF= AM Luca Vizzarro <luca.vizzarro= @arm.com> wrote:
From: Tom=C3=A1=C5=A1 =C4=8Eurovec <tomas.durovec@pantheon.tech&= gt;

Given the whole DPDK tree directory can now be copied to the nodes,
there is no more need to use the git ref option, as the tree can be
controlled directly by the user.

Signed-off-by: Tom=C3=A1=C5=A1 =C4=8Eurovec <tomas.durovec@pantheon.tech= >
Signed-off-by: Luca Vizzarro <luca.vizzarro@arm.com>
---
=C2=A0doc/guides/tools/dts.rst=C2=A0 |=C2=A0 =C2=A09 ---
=C2=A0dts/framework/settings.py |=C2=A0 48 ++-------------
=C2=A0dts/framework/utils.py=C2=A0 =C2=A0 | 119 +--------------------------= -----------
=C2=A03 files changed, 7 insertions(+), 169 deletions(-)

diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools/dts.rst
index 7b90c4856e..a00d987ece 100644
--- a/doc/guides/tools/dts.rst
+++ b/doc/guides/tools/dts.rst
@@ -237,9 +237,6 @@ DTS is run with ``main.py`` located in the ``dts`` dire= ctory after entering Poet
=C2=A0 =C2=A0 -t SECONDS, --timeout SECONDS
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 [DTS_TIMEOUT] The default timeout for all DTS oper= ations except for compiling DPDK. (default: 15)
=C2=A0 =C2=A0 -v, --verbose=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0[DTS_VE= RBOSE] Specify to enable verbose output, logging all messages to the consol= e. (default: False)
-=C2=A0 =C2=A0--revision ID, --rev ID, --git-ref ID
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0[DTS_DPDK_REVISION_ID] Git revision ID to test. Cou= ld be commit, tag, tree ID etc. To test local changes, first
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0commit them, then use their commit ID. (default: No= ne)
=C2=A0 =C2=A0 --compile-timeout SECONDS
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 [DTS_COMPILE_TIMEOUT] The timeout for compiling DP= DK. (default: 1200)
=C2=A0 =C2=A0 --test-suite TEST_SUITE [TEST_CASES ...]
@@ -275,12 +272,6 @@ The minimum DTS needs is a config file and a pre-built= DPDK or DPDK
=C2=A0sources location which can be specified in said config file or on the=
=C2=A0command line or environment variables.

-Example command for running DTS with the template configuration and DPDK t= ag v23.11:
-
-.. code-block:: console
-
-=C2=A0 =C2=A0(dts-py3.10) $ ./main.py --git-ref v23.11
-

I see this needs to go because of the= --git-ref usage. Can this be replaced with a new example command? Perhaps = even 2, one for each of --tarball and --dpdk-tree?


Reviewed-by: Patrick Robb <probb@iol.unh.edu>
--0000000000001fa5630625938548--