From: Patrick Robb <probb@iol.unh.edu>
To: Luca Vizzarro <Luca.Vizzarro@arm.com>
Cc: Dean Marx <dmarx@iol.unh.edu>,
yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com,
paul.szczepanek@arm.com, dev@dpdk.org
Subject: Re: [PATCH v2] dts: fix devbind initialization bug
Date: Tue, 17 Jun 2025 20:21:38 -0400 [thread overview]
Message-ID: <CAJvnSUDO4JHNKpAkskoDcQAWnszBDPo7XTN3dBZH5w1OYJFy_w@mail.gmail.com> (raw)
In-Reply-To: <8b266009-ff64-4052-aadc-9364159f8702@arm.com>
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
On Tue, Jun 17, 2025 at 11:18 AM Luca Vizzarro <Luca.Vizzarro@arm.com>
wrote:
> Looks good to me. just a small nit:
>
> On 16/06/2025 19:38, Dean Marx wrote:
> > + test_run.ctx.topology.setup()
> > + self.test_run.ctx.topology.configure_ports("sut", "dpdk")
>
> no need to do `self.` here. Outside of this:
>
Good catch Luca. Thanks.
Applied to next-dts with the git edit per luca's comment.
>
> Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>
>
[-- Attachment #2: Type: text/html, Size: 1122 bytes --]
prev parent reply other threads:[~2025-06-18 0:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 20:12 [PATCH v1] " Dean Marx
2025-06-16 3:21 ` Patrick Robb
2025-06-16 18:35 ` [PATCH v2] " Dean Marx
2025-06-16 18:38 ` Dean Marx
2025-06-17 0:17 ` Patrick Robb
2025-06-17 0:51 ` Patrick Robb
2025-06-17 15:18 ` Luca Vizzarro
2025-06-18 0:21 ` Patrick Robb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJvnSUDO4JHNKpAkskoDcQAWnszBDPo7XTN3dBZH5w1OYJFy_w@mail.gmail.com \
--to=probb@iol.unh.edu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Luca.Vizzarro@arm.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).