From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1A34143B5A;
	Wed, 21 Feb 2024 04:34:51 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 97C13402B9;
	Wed, 21 Feb 2024 04:34:50 +0100 (CET)
Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com
 [209.85.161.41]) by mails.dpdk.org (Postfix) with ESMTP id 1E07F4014F
 for <dev@dpdk.org>; Wed, 21 Feb 2024 04:34:50 +0100 (CET)
Received: by mail-oo1-f41.google.com with SMTP id
 006d021491bc7-59a1a03d09aso50545eaf.3
 for <dev@dpdk.org>; Tue, 20 Feb 2024 19:34:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=iol.unh.edu; s=unh-iol; t=1708486489; x=1709091289; darn=dpdk.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=YLw3FVii9DOl55K/953zJwUUHniZpRgqD0P8KrGNQck=;
 b=YA5LaqB5+lUSAOXKNBbrgzukTqZwTwL7YOaQT1OULwNWEvpyXuSD6O11Az5sxupiLA
 pb+HpH8VJhQ7uRCtTePBUM+Bk8+zSS7luyeji0MxUO5tVRZaOYcP+6+ClRUrKgSh+sLB
 GCrXJLRp5ndptgRgt9/KO7xb4RiS8mC0p0s2A=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1708486489; x=1709091289;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=YLw3FVii9DOl55K/953zJwUUHniZpRgqD0P8KrGNQck=;
 b=OzeBnAD0+s8bpVrgSiIfOTCP71wQ/ksMWjuM1DcT+pSyPCrMyahbafppyKG6n+ua9+
 31Kg0VfDxQ+mYmNIwmFZ4tHj/YRcdW/MRHB01NjMaoiDcz7ZwYyrmlLxAQS011s6MAPa
 WqSyCnTvR/m7UX0ctXrD8JxsqY7V29Pk3WRYdYoSmcpNxhw1856TAb3FDITYl7vpVb75
 2/h3oUS4P9CsFPhmWdfFPpf+7oe1O1butzrH/LWt71le5Hl7+9Gk+Ab+j0ird+QgUhC5
 5dMR+ifM0DfSToilP62VulD0oJA3g8NEHKhQFHH4lmrXav2zk8Ue1K7htBhdR/rvvLtn
 FWOw==
X-Forwarded-Encrypted: i=1;
 AJvYcCVB09ICz64xXCyUYM/os3Yb3sjHH/WwOA+D9511IU6jFKv2C/FzdNN8MSDaNp3SSq62emN7Bod9mpu6eUg=
X-Gm-Message-State: AOJu0Yw5DpN+yFYNLGNPCn+yfU7EkbvGeey/2ofmE7kPVStaSoO9eH2A
 Qdz3sgva6ykTKyj915ArELJU5Ih774A2kzWhOzlOvO6SQX7Djp6Z6yQVCthDdgi8IQnhYCALgLJ
 8wFaDul5P1RXEp3j4bMlBY+dW3YrzLm4l/drhAQ==
X-Google-Smtp-Source: AGHT+IG76VZ+7yXgImxKwXkavFs2ZkN/fcH2bvJs4eR2Z1w4bIDntqObBbB0dNZl/t2w0NatghJ3DlsjjqKVUE7zUvI=
X-Received: by 2002:a4a:d2ce:0:b0:5a0:2a9:574b with SMTP id
 j14-20020a4ad2ce000000b005a002a9574bmr3705814oos.9.1708486489283; Tue, 20 Feb
 2024 19:34:49 -0800 (PST)
MIME-Version: 1.0
References: <20240109153633.766-1-jspewock@iol.unh.edu>
 <20240110144249.20719-1-jspewock@iol.unh.edu>
In-Reply-To: <20240110144249.20719-1-jspewock@iol.unh.edu>
From: Patrick Robb <probb@iol.unh.edu>
Date: Tue, 20 Feb 2024 22:34:38 -0500
Message-ID: <CAJvnSUDY=aO0RwQsiqkV7EH3ena2tXuFjCf7R93J5oOp8fVFSQ@mail.gmail.com>
Subject: Re: [PATCH v8 0/7] dts: Port scatter suite over
To: jspewock@iol.unh.edu
Cc: Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech, 
 thomas@monjalon.net, wathsala.vithanage@arm.com, paul.szczepanek@arm.com, 
 yoan.picchi@foss.arm.com, lylavoie@iol.unh.edu, ferruh.yigit@amd.com, 
 andrew.rybchenko@oktetlabs.ru, dev@dpdk.org
Content-Type: multipart/alternative; boundary="0000000000004c37b90611dc0275"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

--0000000000004c37b90611dc0275
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Tested-by: Patrick Robb <probb@iol.unh.edu>

I ran this testsuite with a bnxt_en NIC at the Community Lab.

I also spoke with Jeremy about the state of this patch today. He wants to
add a second testcase to the suite for testing the scattered packets
hardware offload (--enable-scatter flag in testpmd). But, he still has
questions about querying ethdev for capabilities and writing the testcase
around that, so that testcase cannot be submitted for this release. It will
come in as a separate patch.

So, from what I can tell Juraj has completed his review and this is the
final v of this patchseries.

On Wed, Jan 10, 2024 at 9:43=E2=80=AFAM <jspewock@iol.unh.edu> wrote:

> From: Jeremy Spewock <jspewock@iol.unh.edu>
>
> v8:
>
> Address comments by making minor docstring adjustments.
>
> Jeremy Spewock (7):
>   dts: add startup verification and forwarding modes to testpmd shell
>   dts: limit EAL parameters to DPDK apps and add parameters to all apps
>   dts: add optional packet filtering to scapy sniffer
>   dts: add pci addresses to EAL parameters
>   dts: allow configuring MTU of ports
>   dts: add scatter to the yaml schema
>   dts: add pmd_buffer_scatter test suite
>
>  dts/framework/config/conf_yaml_schema.json    |   3 +-
>  dts/framework/exception.py                    |   7 +
>  dts/framework/remote_session/testpmd_shell.py | 149 +++++++++++++++++-
>  dts/framework/test_suite.py                   |  15 +-
>  dts/framework/testbed_model/linux_session.py  |   8 +
>  dts/framework/testbed_model/os_session.py     |   9 ++
>  dts/framework/testbed_model/sut_node.py       |  28 +++-
>  dts/framework/testbed_model/tg_node.py        |  14 +-
>  .../traffic_generator/__init__.py             |   7 +-
>  .../capturing_traffic_generator.py            |  22 ++-
>  .../testbed_model/traffic_generator/scapy.py  |  27 ++++
>  dts/tests/TestSuite_pmd_buffer_scatter.py     | 132 ++++++++++++++++
>  12 files changed, 407 insertions(+), 14 deletions(-)
>  create mode 100644 dts/tests/TestSuite_pmd_buffer_scatter.py
>
> --
> 2.43.0
>
>

--0000000000004c37b90611dc0275
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Tested-by: Patrick Robb &lt;<a href=3D"mailto:probb@i=
ol.unh.edu">probb@iol.unh.edu</a>&gt;</div><div><br></div><div>I ran this t=
estsuite with a bnxt_en NIC at the Community Lab.</div><div><br></div><div>=
I also spoke with Jeremy about the state of this patch today. He wants to a=
dd a second testcase to the suite for testing the scattered packets hardwar=
e offload (--enable-scatter flag in testpmd). But, he still has questions a=
bout querying ethdev for capabilities and writing the testcase around that,=
 so that testcase cannot be submitted for this release. It will come in as =
a separate patch.=C2=A0</div><div><br></div><div>So, from what I can tell J=
uraj has completed his review and this is the final v of this patchseries.<=
/div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">O=
n Wed, Jan 10, 2024 at 9:43=E2=80=AFAM &lt;<a href=3D"mailto:jspewock@iol.u=
nh.edu">jspewock@iol.unh.edu</a>&gt; wrote:<br></div><blockquote class=3D"g=
mail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204=
,204,204);padding-left:1ex">From: Jeremy Spewock &lt;<a href=3D"mailto:jspe=
wock@iol.unh.edu" target=3D"_blank">jspewock@iol.unh.edu</a>&gt;<br>
<br>
v8:<br>
<br>
Address comments by making minor docstring adjustments.<br>
<br>
Jeremy Spewock (7):<br>
=C2=A0 dts: add startup verification and forwarding modes to testpmd shell<=
br>
=C2=A0 dts: limit EAL parameters to DPDK apps and add parameters to all app=
s<br>
=C2=A0 dts: add optional packet filtering to scapy sniffer<br>
=C2=A0 dts: add pci addresses to EAL parameters<br>
=C2=A0 dts: allow configuring MTU of ports<br>
=C2=A0 dts: add scatter to the yaml schema<br>
=C2=A0 dts: add pmd_buffer_scatter test suite<br>
<br>
=C2=A0dts/framework/config/conf_yaml_schema.json=C2=A0 =C2=A0 |=C2=A0 =C2=
=A03 +-<br>
=C2=A0dts/framework/exception.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A07 +<br>
=C2=A0dts/framework/remote_session/testpmd_shell.py | 149 +++++++++++++++++=
-<br>
=C2=A0dts/framework/test_suite.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 15 +-<br>
=C2=A0dts/framework/testbed_model/linux_session.py=C2=A0 |=C2=A0 =C2=A08 +<=
br>
=C2=A0dts/framework/testbed_model/os_session.py=C2=A0 =C2=A0 =C2=A0|=C2=A0 =
=C2=A09 ++<br>
=C2=A0dts/framework/testbed_model/sut_node.py=C2=A0 =C2=A0 =C2=A0 =C2=A0|=
=C2=A0 28 +++-<br>
=C2=A0dts/framework/testbed_model/tg_node.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=
=C2=A0 14 +-<br>
=C2=A0.../traffic_generator/__init__.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0|=C2=A0 =C2=A07 +-<br>
=C2=A0.../capturing_traffic_generator.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 |=C2=A0 22 ++-<br>
=C2=A0.../testbed_model/traffic_generator/scapy.py=C2=A0 |=C2=A0 27 ++++<br=
>
=C2=A0dts/tests/TestSuite_pmd_buffer_scatter.py=C2=A0 =C2=A0 =C2=A0| 132 ++=
++++++++++++++<br>
=C2=A012 files changed, 407 insertions(+), 14 deletions(-)<br>
=C2=A0create mode 100644 dts/tests/TestSuite_pmd_buffer_scatter.py<br>
<br>
-- <br>
2.43.0<br>
<br>
</blockquote></div><div><br></div></div>

--0000000000004c37b90611dc0275--