From: Patrick Robb <probb@iol.unh.edu>
To: Dean Marx <dmarx@iol.unh.edu>
Cc: luca.vizzarro@arm.com, yoan.picchi@foss.arm.com,
Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com,
dev@dpdk.org
Subject: Re: [PATCH v2] dts: fix devbind initialization bug
Date: Mon, 16 Jun 2025 20:51:43 -0400 [thread overview]
Message-ID: <CAJvnSUDbyN8ng820X=TXAXusWwewZXr_j4p==vPxp1Fj3ZHi8g@mail.gmail.com> (raw)
In-Reply-To: <CAJvnSUC_=euqk5aYGgLTu=CsDgmT2Bgrd=vcX4XG4oLmvG_YZQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 804 bytes --]
Thanks, looks good and I gave it a testrun on some XL710.
I'm going to include the Slack summary of the bugs for clarity on the v2:
Bugs:
1. topology setup is called before DPDKRuntimeEnvironment setup, but
DPDKRuntimeEnvironment setup is required for topology setup, so the
ordering needs to be reversed, which is done in Dean's V1 patch.
2. The capability check in TestRunSetup requires that the SUT be bound to
the DPDK driver, but this cannot work (except on mellanox NICs) because the
SUT NIC is bound to the kernel driver just before, for the topology setup,
and not touched again before the capability check.
Reviewed-by: Patrick Robb <probb@iol.unh.edu>
On Mon, Jun 16, 2025 at 8:17 PM Patrick Robb <probb@iol.unh.edu> wrote:
> Recheck-request: iol-intel-Functional
>
[-- Attachment #2: Type: text/html, Size: 1257 bytes --]
prev parent reply other threads:[~2025-06-17 0:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 20:12 [PATCH v1] " Dean Marx
2025-06-16 3:21 ` Patrick Robb
2025-06-16 18:35 ` [PATCH v2] " Dean Marx
2025-06-16 18:38 ` Dean Marx
2025-06-17 0:17 ` Patrick Robb
2025-06-17 0:51 ` Patrick Robb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJvnSUDbyN8ng820X=TXAXusWwewZXr_j4p==vPxp1Fj3ZHi8g@mail.gmail.com' \
--to=probb@iol.unh.edu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=luca.vizzarro@arm.com \
--cc=paul.szczepanek@arm.com \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).