Re: [PATCH v2] dts: add SUT cleanup to framework

[Patrick Robb <probb@iol.unh.edu>]

[-- Attachment #1: Type: text/plain, Size: 2073 bytes --]

On Thu, Jan 30, 2025 at 5:13 PM Dean Marx <dmarx@iol.unh.edu> wrote:

> Add method cleanup_sut to framework that removes a
> DPDK source from a SUT node at the conclusion of a testrun.
> This will only run when the DPDK source is being copied
> from the DTS engine node during the testrun
> (when remote=false in the conf.yaml).
>
> Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
> ---
>  dts/framework/runner.py                 |  2 +-
>  dts/framework/testbed_model/sut_node.py | 21 ++++++++++++++++++---
>  2 files changed, 19 insertions(+), 4 deletions(-)
>
> diff --git a/dts/framework/runner.py b/dts/framework/runner.py
> index 9f9789cf49..367034e038 100644
> --- a/dts/framework/runner.py
> +++ b/dts/framework/runner.py
> @@ -336,7 +336,7 @@ def _run_test_run(
>          finally:
>              try:
>                  self._logger.set_stage(DtsStage.test_run_teardown)
> -                sut_node.tear_down_test_run()
> +
> sut_node.tear_down_test_run(test_run_config.dpdk_config.dpdk_location)
>                  tg_node.tear_down_test_run()
>                  test_run_result.update_teardown(Result.PASS)
>              except Exception as e:
> diff --git a/dts/framework/testbed_model/sut_node.py
> b/dts/framework/testbed_model/sut_node.py
> index 483733cede..c73500b146 100644
> --- a/dts/framework/testbed_model/sut_node.py
> +++ b/dts/framework/testbed_model/sut_node.py
> @@ -188,6 +188,19 @@ def path_to_devbind_script(self) -> PurePath | str:
>              )
>          return self._path_to_devbind_script
>
> +    def cleanup_sut(self, dpdk_build_location, remote_tree: str |
> PurePath | None) -> None:
>

I think you have a missing type hint here for the dpdk_build_location arg.
I think it is a LocalDPDKLocation.


> --
> 2.48.1
>
>
While you're at it, you can edit the commit message to replace the
reference to conf.yaml (no longer named this) to the new name or just
"configuration."

Thanks and sorry I missed this on the first look through! Can merge this
asap once you make the edits.

[-- Attachment #2: Type: text/html, Size: 2867 bytes --]