I see a spurious dpdk-test fail for this, on per_lcore_autotest, it remotely launches an lcore which is running though it should not be able to. I threw the relevant blurbs below - I will bring this to Bugzilla since obviously your patch is unrelated.
We can do a retest if you want - otherwise I think you are safe to ignore this fail.
78/119 DPDK:fast-tests / per_lcore_autotest FAIL 1.14s (exit status 255 or signal 127 SIGinvalid)
16:49:56 DPDK_TEST=per_lcore_autotest MALLOC_PERTURB_=178 /root/workspace/Generic-Unit-Test-DPDK/dpdk/build/app/dpdk-test --no-huge -m 2048
----------------------------------- output -----------------------------------
stdout:
RTE>>per_lcore_autotest
on socket 0, on core 1, variable is 1
wait 100ms on lcore 1
It does remote launch successfully but it should not at this time
Test Failed
RTE>>wait 100ms on lcore 1
stderr:
EAL: Detected CPU lcores: 16
EAL: Detected NUMA nodes: 2
EAL: Detected static linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'VA'
EAL: VFIO support initialized
APP: HPET is not enabled, using TSC as default timer
------------------------------------------------------------------------------
The test:
```
test_per_lcore(void)
{
unsigned lcore_id;
int ret;
rte_eal_mp_remote_launch(assign_vars, NULL, SKIP_MAIN);
RTE_LCORE_FOREACH_WORKER(lcore_id) {
if (rte_eal_wait_lcore(lcore_id) < 0)
return -1;
}
rte_eal_mp_remote_launch(display_vars, NULL, SKIP_MAIN);
RTE_LCORE_FOREACH_WORKER(lcore_id) {
if (rte_eal_wait_lcore(lcore_id) < 0)
return -1;
}
/* test if it could do remote launch twice at the same time or not */
ret = rte_eal_mp_remote_launch(test_per_lcore_delay, NULL, SKIP_MAIN);
if (ret < 0) {
printf("It fails to do remote launch but it should able to do\n");
return -1;
}
/* it should not be able to launch a lcore which is running */
ret = rte_eal_mp_remote_launch(test_per_lcore_delay, NULL, SKIP_MAIN);
if (ret == 0) {
printf("It does remote launch successfully but it should not at this time\n");
return -1;
}
RTE_LCORE_FOREACH_WORKER(lcore_id) {
if (rte_eal_wait_lcore(lcore_id) < 0)
return -1;
}
return 0;
}
```