From: Patrick Robb <probb@iol.unh.edu>
To: Thomas Wilks <thomas.wilks@arm.com>
Cc: dev@dpdk.org, Paul Szczepanek <paul.szczepanek@arm.com>,
Luca Vizzarro <luca.vizzarro@arm.com>
Subject: Re: [PATCH 1/2] dts: change test suite name property
Date: Thu, 3 Jul 2025 21:54:02 -0400 [thread overview]
Message-ID: <CAJvnSUDwxW6hkWk+xmKpEW+XtAfAJ5DGw3iwG2sCK+7unBzaHA@mail.gmail.com> (raw)
In-Reply-To: <20250627151241.335114-2-thomas.wilks@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]
Reviewed-by: Patrick Robb <probb@iol.unh.edu>
On Fri, Jun 27, 2025 at 11:12 AM Thomas Wilks <thomas.wilks@arm.com> wrote:
> From: Luca Vizzarro <luca.vizzarro@arm.com>
>
> The test suite name property was previously returning the class name
> instead of the way that test suite are actually named, e.g.
> TestHelloWorld instead of hello_world.
>
> This change rectifies this inconsistency.
>
> Signed-off-by: Luca Vizzarro <luca.vizzarro@arm.com>
> ---
> dts/framework/test_suite.py | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py
> index 145b79496f..d4e06a567a 100644
> --- a/dts/framework/test_suite.py
> +++ b/dts/framework/test_suite.py
> @@ -110,8 +110,11 @@ def __init__(self, config: BaseConfig):
>
> @property
> def name(self) -> str:
> - """The name of the test suite class."""
> - return type(self).__name__
> + """The name of the test suite."""
> + module_prefix = (
> +
> f"{TestSuiteSpec.TEST_SUITES_PACKAGE_NAME}.{TestSuiteSpec.TEST_SUITE_MODULE_PREFIX}"
> + )
> + return type(self).__module__[len(module_prefix) :]
>
> @property
> def topology(self) -> Topology:
> --
> 2.43.0
>
>
[-- Attachment #2: Type: text/html, Size: 1967 bytes --]
next prev parent reply other threads:[~2025-07-04 1:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 15:12 [PATCH 0/2] dts: rework test results Thomas Wilks
2025-06-27 15:12 ` [PATCH 1/2] dts: change test suite name property Thomas Wilks
2025-07-01 14:19 ` Dean Marx
2025-07-04 1:54 ` Patrick Robb [this message]
2025-06-27 15:12 ` [PATCH 2/2] dts: rework test results Thomas Wilks
2025-07-01 14:18 ` Dean Marx
2025-07-04 2:01 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJvnSUDwxW6hkWk+xmKpEW+XtAfAJ5DGw3iwG2sCK+7unBzaHA@mail.gmail.com \
--to=probb@iol.unh.edu \
--cc=dev@dpdk.org \
--cc=luca.vizzarro@arm.com \
--cc=paul.szczepanek@arm.com \
--cc=thomas.wilks@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).