From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 8943E2A58 for ; Mon, 6 Jul 2015 19:55:42 +0200 (CEST) Received: by wiclp1 with SMTP id lp1so28572894wic.0 for ; Mon, 06 Jul 2015 10:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=zHa21Y567OmadCHydT+4vMv33au5nuSpxPwFyP+C1Kw=; b=nt+GztPYuxAxoynQ7PhHYWRWGdq94g1BYvcIsio0wA1seBWm3Lof6hNVcHWj2q8ESb XrcEp2Kv1pCzbt9SWLDRiyob7xpxgS2IEcUeb+i6tsbOUt9bkkvztVUyXh2zOJ+s/Fox UDiaqPlOI2RJfEbYUN70FvN/Pc1f3cpgRHQv2Kiwtt3Bm7wZ+dx1jr3THZ235u45dGa5 jEHjjI0GhrLgBZw/+6TSS989MfcpTmFgZJ7sYsA8kTCvN4fkF9zgymRWFW3D/LFZn+qK wTSNoqqqr4S+nILCXDu9Gdxy5m9QNMlsWnRLGnQO0ruB9F8d+ZR6skKyifqTktNrUUNh YgCw== MIME-Version: 1.0 X-Received: by 10.194.77.97 with SMTP id r1mr190003wjw.98.1436205342415; Mon, 06 Jul 2015 10:55:42 -0700 (PDT) Received: by 10.194.36.99 with HTTP; Mon, 6 Jul 2015 10:55:42 -0700 (PDT) In-Reply-To: <3087134.yXks7R84Dd@xps13> References: <1436189297-7780-1-git-send-email-dlrmsghd@gmail.com> <3865893.mD3C20oiXL@xps13> <3087134.yXks7R84Dd@xps13> Date: Tue, 7 Jul 2015 02:55:42 +0900 Message-ID: From: Keunhong Lee To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/2] Native uio-based PMD for Mellanox ConnectX-3 devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jul 2015 17:55:42 -0000 We found that optimizing fragmentation configuration of mlx4 driver performs as fast as native PMD. I think we have to re-consider using native driver rather than ib driver. Keunhong. 2015-07-07 1:14 GMT+09:00 Thomas Monjalon : > 2015-07-07 00:57, Keunhong Lee: > > Answer 1. UIO based driver is faster then ib based driver. > > It can saturate 40G link with MTU sized packets using a single thread > while > > ib wrapper cannot. > > OK, interesting. Do you have numbers and details about your > testbed/scenario? > > > Answer 2. Sorry, I missed that. I'll make a new patch email with my real > > name. > > > > Question 1. Is it OK if I separate GPL-based and BSD-based codes into > > separated patches? > > mlx4 kernel driver itself is dual licenses, so I think they are > considered > > as BSD in my source code. > > The only source code under GPL is bitmap, integer logarithm, and > red-black > > tree contained in mlnx_uio/kernel directory. > > These parts will be built in the user-space driver library, right? > It would change the license, which is not desirable. > > Technically, your approach may be interesting. > But from a maintenance point of view, this huge codebase may be a > nightmare. > > > > 2015-07-06 23:17 GMT+09:00 Thomas Monjalon : > > > > > 2015-07-06 22:28, leeopop: > > > > This is a native UIO-based PMD for Mellanox ConnectX-3 devices. > > > > It uses a persistent memory library in order to provide a persistent > > > > scartch area for the mlx4 HCA driver. > > > > > > What is the benefit of this UIO approach compared to the OFED based > driver? > > > > > > > We release the driver itself under BSD license, but to use it for > > > > commercial products, you may have to re-implement the separated GPL > > > > sources. > > > > > > The GPL sources are not really separated. > > > The DPDK libraries must be BSD-licensed. > > > > > > > The GPL affected source codes reside in the mlnx_uio/kernel > directory. > > > > > > It seems that a large part of the GPL driver was also copied in > > > mlnx_uio/mlnx/. > > > > > > Given that you are dropping a huge GPL codebase (whose you don't own > the > > > copyright) in a BSD library, and that you didn't give your real name in > > > the signed-off line, it is NACK. > > > >