From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yk0-f178.google.com (mail-yk0-f178.google.com [209.85.160.178]) by dpdk.org (Postfix) with ESMTP id CFED67EC4 for ; Fri, 7 Nov 2014 02:16:44 +0100 (CET) Received: by mail-yk0-f178.google.com with SMTP id 79so1157226ykr.37 for ; Thu, 06 Nov 2014 17:26:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=G5zCU6IIvfGi+MW+jUj8/MJvijmBFBvj+9j+WlgvjMk=; b=VtcctZ9jCz9O8CwkuOHDez48UWvdj4r61QPc/Z7y85ZJ2n/sS8Ifi9ByzeppEbi5/C Nh6efz0E5l4AQ4Soa7m6Si9UUksKszHj7VvNz0jJEb19WPNh7dnHw+eELYsv/1UgFfcn SFt5HHfhfJejRqINwd8ii/eGDU37ORqZwBVZ7cEzOLJH15zoPb489sN13rxPI5MTV5Be QE3U6kvmN6/oNGhMF/6qyidoMPf98Qh1TKfj4SbolcRmSIAjmHAD/OWUV488eUvjkZv+ 7Z/aw7PaCZTPgbL+pBaeE/ffwaX1pbl0GWIcvePTiv4hlT5kIL3te170WepNQ19ft1+X hERA== MIME-Version: 1.0 X-Received: by 10.170.58.2 with SMTP id a2mr8961867yka.78.1415323574217; Thu, 06 Nov 2014 17:26:14 -0800 (PST) Received: by 10.170.225.136 with HTTP; Thu, 6 Nov 2014 17:26:14 -0800 (PST) In-Reply-To: <1808251.0PKkz7l9rY@xps13> References: <1808251.0PKkz7l9rY@xps13> Date: Fri, 7 Nov 2014 10:26:14 +0900 Message-ID: From: Keunhong Lee To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] Bugs in newest patches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Nov 2014 01:16:45 -0000 I did not included the generic header directly. I thought that this nested "extern C" is intended, however, according to your reply, this might be removed at all. There is a remaining """ #ifdef _cplusplus } #endif """ at the end of "generic/rte_cycles.h". I think this should be removed. This causes compile error on C++. Keunhong. 2014-11-07 6:05 GMT+09:00 Thomas Monjalon : > Hi, > > 2014-11-07 05:21, Keunhong Lee: > > I just pulled new patches from the master branch, and found that it > doesn't > > work with C++. > > > > in lib/librte_eal/common/include/generic/rte_cycles.h > > +#ifdef __cplusplus > > +extern "C" { > > +#endif > > It's already included in > lib/librte_eal/common/include/arch/x86/rte_cycles.h > which includes lib/librte_eal/common/include/generic/rte_cycles.h. > > You shouldn't include the generic header directly. > > -- > Thomas >