Re: [PATCH v6 2/2] net/bnxt: code refactor for supporting speed lanes

[Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 2487 bytes --]

On Fri, Oct 4, 2024 at 6:56 AM David Marchand <david.marchand@redhat.com> wrote:
>
> Hello,
>
> On Thu, Sep 26, 2024 at 11:56 PM Damodharam Ammepalli
> <damodharam.ammepalli@broadcom.com> wrote:
> > @@ -1331,16 +1376,17 @@ static int bnxt_dev_configure_op(struct rte_eth_dev *eth_dev)
> >  void bnxt_print_link_info(struct rte_eth_dev *eth_dev)
> >  {
> >         struct rte_eth_link *link = &eth_dev->data->dev_link;
> > +       struct bnxt *bp = eth_dev->data->dev_private;
> >
> >         if (link->link_status)
> > -               PMD_DRV_LOG(DEBUG, "Port %d Link Up - speed %u Mbps - %s\n",
> > -                       eth_dev->data->port_id,
> > -                       (uint32_t)link->link_speed,
> > -                       (link->link_duplex == RTE_ETH_LINK_FULL_DUPLEX) ?
> > -                       ("full-duplex") : ("half-duplex\n"));
> > +               PMD_DRV_LOG(DEBUG, "Port %d Link Up - speed %u Mbps - %s Lanes - %d\n",
> > +                           eth_dev->data->port_id,
> > +                           (uint32_t)link->link_speed,
> > +                           (link->link_duplex == RTE_ETH_LINK_FULL_DUPLEX) ?
> > +                           ("full-duplex") : ("half-duplex\n"),
>
> A \n slipped in with the "half-duplex" string.
> Please send a fix against next-net.
>
>
Ack

> > +                           (uint16_t)bp->link_info->active_lanes);
> >         else
> > -               PMD_DRV_LOG(INFO, "Port %d Link Down\n",
> > -                       eth_dev->data->port_id);
> > +               PMD_DRV_LOG(INFO, "Port %d Link Down\n", eth_dev->data->port_id);
> >  }
> >
> >  /*
>
>
> --
> David Marchand
>

-- 
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5457 bytes --]