Re: [RFC 0/2] Add support for link speed lanes

[Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 2491 bytes --]

 From: Ferruh Yigit <ferruh.yigit@amd.com>
Date: Wednesday, May 22, 2024 at 2:00 PM
To: Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>, Ajit Khaparde
<ajit.khaparde@broadcom.com>
Cc: dev@dpdk.org <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
huangdengdui <huangdengdui@huawei.com>, lihuisong (C) <lihuisong@huawei.com>,
stephen@networkplumber.org <stephen@networkplumber.org>,
fengchengwen@huawei.com <fengchengwen@huawei.com>, haijie1@huawei.com <
haijie1@huawei.com>
Subject: Re: [RFC 0/2] Add support for link speed lanes

On 3/22/2024 10:25 PM, Damodharam Ammepalli wrote:
> BRCM576xx NIC modules support speeds with different lanes configuration.
> This is an alternate proposal to
>
https://www.google.com/url?q=https://patchwork.dpdk.org/project/dpdk/list/?series%3D31593&source=gmail-imap&ust=1717016402000000&usg=AOvVaw1jrFok7jqKY0zhtLzKKg1Z
>
> Please provide your review. Broadcom driver patches will follow.
>
> Damodharam Ammepalli (2):
>   lib/ethdev: Add link_speed lanes support into rte lib
>   testpmd: Add speed lanes to testpmd config and show command
>

Hi Damodharam,

As discussed in other thread, having dedicated APIs for setting lane
makes API more clear, so we can continue with this design.

This RFC proposes two APIs, but agreement on other thread was around
three new APIs.

Copy/pasting Thomas's suggestion
"
 There are 3 needs:
        - set PHY lane config
        - get PHY lane config
        - get PHY lane capabilities
"

And "get PHY lane capabilities" should return capability per speed,
similar to FEC one.


Can you please update this RFC to have three APIs as mentioned above?

Thanks,
Ferruh

Noted Ferruh. Will update this RFC as commented.

-- 
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.

[-- Attachment #2: Type: text/html, Size: 4661 bytes --]