From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D28F3440FA; Tue, 28 May 2024 23:19:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73004402DE; Tue, 28 May 2024 23:19:31 +0200 (CEST) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by mails.dpdk.org (Postfix) with ESMTP id 9ED474025D for ; Tue, 28 May 2024 23:19:29 +0200 (CEST) Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-52449b7aa2bso1641921e87.3 for ; Tue, 28 May 2024 14:19:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1716931169; x=1717535969; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Xd9ErjFpMyEyYihme9BpM0YT8R1PRFFp43JPHyToZ48=; b=eRmZ0ikUVnCMT8yV7T38Xo0fAzjaIaWiXltBRylYH1VhLQpnVekUxuqxgEgdhbjrpZ 1j7bpVOKzJyYVy3u7yDI4Nna4CpyCq/pugBKWcX6SwV8cw/V0HkGrVz8MJQPZHQiEExo lh50wXjoonqpR9qZ+5R10OCwB0vtZ2g1YnQ3U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716931169; x=1717535969; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Xd9ErjFpMyEyYihme9BpM0YT8R1PRFFp43JPHyToZ48=; b=dKkQNse1PoUwZG5OJOYv1gGjfbozhfbHcszOe0VWLbdFBGdZMmDyweFNUUfKYZCo4Q bJpk2rMPg9/PRR7Cx/UANip72rn3EXzP+JPHrYkyzrlejAlw+BBhIHYzd0y9LMG5lrv1 tL8tVBqWHS9RfY94NZtc7yjsLxo2aNgLoh/iOtEmb5tSEToXxeVDDJ8E6hRC67MW5pns KjjM3VGyH8IxigV6UUcKI+xwbX8WU1GjPTVuzjpJZ18U2ul41Aja1+BIniQKACZ2hpMw UZTz1YwD9jqnHNqTvlPPvVw5R/mlrJQfTkFBxonUYUMGA3Ow9iHofACa5oJTB1ZfS9ym Q1Qw== X-Gm-Message-State: AOJu0Yxx2VJc/j2BC9ky3SeRwjLy5lLMiYWjBFDXNwKhC4t/j5NjZ7xG KyZDha+abZ3UGskbJF6byjDiAb3RbljhcOJsvdh52BiUh4tgJDKX9RzcEO8yIh+toUqX7MgneTj TmCwi0St8kK/cW2PdyOX/628TqhdwcGvIKUoyLKzQS6egqIMF6/hRxaRiOhFwAOdeT4IiHflcge Ar9D9Y X-Google-Smtp-Source: AGHT+IGDe0Olq4Vp+T7l8WN8tDBmb54eEiybDeb56nxQDu8ecyS1c3rHJvpLQvjav6McPXHt4ztW2pf+w5w563Juj2U= X-Received: by 2002:ac2:5319:0:b0:529:b69e:4310 with SMTP id 2adb3069b0e04-529b69e449amr2739726e87.23.1716931168631; Tue, 28 May 2024 14:19:28 -0700 (PDT) MIME-Version: 1.0 References: <20240322222543.23548-1-damodharam.ammepalli@broadcom.com> In-Reply-To: From: Damodharam Ammepalli Date: Tue, 28 May 2024 14:19:17 -0700 Message-ID: Subject: Re: [RFC 0/2] Add support for link speed lanes To: Ferruh Yigit , Ajit Khaparde Cc: "dev@dpdk.org" , Thomas Monjalon , huangdengdui , "lihuisong (C)" , "stephen@networkplumber.org" , "fengchengwen@huawei.com" , "haijie1@huawei.com" Content-Type: multipart/alternative; boundary="0000000000006925de06198a3054" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000006925de06198a3054 Content-Type: text/plain; charset="UTF-8" From: Ferruh Yigit Date: Wednesday, May 22, 2024 at 2:00 PM To: Damodharam Ammepalli , Ajit Khaparde Cc: dev@dpdk.org , Thomas Monjalon , huangdengdui , lihuisong (C) , stephen@networkplumber.org , fengchengwen@huawei.com , haijie1@huawei.com < haijie1@huawei.com> Subject: Re: [RFC 0/2] Add support for link speed lanes On 3/22/2024 10:25 PM, Damodharam Ammepalli wrote: > BRCM576xx NIC modules support speeds with different lanes configuration. > This is an alternate proposal to > https://www.google.com/url?q=https://patchwork.dpdk.org/project/dpdk/list/?series%3D31593&source=gmail-imap&ust=1717016402000000&usg=AOvVaw1jrFok7jqKY0zhtLzKKg1Z > > Please provide your review. Broadcom driver patches will follow. > > Damodharam Ammepalli (2): > lib/ethdev: Add link_speed lanes support into rte lib > testpmd: Add speed lanes to testpmd config and show command > Hi Damodharam, As discussed in other thread, having dedicated APIs for setting lane makes API more clear, so we can continue with this design. This RFC proposes two APIs, but agreement on other thread was around three new APIs. Copy/pasting Thomas's suggestion " There are 3 needs: - set PHY lane config - get PHY lane config - get PHY lane capabilities " And "get PHY lane capabilities" should return capability per speed, similar to FEC one. Can you please update this RFC to have three APIs as mentioned above? Thanks, Ferruh Noted Ferruh. Will update this RFC as commented. -- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it. --0000000000006925de06198a3054 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
From: Ferruh Yigit <ferruh.yigit@amd.com><= br> Date: Wednesday, May 22, 2024 at 2:= 00 PM
To: Damodharam Ammepalli <damodharam= .ammepalli@broadcom.com>, Ajit Khaparde <ajit.khaparde@broadcom.com><= br> Cc: dev@dpdk.org <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, huangde= ngdui <huan= gdengdui@huawei.com>, lihuisong (C) <lihuisong@huawei.com>, stephen@networkplumber.org= <st= ephen@networkplumber.org>, fengchengwen@huawei.com <fengcheng= wen@huawei.com>, haijie1@huawei.com <haijie1@huawei.com>
Subject: Re: [RFC 0/2] Add support = for link speed lanes

On 3/22/2024 10:25 PM, Damodharam Ammepalli wrote:
> BRCM576xx NIC modules support speeds with different lanes configuratio= n.
> This is an alternate proposal to
> https://www.google.com/url?q=3Dhttps://patchwork.dpdk.org/project/dpdk/list= /?series%3D31593&source=3Dgmail-imap&ust=3D1717016402000000&usg= =3DAOvVaw1jrFok7jqKY0zhtLzKKg1Z
>
> Please provide your review. Broadcom driver patches will follow.
>
> Damodharam Ammepalli (2):
>=C2=A0=C2=A0 lib/ethdev: Add link_speed lanes support into rte lib
>=C2=A0=C2=A0 testpmd: Add speed lanes to testpmd config and show comman= d
>

Hi Damodharam,

As discussed in other thread, having dedicated APIs for setting lane
makes API more clear, so we can continue with this design.

This RFC proposes two APIs, but agreement on other thread was around
three new APIs.

Copy/pasting Thomas's suggestion
"
=C2=A0There are 3 needs:
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - set PHY lane config
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - get PHY lane config
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - get PHY lane capabilities
"

And "get PHY lane capabilities" should return capability per spee= d,
similar to FEC one.


Can you please update this RFC to have three APIs as mentioned above?

Thanks,
Ferruh

Noted Ferruh. Will update this RFC as comme= nted.


This ele= ctronic communication and the information and any files transmitted with it= , or attached to it, are confidential and are intended solely for the use o= f the individual or entity to whom it is addressed and may contain informat= ion that is confidential, legally privileged, protected by privacy laws, or= otherwise restricted from disclosure to anyone else. If you are not the in= tended recipient or the person responsible for delivering the e-mail to the= intended recipient, you are hereby notified that any use, copying, distrib= uting, dissemination, forwarding, printing, or copying of this e-mail is st= rictly prohibited. If you received this e-mail in error, please return the = e-mail to the sender, delete it from your computer, and destroy any printed= copy of it. --0000000000006925de06198a3054--