From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f171.google.com (mail-ig0-f171.google.com [209.85.213.171]) by dpdk.org (Postfix) with ESMTP id D869D5691 for ; Thu, 26 Feb 2015 10:06:13 +0100 (CET) Received: by mail-ig0-f171.google.com with SMTP id h15so42638884igd.4 for ; Thu, 26 Feb 2015 01:06:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=aE7lNfaH/Jmj40ts80d+oZcLPsc5DRbzbrrRpyaLFac=; b=C3YndUT5uDhNEja0Us17L8NI/M+mbO6z28gPngD8imD6UFlKi6bSLAsoPPmPOdFoYP qZjrBRbAQhRLoCZbulkI6rkCPCe+AcVU4TjIeWheYch+1NMcZ+5ZtAP5q1MV/KCdeU0J f9wCFUEfzQARqW13pdfup61siOpCNSgqXlw/ReyFqU8mWakZhaYyXz2x7lfPIUUx1ql9 bqQDLZQv21z5kfltYMieP7PbohvJpphDYcxjXEdFYkLXNp7jpRtVIbZ80MEjLBryNaU5 wrwhkiEgjWSGEix/Hdt8YGa2dyqkMp0fLEDsNVAr9WDEqjQvkGQFYoXsBLS3c0Z3SFep IUNA== X-Gm-Message-State: ALoCoQnES9fPMqNX3zIjaZh6hj0M6FX9m9F3aPYPF36nFQwymB/A9aeFMn+CDJ+XmTXCpi2zoIdG MIME-Version: 1.0 X-Received: by 10.42.138.199 with SMTP id d7mr8479242icu.3.1424941573148; Thu, 26 Feb 2015 01:06:13 -0800 (PST) Received: by 10.64.15.5 with HTTP; Thu, 26 Feb 2015 01:06:12 -0800 (PST) In-Reply-To: <3153139.jQ5sXg5pox@xps13> References: <1424414516-18609-1-git-send-email-mukawa@igel.co.jp> <1665241.NKrJfZ0zyg@xps13> <20150225164902.70f8abd6@urahara> <3153139.jQ5sXg5pox@xps13> Date: Thu, 26 Feb 2015 18:06:12 +0900 Message-ID: From: Tetsuya Mukawa To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v11 2/2] librte_pmd_null: Support port hotplug function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2015 09:06:14 -0000 2015-02-26 16:03 GMT+09:00 Thomas Monjalon : > 2015-02-25 16:49, Stephen Hemminger: >> Build fails if HOTPLUG is disabled Hi Stephen, I appreciate for you reporting. > > OK thanks for reporting. > Actually there is no good reason to disable hotplug on Linux. > Though it means that it's impossible to build on FreeBSD. > > Tetsuya, the right fix is to remove this option. Hi Thomas, Yes, I agree with it. I will add some codes to remove the option. Please let me have a few days, I need to prepare BSD machine for compile test. > You should manage to graceful degrades hotplug in not supported > cases supported: devices cannot be detachable in case of VFIO or nic_uio. > What about uio_pci_generic? We cannot detach a vfio device so far. But we can detach a igb_uio and uio_pci_generic device. About a vfio ddevice, I haven't checked related code yet, but I guess I will submit code to detach a vfio device in post-rc1. Thanks, Tetsuya