From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-la0-f50.google.com (mail-la0-f50.google.com [209.85.215.50]) by dpdk.org (Postfix) with ESMTP id A46BD9AD8 for ; Fri, 10 Jul 2015 13:35:46 +0200 (CEST) Received: by lagc2 with SMTP id c2so260630728lag.3 for ; Fri, 10 Jul 2015 04:35:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=k9E80J5QvfCoe8Z7kDDMWtr6ywuJSqyuagq17RVhNGs=; b=Sb8DYSknTHBZRZ8wuo8UhUdZgqPovqQHPmeF6SMQlHrWcf1kZ+q0pouV7rKPivnYlC tEdvQ+czhgj3OJ2yjmK/edYmz7O7ASO/rXRRLqKct6VM5ZswWPLmA6JG1DOXScY+Oxhr eFrEygF9hJG0N6bxmmZEs8VWM8IX9GYTP/62q3d+5O9cxwu6Y//bWIpVAKBJPN+HEUm1 RpdM9QEkkbf0jcV+pxc83ajhIsTodGL6Iio0LCDveWdtyAy+BgPIqrv/G6n9+nGL3/kV joQ5BNgSdVP9sH4fmcQR7cvgkjCkIL2buJxigzr/G+heFk78EBkfPUoem6+y/dPoaJvw HNKQ== X-Gm-Message-State: ALoCoQnDb0bf+JtC7ZfI9lAekKj43853XO2Bt4XcCxoSBNpfjbJsD+4vCy0eewypZfF6DNsoozEE MIME-Version: 1.0 X-Received: by 10.152.29.97 with SMTP id j1mr13608987lah.104.1436528146270; Fri, 10 Jul 2015 04:35:46 -0700 (PDT) Received: by 10.112.161.233 with HTTP; Fri, 10 Jul 2015 04:35:46 -0700 (PDT) In-Reply-To: References: <1436514439-4893-1-git-send-email-michael.qiu@intel.com> <559F83AE.4050409@igel.co.jp> Date: Fri, 10 Jul 2015 20:35:46 +0900 Message-ID: From: Tetsuya Mukawa To: David Marchand Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] BugFix: VFIO never works X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2015 11:35:47 -0000 2015-07-10 20:25 GMT+09:00 David Marchand : > On Fri, Jul 10, 2015 at 10:34 AM, Tetsuya Mukawa wrote: >> >> On 2015/07/10 16:47, Michael Qiu wrote: >> > Commit 35b3313e322b ("pci: merge mapping functions for linux and bsd") >> > >> > introduced a bug that all vfio will be >> > blocked. >> > >> > Root cause is that VFIO_PRESENT is unaccessable in eal >> > common level. >> > >> > This patch is to fix this. >> > >> > Signed-off-by: Michael Qiu >> > --- >> > lib/librte_eal/common/eal_common_pci.c | 2 -- >> > lib/librte_eal/common/eal_private.h | 3 +++ >> > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 10 ++++++++++ >> > 3 files changed, 13 insertions(+), 2 deletions(-) >> > >> > diff --git a/lib/librte_eal/common/eal_common_pci.c >> > b/lib/librte_eal/common/eal_common_pci.c >> > index 3805aed..f3dc697 100644 >> > --- a/lib/librte_eal/common/eal_common_pci.c >> > +++ b/lib/librte_eal/common/eal_common_pci.c >> > @@ -146,10 +146,8 @@ pci_map_device(struct rte_pci_device *dev) >> > /* try mapping the NIC resources using VFIO if it exists */ >> > switch (dev->kdrv) { >> > case RTE_KDRV_VFIO: >> > -#ifdef VFIO_PRESENT >> > if (pci_vfio_is_enabled()) >> > ret = pci_vfio_map_resource(dev); >> > -#endif > > > This is a common file, vfio is not available on BSD. > I missed that during review. > > Did you test build on BSD ? > > > -- > David Marchand Hi David, Yes I did. Before submitting the patch series, I've tested it with igb_uio on Linux and with nic_uio on BSD. Both were OK. But I didn't test it with vfio and pci_uio generic on Linux. After receiving the patch, I tested both. So now all cases should be ok. Tetsuya