From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f178.google.com (mail-ie0-f178.google.com [209.85.223.178]) by dpdk.org (Postfix) with ESMTP id 7901211C5 for ; Wed, 4 Mar 2015 04:37:07 +0100 (CET) Received: by iebtr6 with SMTP id tr6so64098956ieb.7 for ; Tue, 03 Mar 2015 19:37:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Pv5lsGtGeiF2Yj3D7PmHGm9e80+5rnMWxuWLgjb94k4=; b=dffvjSsYBUhP8su0bIuDlTi4czg60T05D6GxX1O5YWsFdZcLghYGJQpBhFfGwC42YP BaW2bdHYPNC0JsxLcqNX0+INcE4z0GGpaIbapHqq+6qdzM6HopUdQ++14jj+bifoGQrU gdnmxBBhf6ufzG4eTsytU/Qv9fCysUJJSdO0PQvwjEHg/cQTm9r5GO8mHxaqFoquY4so PL2euQVLmpGSCNV3O0Y8a4Nro83IU+cLGXMoDgLfF0TzC3AAQ3PFktqffmOkrg3FzGo2 Qevim0eYdeL7lyFhuQqFQEp9fe3K2o1CQEJZUkS/8io4Cg7C3c9/PQrfBmFyoBIfP0YD Rq+A== X-Gm-Message-State: ALoCoQk8XsQIWUyiAzd53yAcwsz2QuUMKgyyUgWtMJz9uzmu7BAdkNuXHBlxCfM4HT+uySUDKYJV MIME-Version: 1.0 X-Received: by 10.50.79.161 with SMTP id k1mr7514800igx.14.1425440226811; Tue, 03 Mar 2015 19:37:06 -0800 (PST) Received: by 10.64.15.5 with HTTP; Tue, 3 Mar 2015 19:37:06 -0800 (PST) In-Reply-To: <2176123.7naUroNpz4@xps13> References: <1424414516-18609-1-git-send-email-mukawa@igel.co.jp> <3153139.jQ5sXg5pox@xps13> <2176123.7naUroNpz4@xps13> Date: Wed, 4 Mar 2015 12:37:06 +0900 Message-ID: From: Tetsuya Mukawa To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v11 2/2] librte_pmd_null: Support port hotplug function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2015 03:37:07 -0000 2015-02-26 19:57 GMT+09:00 Thomas Monjalon : > 2015-02-26 18:06, Tetsuya Mukawa: >> 2015-02-26 16:03 GMT+09:00 Thomas Monjalon : >> > 2015-02-25 16:49, Stephen Hemminger: >> >> Build fails if HOTPLUG is disabled >> >> Hi Stephen, >> >> I appreciate for you reporting. >> >> > >> > OK thanks for reporting. >> > Actually there is no good reason to disable hotplug on Linux. >> > Though it means that it's impossible to build on FreeBSD. >> > >> > Tetsuya, the right fix is to remove this option. >> >> Hi Thomas, >> >> Yes, I agree with it. I will add some codes to remove the option. >> Please let me have a few days, I need to prepare BSD machine for compile test. >> >> > You should manage to graceful degrades hotplug in not supported >> > cases supported: devices cannot be detachable in case of VFIO or nic_uio. >> > What about uio_pci_generic? >> >> We cannot detach a vfio device so far. But we can detach a igb_uio and >> uio_pci_generic device. >> About a vfio ddevice, I haven't checked related code yet, but I guess >> I will submit code to detach a vfio device in post-rc1. > > OK thanks. > I made a quick fix (moving #ifdef) waiting the option removal: > http://dpdk.org/browse/dpdk/commit/?id=7609e6609350 > Hi Thomas, I submit the patches to remove HOTPLUG config macro. Thanks, Tetsuya