From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f170.google.com (mail-lb0-f170.google.com [209.85.217.170]) by dpdk.org (Postfix) with ESMTP id 8017B5A84 for ; Wed, 14 Oct 2015 10:02:43 +0200 (CEST) Received: by lbwr8 with SMTP id r8so40144791lbw.2 for ; Wed, 14 Oct 2015 01:02:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=b2Tx0IpUmncXWsjMOFuNxhnmY20x52X4yXyBMOlAxjQ=; b=q7bsHU3brQE707LHE+Wcdtz8oVsT0VfMnIEokhboESCNMvKJ4AGZTJN5dJPo9gGw4T Yh6UBydHBTRKuufVgu4wtb1SPvKpJNEke38ROYmIhvN4RzrJ/EHpRrAfx0joLm+1fiOK aaoc61tbYkmUL03fkOLdRW4InGY8N/aZgHhIzBspZ/Tkfo0gz7kNrEZyqjCyMmz5IpnD wcW6/SblMLBNxY8KHnkwEKIenLcjsa/W5Uc2w2q1KpoH+LXCHl6UIskXGeFmUk61mGDz nGKXqaOcNRBLZYxQxiuDIij65vwtMa2giqEbJJS0Co5HcEJO+zy04pLeIjRPt8sA+vlF bjng== MIME-Version: 1.0 X-Received: by 10.112.180.198 with SMTP id dq6mr828885lbc.90.1444809763213; Wed, 14 Oct 2015 01:02:43 -0700 (PDT) Received: by 10.25.62.213 with HTTP; Wed, 14 Oct 2015 01:02:43 -0700 (PDT) In-Reply-To: <561D05A4.2060708@6wind.com> References: <1443542682-7088-1-git-send-email-francesco.montorsi@gmail.com> <561D05A4.2060708@6wind.com> Date: Wed, 14 Oct 2015 10:02:43 +0200 Message-ID: From: Francesco To: Olivier MATZ Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] Add error message when trying to use make option T= during build/clean X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2015 08:02:43 -0000 Hi Olivier, thanks for reviewing the patch. However for me it is logical that T= option is used for "config" target and then for building/cleaning only O= is used. However it is not logical for me that install target requires T= option instead of O= option... or perhaps I'm missing something? Thanks, Francesco 2015-10-13 15:22 GMT+02:00 Olivier MATZ : > Hi Francesco, > > On 09/29/2015 06:04 PM, Francesco Montorsi wrote: > > From: Francesco Montorsi > > > > --- > > mk/rte.sdkbuild.mk | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk > > index 38ec7bd..013aa89 100644 > > --- a/mk/rte.sdkbuild.mk > > +++ b/mk/rte.sdkbuild.mk > > @@ -29,6 +29,12 @@ > > # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE > USE > > # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > > > +ifdef T > > + ifeq ("$(origin T)", "command line") > > + $(error "Cannot use T= with a build/clean target") > > + endif > > +endif > > + > > # If DESTDIR variable is given, install binary dpdk > > I tested this patch but it breaks the "make install" command: > > $ make install T=x86_64-native-linuxapp-gcc > make[5]: Nothing to be done for 'depdirs'. > Configuration done > rte.sdkbuild.mk:34: *** "Cannot use T= with a build/clean target". > > As the T= argument is given as a command line variable, it is > propagated to the "$(MAKE) all" in rte.sdkinstall.mk. > So I think it's better to keep the current code as is, except if > you have a better idea. > > Regards, > Olivier >