From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DEA1D440BB; Fri, 24 May 2024 20:13:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 74B384067C; Fri, 24 May 2024 20:13:13 +0200 (CEST) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by mails.dpdk.org (Postfix) with ESMTP id 888D240271 for ; Fri, 24 May 2024 20:13:12 +0200 (CEST) Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2e726a507beso2150861fa.2 for ; Fri, 24 May 2024 11:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1716574392; x=1717179192; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BAIzjhSwhrGuEQSs1lLVRzp76h6tGEi03m0q4quH1gg=; b=VFuNhOQZ/1p8Pnp9TR6vGEnqynwx0OIcrJS3u9fzaVWspQfBYYufh/2410iLwB0DMT 769XRwxWonjTeVQV1+kkezgni2vsz7BIIpQfdcsULIHQvECoRt3Y4N5SbP6+3cYpo6+/ OPlxj9+SzI8l7dgRu0Xm5ZjVYsRidZkZLS2gs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716574392; x=1717179192; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BAIzjhSwhrGuEQSs1lLVRzp76h6tGEi03m0q4quH1gg=; b=IaB+TbrFZEO32dAzHD2LAqNL6RSWRwEVuks8Ly5Wxl3xSfRe+WNrzxCf8KGQv5qcn0 o3YumnDl/vWQoDossQ15VDlrt8he0AwJTmiW6SDBlZ9QnozqUCHsuO6/JqAv3T511ulm dxoEWX9u1JaTba3r8NvavHaC8ObYrcFl/Us77xKweJPWxxx7a8/IuJqrpoXLtZhbg0O1 G8kGHFLqWYMiXl2QFrhtxd+E3MgUtb/nsQWlgQVkZtog09sfTtAHyxpZs3YszGVUD48s 4Q7TVrtBGMijgfJVPzlnzaAyxtQ8Ty47MtCRt+knmCP/GWpz0JeK34PbwDcZ75LgXZeC q0fg== X-Gm-Message-State: AOJu0YydMVE1Na4NT5Od/DveCYMzC0KvBk632rYHSBMQT12NCVhnvZHu j/3+9Okx8v+mnxFT3xQqwkSY449bNNJ6e6zWJsKxZ+MyiPh7bPbuU1XOSe6Lmm4zZDJvB8VcnlI lq/DBTqjo2tEh8NlYXvuicPcK4O16jeAdEt0fbg== X-Google-Smtp-Source: AGHT+IGSxr/PW9N6XQR9vsQb1VQwYvbXAbs6lbr+dletX5vSzI0rV+j0mwHjrJkYb1oSD1+VPm46sTWs5b9Y+tXPmrU= X-Received: by 2002:a05:651c:d2:b0:2e6:fc23:f45 with SMTP id 38308e7fff4ca-2e95b34c2c3mr15477121fa.5.1716574391939; Fri, 24 May 2024 11:13:11 -0700 (PDT) MIME-Version: 1.0 References: <20240524180616.18210-1-npratte@iol.unh.edu> In-Reply-To: <20240524180616.18210-1-npratte@iol.unh.edu> From: Nicholas Pratte Date: Fri, 24 May 2024 14:13:00 -0400 Message-ID: Subject: Re: [RFC PATCH 0/1] Initial Implementation For Jumbo Frames To: paul.szczepanek@arm.com, jspewock@iol.unh.edu, luca.vizzarro@arm.com, thomas@monjalon.net, juraj.linkes@pantheon.tech, bruce.richardson@intel.com, Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu, yoan.picchi@foss.arm.com Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This is being superseded, ignore this submission. Thanks. On Fri, May 24, 2024 at 2:07=E2=80=AFPM Nicholas Pratte wrote: > > The following is a rough design for the implementation of the jumbo > frames test suite in new DTS. The test suite uses the same > testing methodology from the test suite implementation in old > DTS. In doing so, much of the logic in this implementation has been > stripped away for the sake of maintaining an OS-agnostic design > philosopgy. Thus, there are some concerns here that need further > discussion. > > All test cases behave accordingly on lab hardware. However, issues with > the testpmd shell, all of which will be fixed with the upcoming context > manager, prevent the test suite from functioning properly if all test > cases are run sequentially. Thus, for testing, each test case needs to > be run individually. So, expect issues if attempting to test. > > Old DTS implements some basic logic that detects 1GB NICs, specifically > when testing jumbo frame packets greater than the specified MTU length. > This is because, according to a commit message from 2016, 1GB NICs will > automatically adjust their size to +4 bytes, meaning that when setting > an MTU of 9000, testpmd adjust the MTU size to 9004. To compensate, some > logic was inserted in the old suite to adjust packet sizes accordingly. > Given that Juraj's capabilities patch is in development, it would be > possible to set a restriction on this test suite to remove the support > of 1GB NICs, which could be determined from testpmd outputs; it could > also be possible that this problem is entirely null and void today, > essentially allowing us to forget about it. > > The current implementation is not developed with both the capabilities > patch and the params patch in mind; however, the current design can and > will be refactored to do so. > > Nicholas Pratte (1): > Initial Implementation For Jumbo Frames Test Suite > > dts/framework/config/conf_yaml_schema.json | 3 +- > dts/framework/test_suite.py | 8 + > dts/tests/TestSuite_jumboframes.py | 210 +++++++++++++++++++++ > 3 files changed, 220 insertions(+), 1 deletion(-) > create mode 100644 dts/tests/TestSuite_jumboframes.py > > -- > 2.44.0 >