From: Nicholas Pratte <npratte@iol.unh.edu>
To: Dean Marx <dmarx@iol.unh.edu>
Cc: probb@iol.unh.edu, jspewock@iol.unh.edu, luca.vizzarro@arm.com,
yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com,
paul.szczepanek@arm.com, juraj.linkes@pantheon.tech,
dev@dpdk.org
Subject: Re: [PATCH v1] dts: add package mode config and updated README
Date: Mon, 12 Aug 2024 14:55:05 -0400 [thread overview]
Message-ID: <CAKXZ7egDRqkgp43U2Zr0XmkfGdBd-6rO33YKpc2RQ3YwYPq2Kw@mail.gmail.com> (raw)
In-Reply-To: <20240812163538.29904-1-dmarx@iol.unh.edu>
Reviewed-by: Nicholas Pratte <npratte@iol.unh.edu>
On Mon, Aug 12, 2024 at 12:35 PM Dean Marx <dmarx@iol.unh.edu> wrote:
>
> In the current DTS setup description, the user installs poetry
> with the --no-root option. However, adding 'package-mode = false'
> to the pyproject.toml sets the same configuration, and running
> poetry install --no-root will become an error in a future
> poetry version.
>
> Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
> ---
> dts/README.md | 4 ++--
> dts/pyproject.toml | 1 +
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/dts/README.md b/dts/README.md
> index ee3fa1c968..2b3a7f89c5 100644
> --- a/dts/README.md
> +++ b/dts/README.md
> @@ -37,7 +37,7 @@ to allow you to connect to hosts without specifying a password.
> ```shell
> docker build --target dev -t dpdk-dts .
> docker run -v $(pwd)/..:/dpdk -v /home/dtsuser/.ssh:/root/.ssh:ro -it dpdk-dts bash
> -$ poetry install --no-root
> +$ poetry install
> $ poetry shell
> ```
>
> @@ -46,7 +46,7 @@ $ poetry shell
> ```shell
> docker build --target dev -t dpdk-dts .
> docker run -v $(pwd)/..:/dpdk -it dpdk-dts bash
> -$ poetry install --no-root
> +$ poetry install
> $ poetry shell
> ```
>
> diff --git a/dts/pyproject.toml b/dts/pyproject.toml
> index 0b9b09805a..712af2f01d 100644
> --- a/dts/pyproject.toml
> +++ b/dts/pyproject.toml
> @@ -3,6 +3,7 @@
> # Copyright(c) 2023 PANTHEON.tech s.r.o.
>
> [tool.poetry]
> +package-mode = false
> name = "dts"
> version = "0.1.0"
> description = "DPDK Test Suite."
> --
> 2.44.0
>
next prev parent reply other threads:[~2024-08-12 18:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 16:35 Dean Marx
2024-08-12 18:55 ` Nicholas Pratte [this message]
2024-09-11 15:33 ` Luca Vizzarro
2024-09-16 10:10 ` Juraj Linkeš
2024-09-18 20:19 ` [PATCH v2] dts: add package mode config and updated docs Dean Marx
2024-09-19 9:27 ` Juraj Linkeš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKXZ7egDRqkgp43U2Zr0XmkfGdBd-6rO33YKpc2RQ3YwYPq2Kw@mail.gmail.com \
--to=npratte@iol.unh.edu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=jspewock@iol.unh.edu \
--cc=juraj.linkes@pantheon.tech \
--cc=luca.vizzarro@arm.com \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).