DPDK patches and discussions
 help / color / mirror / Atom feed
From: Nicholas Pratte <npratte@iol.unh.edu>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
Cc: probb@iol.unh.edu, dmarx@iol.unh.edu, jspewock@iol.unh.edu,
	 luca.vizzarro@arm.com, yoan.picchi@foss.arm.com,
	Honnappa.Nagarahalli@arm.com,  paul.szczepanek@arm.com,
	dev@dpdk.org
Subject: Re: [PATCH v2 1/6] dts: Remove build target config and list of devices
Date: Thu, 12 Sep 2024 16:31:37 -0400	[thread overview]
Message-ID: <CAKXZ7egT91Z8_=dO_OTkVrt+-fT6aNSnc11yO3vJgZYKkiPgEA@mail.gmail.com> (raw)
In-Reply-To: <e11ebb57-ad49-4d8a-aa59-1ddf4826a9d2@pantheon.tech>

On Tue, Sep 10, 2024 at 7:30 AM Juraj Linkeš <juraj.linkes@pantheon.tech> wrote:
>
> The subject line should be all lowercase (except for abbreviations and
> maybe some other exceptions).

Ack.

>
> On 5. 7. 2024 19:13, Nicholas Pratte wrote:
> > Remove the list of devices from the schema, as these are unuesed.
>
> Typo: unused
Thanks for pointing this out!

>
> > Likewise, removed build-target information since these is not currently
> > used, and it is unlikely to be used in the future. Adjustments to the
> > dts.rst are made to reflect these changes.
>
> > diff --git a/dts/framework/config/__init__.py b/dts/framework/config/__init__.py
>
> > @@ -341,28 +325,20 @@ class BuildTargetConfiguration:
> >       The configuration used for building DPDK.
> >
> >       Attributes:
> > -        arch: The target architecture to build for.
> > -        os: The target os to build for.
> > -        cpu: The target CPU to build for.
> >           compiler: The compiler executable to use.
> >           compiler_wrapper: This string will be put in front of the compiler when
> >               executing the build. Useful for adding wrapper commands, such as ``ccache``.
> >           name: The name of the compiler.
> >       """
> >
> > -    arch: Architecture
> > -    os: OS
> > -    cpu: CPUType
> >       compiler: Compiler
> >       compiler_wrapper: str
> > -    name: str
> >
> >       @classmethod
> >       def from_dict(cls, d: BuildTargetConfigDict) -> Self:
> >           r"""A convenience method that processes the inputs before creating an instance.
> >
> > -        `arch`, `os`, `cpu` and `compiler` are converted to :class:`Enum`\s and
> > -        `name` is constructed from `arch`, `os`, `cpu` and `compiler`.
> > +        `compiler` is converted to :class:`Enum`\s
> >
> >           Args:
> >               d: The configuration dictionary.
> > @@ -371,12 +347,8 @@ def from_dict(cls, d: BuildTargetConfigDict) -> Self:
> >               The build target configuration instance.
> >           """
> >           return cls(
> > -            arch=Architecture(d["arch"]),
> > -            os=OS(d["os"]),
> > -            cpu=CPUType(d["cpu"]),
> >               compiler=Compiler(d["compiler"]),
> >               compiler_wrapper=d.get("compiler_wrapper", ""),
> > -            name=f"{d['arch']}-{d['os']}-{d['cpu']}-{d['compiler']}",
>
> I think we can still keep this, we can just remove arch, os and cpu
> (there could be multiple build target, each with different compiler
> (gcc, clang, etc.)). If there's a reason to remove this, it should be
> mentioned in the commit message.

I can do that. If I had a justification for removing this way back
when I wrote this, it wasn't strong enough for me to remember. I don't
mind leaving this in.

>
> >           )
> >
> >
> > diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json
> > index f02a310bb5..3f7bc2acae 100644
> > --- a/dts/framework/config/conf_yaml_schema.json
> > +++ b/dts/framework/config/conf_yaml_schema.json
> > @@ -6,76 +6,6 @@
>
> >       "ARCH": {
> >         "type": "string",
> >         "enum": [
> > @@ -124,12 +54,6 @@
> >               "other"
> >             ]
> >           },
> > -        "os": {
> > -          "$ref": "#/definitions/OS"
> > -        },
> > -        "cpu": {
> > -          "$ref": "#/definitions/cpu"
> > -        },
>
> Should we also remove arch that's above these two?

Must have missed that! There's no reason for that to be there now that
it's being removed.

>
>
> > diff --git a/dts/framework/runner.py b/dts/framework/runner.py
> > index 6b6f6a05f5..2a1019899a 100644
> > --- a/dts/framework/runner.py
> > +++ b/dts/framework/runner.py
> > @@ -480,7 +480,7 @@ def _run_build_target(
> >               test_suites_with_cases: The test suites with test cases to run.
> >           """
> >           self._logger.set_stage(DtsStage.build_target_setup)
> > -        self._logger.info(f"Running build target '{build_target_config.name}'.")
> > +        self._logger.info("Running build target.")
>
> If we keep build_target_config.name this should be reverted.

Ack.
>
> >
> >           try:
> >               sut_node.set_up_build_target(build_target_config)
>
> > diff --git a/dts/framework/testbed_model/sut_node.py b/dts/framework/testbed_model/sut_node.py
> > index 2855fe0276..a4511157b7 100644
> > --- a/dts/framework/testbed_model/sut_node.py
> > +++ b/dts/framework/testbed_model/sut_node.py
> > @@ -115,12 +115,7 @@ def remote_dpdk_build_dir(self) -> PurePath:
> >           This is the directory where DPDK was built.
> >           We assume it was built in a subdirectory of the extracted tarball.
> >           """
> > -        if self._build_target_config:
> > -            return self.main_session.join_remote_path(
> > -                self._remote_dpdk_dir, self._build_target_config.name
> > -            )
> > -        else:
> > -            return self.main_session.join_remote_path(self._remote_dpdk_dir, "build")
> > +        return self.main_session.join_remote_path(self._remote_dpdk_dir, "build")
> >
>
> Same here, revert if we keep build_target_config.name.

Ack.

  reply	other threads:[~2024-09-12 20:31 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-13 20:18 [PATCH 0/4] dts: Remove Excess Attributes From User Config Nicholas Pratte
2024-06-13 20:18 ` [PATCH 1/4] dts: Remove build target config and list of devices Nicholas Pratte
2024-06-14 18:07   ` Jeremy Spewock
2024-06-13 20:18 ` [PATCH 2/4] dts: Use First Core Logic Change Nicholas Pratte
2024-06-14 18:09   ` Jeremy Spewock
2024-06-20 13:41     ` Nicholas Pratte
2024-06-13 20:18 ` [PATCH 3/4] dts: Self-Discovering Architecture Change Nicholas Pratte
2024-06-14 18:09   ` Jeremy Spewock
2024-06-13 20:18 ` [PATCH 4/4] dts: Rework DPDK Attributes In SUT Node Config Nicholas Pratte
2024-06-14 18:11   ` Jeremy Spewock
2024-07-05 17:13 ` [PATCH v2 0/6] dts: Remove Excess Attributes From User Config Nicholas Pratte
2024-07-05 18:29   ` [PATCH v2 1/6] dts: Remove build target config and list of devices Nicholas Pratte
2024-07-05 18:31   ` [PATCH v2 2/6] dts: Use First Core Logic Change Nicholas Pratte
2024-07-05 18:32   ` [PATCH v2 3/6] dts: Self-Discovering Architecture Change Nicholas Pratte
2024-07-05 18:32   ` [PATCH v2 4/6] dts: Rework DPDK Attributes In SUT Node Config Nicholas Pratte
2024-07-05 18:33   ` [PATCH v2 5/6] dts: add conditional behavior for test suite Nicholas Pratte
2024-07-05 18:33   ` [PATCH v2 6/6] doc: dpdk documentation changes for new dts config Nicholas Pratte
2024-07-05 17:13 ` [PATCH v2 1/6] dts: Remove build target config and list of devices Nicholas Pratte
2024-07-16 15:07   ` Jeremy Spewock
2024-09-12 20:33     ` Nicholas Pratte
2024-09-10 11:30   ` Juraj Linkeš
2024-09-12 20:31     ` Nicholas Pratte [this message]
2024-07-05 17:13 ` [PATCH v2 2/6] dts: Use First Core Logic Change Nicholas Pratte
2024-09-10 13:34   ` Juraj Linkeš
2024-07-05 17:13 ` [PATCH v2 3/6] dts: Self-Discovering Architecture Change Nicholas Pratte
2024-09-10 13:41   ` Juraj Linkeš
2024-07-05 17:13 ` [PATCH v2 4/6] dts: Rework DPDK Attributes In SUT Node Config Nicholas Pratte
2024-09-10 14:04   ` Juraj Linkeš
2024-07-05 17:13 ` [PATCH v2 5/6] dts: add conditional behavior for test suite Nicholas Pratte
2024-07-16 14:59   ` Jeremy Spewock
2024-09-10 14:12   ` Juraj Linkeš
2024-07-05 17:13 ` [PATCH v2 6/6] doc: dpdk documentation changes for new dts config Nicholas Pratte
2024-09-10 14:17   ` Juraj Linkeš
2024-07-05 18:24 ` [PATCH v2 1/6] dts: Remove build target config and list of devices Nicholas Pratte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKXZ7egT91Z8_=dO_OTkVrt+-fT6aNSnc11yO3vJgZYKkiPgEA@mail.gmail.com' \
    --to=npratte@iol.unh.edu \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=dmarx@iol.unh.edu \
    --cc=jspewock@iol.unh.edu \
    --cc=juraj.linkes@pantheon.tech \
    --cc=luca.vizzarro@arm.com \
    --cc=paul.szczepanek@arm.com \
    --cc=probb@iol.unh.edu \
    --cc=yoan.picchi@foss.arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).