From: Nicholas Pratte <npratte@iol.unh.edu>
To: Luca Vizzarro <Luca.Vizzarro@arm.com>
Cc: Honnappa.Nagarahalli@arm.com, stephen@networkplumber.org,
thomas.wilks@arm.com, probb@iol.unh.edu, thomas@monjalon.net,
dmarx@iol.unh.edu, yoan.picchi@foss.arm.com,
paul.szczepanek@arm.com, ian.stokes@intel.com, dev@dpdk.org
Subject: Re: [PATCH v2 2/2] dts: rework run-time MTU adjustment test case
Date: Wed, 5 Feb 2025 12:24:52 -0500 [thread overview]
Message-ID: <CAKXZ7egr_0cidsW8gihuDzqn7dEfLff9yD-+XQ1wBQMA5CjC2w@mail.gmail.com> (raw)
In-Reply-To: <77ef65b2-3a3d-489a-a4da-474d181193a0@arm.com>
My bad! I'll fix that real quick.
On Mon, Feb 3, 2025 at 11:51 AM Luca Vizzarro <Luca.Vizzarro@arm.com> wrote:
>
> On 03/02/2025 16:38, Nicholas Pratte wrote:
> > --- a/dts/tests/TestSuite_mtu.py
> > +++ b/dts/tests/TestSuite_mtu.py
> > @@ -164,22 +164,33 @@ def test_runtime_mtu_updating_and_forwarding(self) -> None:
> > # Configure the new MTU.
> >
> > # Start packet capturing.
> > - testpmd.start()
> >
> Sorry!! you forgot to remove the lines above until the docstring I presume.
> > testpmd.set_port_mtu_all(1500, verify=True)
> > +
>
> Looks good otherwise!
>
> Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>
prev parent reply other threads:[~2025-02-05 17:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 19:38 [PATCH 0/2] remove 'requires_forwarding_restart' from framework Nicholas Pratte
2025-01-31 19:38 ` [PATCH 1/2] dts: " Nicholas Pratte
2025-01-31 21:00 ` Luca Vizzarro
2025-01-31 19:38 ` [PATCH 2/2] dts: rework run-time MTU adjustment test case Nicholas Pratte
2025-01-31 21:08 ` Luca Vizzarro
2025-02-03 16:21 ` Nicholas Pratte
2025-02-03 16:38 ` [PATCH v2 0/2] remove requires forwarding restart from framework Nicholas Pratte
2025-02-03 16:38 ` [PATCH v2 1/2] dts: remove 'requires_forwarding_restart' " Nicholas Pratte
2025-02-04 10:40 ` Luca Vizzarro
2025-02-03 16:38 ` [PATCH v2 2/2] dts: rework run-time MTU adjustment test case Nicholas Pratte
2025-02-03 16:50 ` Luca Vizzarro
2025-02-05 17:24 ` Nicholas Pratte [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKXZ7egr_0cidsW8gihuDzqn7dEfLff9yD-+XQ1wBQMA5CjC2w@mail.gmail.com \
--to=npratte@iol.unh.edu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Luca.Vizzarro@arm.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=ian.stokes@intel.com \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=stephen@networkplumber.org \
--cc=thomas.wilks@arm.com \
--cc=thomas@monjalon.net \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).