From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5862844078; Mon, 20 May 2024 17:08:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44F5F402E0; Mon, 20 May 2024 17:08:32 +0200 (CEST) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by mails.dpdk.org (Postfix) with ESMTP id 4BB74402CD for ; Mon, 20 May 2024 17:08:31 +0200 (CEST) Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2e22dd47706so1363871fa.0 for ; Mon, 20 May 2024 08:08:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1716217711; x=1716822511; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EF+iBNU4Ij1xkfROEOK7j/FvfGdG7s08YFRstB8ktsE=; b=X/KYgDUwaRTM59R0hSWOApeAL+ycZDyCUTBVSb22+dMCMawBCw9zumiRsul2abdMr6 Ps/p//wuDL+aWJZUrzYQ9QVONM+LRnYcf2CTk3uH8kJ9uRJseBWSczdOLMgFe+95G6xD ZcftnMW3rZf9LYkgPtm0sA2r+PFoauDUu2Ylc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716217711; x=1716822511; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EF+iBNU4Ij1xkfROEOK7j/FvfGdG7s08YFRstB8ktsE=; b=oupDI7IfjllRLQCeqlhUdf38pVqpUj0Lvc5x61WdKWOOjGou/AHj2Fj/vl+9oFaJHA FxC9gCAKOl5kR6GdSw0777DL3J+HVIJ6b7gCmXa8r3Vo58L/pN8PtO8vSqd+CAVVKPEG FTawasOPDkg4lGeRYdRN0M/7F+BCyWI6FftiBMpqDfDxgA+IxML+fDDODnJUVy96GX5C Zkf6RSD5Jqi6AG6vdentuBLdaGDTP7j9v7kaMfA3ZjnugSvE50V6Uruqe0o+1mMzsltW cm6P7SwQPmj8JA6cDSc6ZvI9nSE0eQGcDqOwTKm+LEljY90AXrs4xJWS13r4yRB73b0S sLkw== X-Forwarded-Encrypted: i=1; AJvYcCXM9QUpXKE4rFk31GDNZmWHe8kTI4Fqsp64rNBP7jlPivfvKKM+xI9NyPVP/ojgl1Ga7xD8MuVUeh7IAcE= X-Gm-Message-State: AOJu0YzheFIQqh7in4ElL4IV8gsi10Xnx6aq3MTJIRPvFHjb/fVu4mGh m5nRlMKu6uliXNK/aOfbBf7zxKSg5jQJq/W0SOs5BYUEMIJlzXAqdZCwSF4JcD7uRdQeFi7mGtC dSFRm+Rg/41+nMXNH1DB5MqeXoHwLw9zfMwJTxA== X-Google-Smtp-Source: AGHT+IFmr1l9zv6IEl3+DujdPdDRSPQc2Svo/HmHp36UcrqDzJ9FgO7jgfyGFOLvWbVngx4Aj5YzeqguzA2DmB5qg9s= X-Received: by 2002:a2e:8847:0:b0:2dd:374d:724e with SMTP id 38308e7fff4ca-2e51fd3127bmr191211411fa.1.1716217710726; Mon, 20 May 2024 08:08:30 -0700 (PDT) MIME-Version: 1.0 References: <20240312172558.11844-1-jspewock@iol.unh.edu> <20240501161623.26672-1-jspewock@iol.unh.edu> In-Reply-To: From: Nicholas Pratte Date: Mon, 20 May 2024 11:08:19 -0400 Message-ID: Subject: Re: [PATCH v2 0/3] Improve interactive shell output gathering and logging To: Luca Vizzarro Cc: jspewock@iol.unh.edu, wathsala.vithanage@arm.com, yoan.picchi@foss.arm.com, juraj.linkes@pantheon.tech, paul.szczepanek@arm.com, probb@iol.unh.edu, thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Nicholas Pratte On Thu, May 9, 2024 at 5:59=E2=80=AFAM Luca Vizzarro wrote: > > On 01/05/2024 17:16, jspewock@iol.unh.edu wrote: > > This version addresses comments from the last and adds an additional > > improvement to the logging output that comes from interactive shells. > > The new way of handling logging allows for not only specification of th= e > > host that the command is being sent to like before, but also the type o= f > > shell that you are addressing. This is beneficial for 2 reasons: > > > > 1. Less ambiguity on if a command is being sent to the host directly or > > into an interactive shell > > 2. Ability to name shells so that there is distinction in the logs > > between two different interactive shells of the same type that serve a > > different purpose (e.g. a python shell and a python shell that is > > serving and XML-RPC server for scapy interactions) > > Hi Jeremy, > > Thank you for your patches! Everything looks good to me. > > Best, > Luca