From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33F3444098; Wed, 22 May 2024 17:59:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB5EF400D7; Wed, 22 May 2024 17:59:24 +0200 (CEST) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by mails.dpdk.org (Postfix) with ESMTP id E1C60400D6 for ; Wed, 22 May 2024 17:59:23 +0200 (CEST) Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2e22dd47706so19281fa.0 for ; Wed, 22 May 2024 08:59:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1716393563; x=1716998363; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jocdH7uk//ilfSg+Rh3JXBhAOboxG84gGgFGVGaIKQE=; b=UN071HtQIAyfQu5vtRkV94ax6bMF7uHlO0cSUVLoN70vBBwW/SobsfTkZPQAlBptoB GgcUWLP8WCv+gqrVVzBWykx6txFNhwiWItJcgJIvWIp4NxQXZqYQAL5Z5ZV0d5wyQHNV dPagP9MpLn6SGkAIaT3E9I0ugNtLFA1rNh3kk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716393563; x=1716998363; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jocdH7uk//ilfSg+Rh3JXBhAOboxG84gGgFGVGaIKQE=; b=A+w7MnX42wDK+VNiMFn6J0R2NQ1UCEMH9exUiHBuG3M0w86Jx+oG83XeliEcVzLF0R /eTeg10I3pOLRVL8o4Sh5ZCByo1ZegNIkNJ4PgmpdvCfBuUlwTk6gDbWk/VwD34eoxu2 MroU3Mo5GheujUwGRTI4g/lfBN5Vjxvg5JXBalUTkOd/+Vjqz7BSyHxceEEFDU4fwz7l UrJlqJtjD8Aa9TdpvLgDljzZQRXg0y9TouSQC+kTVJdPiQkjRtNSsWzpmo74KAL8iKrZ qlShgROuRaw14bGxLYGTAdggRLerPqB/VLpLSBt0yPUlmTXaolyZc3wsOcfN6w77Vnhm y4WA== X-Gm-Message-State: AOJu0YxBXF63m0TbVMi/C/hP1qqhWCr9tuSRKXG149u6Y2LD7bnR0ZuR pyBvik3tp6nAnoQlu5R3TV48xf8dpdY7PCtYiAi7hLJmnlZrZJFnd/rG/me3DM4QzZsw+cQDPKS klrm2ZuAjQTxyj6HAzr6igRn+2rpFxM0LpO0AcQ== X-Google-Smtp-Source: AGHT+IFi1+AYI7VqLvpNV3HKyfgpKMwmBD4D8frqYkDUhJDe4zSULs/w5TFJDOkMnK7sIjmD+Yysdlh3SLeI1kzCFao= X-Received: by 2002:a2e:a78d:0:b0:2e6:f469:30d1 with SMTP id 38308e7fff4ca-2e949640757mr17126011fa.3.1716393563233; Wed, 22 May 2024 08:59:23 -0700 (PDT) MIME-Version: 1.0 References: <20240326190422.577028-1-luca.vizzarro@arm.com> <20240509112057.1167947-1-luca.vizzarro@arm.com> In-Reply-To: <20240509112057.1167947-1-luca.vizzarro@arm.com> From: Nicholas Pratte Date: Wed, 22 May 2024 11:59:11 -0400 Message-ID: Subject: Re: [PATCH v2 0/8] dts: add testpmd params To: Luca Vizzarro Cc: dev@dpdk.org, =?UTF-8?Q?Juraj_Linke=C5=A1?= , Jeremy Spewock Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In addition to the pmd_scatter suite, I refactored my jumboframes suite to use this new module for testing purposes; everything works great, and the format looks much better too. Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Thu, May 9, 2024 at 7:21=E2=80=AFAM Luca Vizzarro wrote: > > Hello, > > sending in v2: > - refactored the params module > - strengthened typing of the params module > - moved the params module into its own package > - refactored EalParams and TestPmdParams and > moved under the params package > - reworked interactions between nodes and shells > - refactored imports leading to circular dependencies > > Best, > Luca > > --- > Depends-on: series-31896 ("dts: update mypy and clean up") > --- > > Luca Vizzarro (8): > dts: add params manipulation module > dts: use Params for interactive shells > dts: refactor EalParams > dts: remove module-wide imports > dts: add testpmd shell params > dts: use testpmd params for scatter test suite > dts: rework interactive shells > dts: use Unpack for type checking and hinting > > dts/framework/params/__init__.py | 274 ++++++++ > dts/framework/params/eal.py | 50 ++ > dts/framework/params/testpmd.py | 608 ++++++++++++++++++ > dts/framework/params/types.py | 133 ++++ > dts/framework/remote_session/__init__.py | 5 +- > dts/framework/remote_session/dpdk_shell.py | 104 +++ > .../remote_session/interactive_shell.py | 83 ++- > dts/framework/remote_session/python_shell.py | 4 +- > dts/framework/remote_session/testpmd_shell.py | 102 ++- > dts/framework/runner.py | 4 +- > dts/framework/test_suite.py | 5 +- > dts/framework/testbed_model/__init__.py | 7 - > dts/framework/testbed_model/node.py | 36 +- > dts/framework/testbed_model/os_session.py | 38 +- > dts/framework/testbed_model/sut_node.py | 182 +----- > .../testbed_model/traffic_generator/scapy.py | 6 +- > dts/tests/TestSuite_hello_world.py | 9 +- > dts/tests/TestSuite_pmd_buffer_scatter.py | 21 +- > dts/tests/TestSuite_smoke_tests.py | 4 +- > 19 files changed, 1296 insertions(+), 379 deletions(-) > create mode 100644 dts/framework/params/__init__.py > create mode 100644 dts/framework/params/eal.py > create mode 100644 dts/framework/params/testpmd.py > create mode 100644 dts/framework/params/types.py > create mode 100644 dts/framework/remote_session/dpdk_shell.py > > -- > 2.34.1 >