From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FD3E45482; Mon, 17 Jun 2024 17:24:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F84440BA4; Mon, 17 Jun 2024 17:24:57 +0200 (CEST) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by mails.dpdk.org (Postfix) with ESMTP id C13364028B for ; Mon, 17 Jun 2024 17:24:55 +0200 (CEST) Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2ec18643661so3462531fa.0 for ; Mon, 17 Jun 2024 08:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1718637895; x=1719242695; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4mpROxtaZkyPg7Fq9MekuSq9ToSN8RxHPeuZXzLprbM=; b=iFwkmRqAQSwwCUdS4CkhAheIRhlwUpyUJjT/0tmhYucwY/PxkvxWXz7PlSYiQkvuHz gfRpS4WLo0YBXwnaFO87QCJz2P1zTMsoXFndn8rt9zwmIX4RAo/F8mflxYQC2juZGs9v WOnWvDT/4zlZzbiVApMpLrnP6lYkMvJzsZ87s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718637895; x=1719242695; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4mpROxtaZkyPg7Fq9MekuSq9ToSN8RxHPeuZXzLprbM=; b=Xj5mYEEZPAoeLwCVhVF0EB7rY+y/X4RAkT1l8gtH7b2qDulvpD5sAuBqrTuf4hZOzL NsEdZi+SGYhk8qZEk85UpVlb+WqfD9dlMVNGyrjhfLdX4pmZ7o5u5Sl5k5vP5hHf6aKu po5QRWIpJqJRZdJooTiD4llyIYVmFOFM5h3GC0s4ZtNKtUrMa0p+d/GE+vO7PKr4sCkC FptdZhY2acLc4NFnihdKcyY81gGTnhA+xSOVWaRHTYGfdcK8edvfojogn1iCOJlJwgbj GpZqi7P85d3CkI9i1zQ/Gyv2GPdgKD5R67Em/V74NXjQCkasnMzz7JropexILnSSsd5C s23g== X-Gm-Message-State: AOJu0Ywgh9pqKIJdv+pXRpnGHs3w5Ur12uytROyGyDOTQNUVEa+IyvcC 9TQvr7+sStNvtgG5brsPSdc9l2I7kVS9XWpUxdc8dBCe+yMlKqKKHEcDG6IkDrapQmzHpbDuRv5 Ia6m6JO1STajhuvw0Cqbl49ZeNzuLAi4JCJkg7w== X-Google-Smtp-Source: AGHT+IEDuBsyytbikim7Sff9iemxzjUEkC8ijNC71EmGzQ6LWPi3G156dzPWue6RaFdujQyuSH9knxQQ8vjwPNpki5o= X-Received: by 2002:a05:651c:547:b0:2ec:e97:3dc1 with SMTP id 38308e7fff4ca-2ec0e973e41mr61199591fa.0.1718637895235; Mon, 17 Jun 2024 08:24:55 -0700 (PDT) MIME-Version: 1.0 References: <20240326190422.577028-1-luca.vizzarro@arm.com> <20240617145409.67407-1-luca.vizzarro@arm.com> <20240617145409.67407-7-luca.vizzarro@arm.com> In-Reply-To: <20240617145409.67407-7-luca.vizzarro@arm.com> From: Nicholas Pratte Date: Mon, 17 Jun 2024 11:24:44 -0400 Message-ID: Subject: Re: [PATCH v5 6/8] dts: use testpmd params for scatter test suite To: Luca Vizzarro Cc: dev@dpdk.org, Jeremy Spewock , =?UTF-8?Q?Juraj_Linke=C5=A1?= , Paul Szczepanek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Mon, Jun 17, 2024 at 10:54=E2=80=AFAM Luca Vizzarro wrote: > > Update the buffer scatter test suite to use TestPmdParameters > instead of the StrParams implementation. > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek > Reviewed-by: Juraj Linke=C5=A1 > Reviewed-by: Jeremy Spewock > Reviewed-by: Nicholas Pratte > --- > dts/tests/TestSuite_pmd_buffer_scatter.py | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/dts/tests/TestSuite_pmd_buffer_scatter.py b/dts/tests/TestSu= ite_pmd_buffer_scatter.py > index 578b5a4318..6d206c1a40 100644 > --- a/dts/tests/TestSuite_pmd_buffer_scatter.py > +++ b/dts/tests/TestSuite_pmd_buffer_scatter.py > @@ -16,14 +16,14 @@ > """ > > import struct > +from dataclasses import asdict > > from scapy.layers.inet import IP # type: ignore[import-untyped] > from scapy.layers.l2 import Ether # type: ignore[import-untyped] > from scapy.packet import Raw # type: ignore[import-untyped] > from scapy.utils import hexstr # type: ignore[import-untyped] > > -from framework.params import Params > -from framework.params.testpmd import SimpleForwardingModes > +from framework.params.testpmd import SimpleForwardingModes, TestPmdParam= s > from framework.remote_session.testpmd_shell import TestPmdShell > from framework.test_suite import TestSuite > > @@ -105,16 +105,16 @@ def pmd_scatter(self, mbsize: int) -> None: > """ > testpmd =3D self.sut_node.create_interactive_shell( > TestPmdShell, > - app_params=3DParams.from_str( > - "--mbcache=3D200 " > - f"--mbuf-size=3D{mbsize} " > - "--max-pkt-len=3D9000 " > - "--port-topology=3Dpaired " > - "--tx-offloads=3D0x00008000" > + app_params=3DTestPmdParams( > + forward_mode=3DSimpleForwardingModes.mac, > + mbcache=3D200, > + mbuf_size=3D[mbsize], > + max_pkt_len=3D9000, > + tx_offloads=3D0x00008000, > + **asdict(self.sut_node.create_eal_parameters()), > ), > privileged=3DTrue, > ) > - testpmd.set_forward_mode(SimpleForwardingModes.mac) > testpmd.start() > > for offset in [-1, 0, 1, 4, 5]: > -- > 2.34.1 >