From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6443F440EC; Tue, 28 May 2024 17:49:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9A39402E8; Tue, 28 May 2024 17:49:56 +0200 (CEST) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by mails.dpdk.org (Postfix) with ESMTP id C346B402E4 for ; Tue, 28 May 2024 17:49:55 +0200 (CEST) Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2e9618794c0so805721fa.1 for ; Tue, 28 May 2024 08:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1716911395; x=1717516195; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=j7YErz26OYwiZXe+0MgubEFfPxNDGGdKpyn0u6Q0+M4=; b=ehJ1Ifnj2DiTsVEWQOBZ08uxUle8s1YcmuzqN2YcAXvCDkl6x5QgWlroLRFHCh6llp As/6cueqCfO+2EbJpNpiYV95gzIndB4SlxentNaUwZfZdKkLSLxIqhvgcigGJXH9/nn8 o4ntwWkDDglczRyfM3C89G5ahwGSgtmVgeRzk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716911395; x=1717516195; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j7YErz26OYwiZXe+0MgubEFfPxNDGGdKpyn0u6Q0+M4=; b=jlwd4qjC3gDjjqHJ2sQ8mWn577lAzZmE61ngVClfMttmjpQXeZf8T+83h3QFqrUxwG lRTbKmrIK1Vpt6T2bAw+uVxvb47u+/0DpBrOMusRdksvbTCdgfc8SqBuZDyMKqkb1/XA GmBOvJrmNOJKjaQ7wyWKhWT3Hhjb0T1vmd9qlBbqx+8ErFWL28vy+6yu2bM5Vn076UZh /YI8/PWOwloOnLEFAVHt0R0A1zmER2kyzqzdagmwsKjbKSAKnTwhVBPqAbe6RCCBcnVp pexWbnZm55tNdF1Edq4STWKMUY6gtkRqnzWhp8YeZvSzJKoHgwaCltvKenXPleTCWy6K 2dCQ== X-Gm-Message-State: AOJu0YyuS/KwKVd581KbIEuG8+Gj19qW1DZ/DcmsUaqb85AF7SxC1HRQ iFNESE6uTmmquYYkwgzqLLEmXAtNJgar8fFmvt95REJP+2UD/ZVQarEzM+1KO7a09zdr+P4AVc7 kmcIFpJ+GJq0zqtrCSfV/hsD4MZ7DxqeshSQp1g== X-Google-Smtp-Source: AGHT+IGJwagCTsCrfidfcNQqvgOX8cHLn9mXvyPgY1vSYV8Yr/Zr5b/R3kgF65ZjT8TIcrjct5shDn4IlRKvxlrKss4= X-Received: by 2002:a2e:99d5:0:b0:2e6:f469:30d1 with SMTP id 38308e7fff4ca-2e95b2ca9e7mr68613921fa.3.1716911395086; Tue, 28 May 2024 08:49:55 -0700 (PDT) MIME-Version: 1.0 References: <20240326190422.577028-1-luca.vizzarro@arm.com> <20240509112057.1167947-1-luca.vizzarro@arm.com> <20240509112057.1167947-7-luca.vizzarro@arm.com> In-Reply-To: <20240509112057.1167947-7-luca.vizzarro@arm.com> From: Nicholas Pratte Date: Tue, 28 May 2024 11:49:43 -0400 Message-ID: Subject: Re: [PATCH v2 6/8] dts: use testpmd params for scatter test suite To: Luca Vizzarro Cc: dev@dpdk.org, =?UTF-8?Q?Juraj_Linke=C5=A1?= , Jeremy Spewock , Paul Szczepanek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Thu, May 9, 2024 at 7:21=E2=80=AFAM Luca Vizzarro wrote: > > Update the buffer scatter test suite to use TestPmdParameters > instead of the StrParams implementation. > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek > --- > dts/tests/TestSuite_pmd_buffer_scatter.py | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/dts/tests/TestSuite_pmd_buffer_scatter.py b/dts/tests/TestSu= ite_pmd_buffer_scatter.py > index 578b5a4318..6d206c1a40 100644 > --- a/dts/tests/TestSuite_pmd_buffer_scatter.py > +++ b/dts/tests/TestSuite_pmd_buffer_scatter.py > @@ -16,14 +16,14 @@ > """ > > import struct > +from dataclasses import asdict > > from scapy.layers.inet import IP # type: ignore[import-untyped] > from scapy.layers.l2 import Ether # type: ignore[import-untyped] > from scapy.packet import Raw # type: ignore[import-untyped] > from scapy.utils import hexstr # type: ignore[import-untyped] > > -from framework.params import Params > -from framework.params.testpmd import SimpleForwardingModes > +from framework.params.testpmd import SimpleForwardingModes, TestPmdParam= s > from framework.remote_session.testpmd_shell import TestPmdShell > from framework.test_suite import TestSuite > > @@ -105,16 +105,16 @@ def pmd_scatter(self, mbsize: int) -> None: > """ > testpmd =3D self.sut_node.create_interactive_shell( > TestPmdShell, > - app_params=3DParams.from_str( > - "--mbcache=3D200 " > - f"--mbuf-size=3D{mbsize} " > - "--max-pkt-len=3D9000 " > - "--port-topology=3Dpaired " > - "--tx-offloads=3D0x00008000" > + app_params=3DTestPmdParams( > + forward_mode=3DSimpleForwardingModes.mac, > + mbcache=3D200, > + mbuf_size=3D[mbsize], > + max_pkt_len=3D9000, > + tx_offloads=3D0x00008000, > + **asdict(self.sut_node.create_eal_parameters()), > ), > privileged=3DTrue, > ) > - testpmd.set_forward_mode(SimpleForwardingModes.mac) > testpmd.start() > > for offset in [-1, 0, 1, 4, 5]: > -- > 2.34.1 >