From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BEDAE440B7; Fri, 31 May 2024 17:23:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A22CF42D6A; Fri, 31 May 2024 17:23:07 +0200 (CEST) Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by mails.dpdk.org (Postfix) with ESMTP id EBB9642D45 for ; Fri, 31 May 2024 17:23:05 +0200 (CEST) Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2ea9610eca7so650721fa.0 for ; Fri, 31 May 2024 08:23:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1717168985; x=1717773785; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5Sd/zHmdY5DF1UNEJDDbpv5DheBj9hBQbGW575r/d3Q=; b=GpNynkYA7TMjnJ5/DMbUeWzHbTOYtiZuA0qJU+b3I9xulXoMK0rzOlKTqzBmNtw2Dg E6RhRDzDNx6kwMO2tUcTQ1je9ac7I9Arzni4mew6RlRCYIshV8Pvy8MGJRgwrrwFy4Um 1n0N/j7UZ0AbxTZb9ASwyDk+xXb3IAe0KolWs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717168985; x=1717773785; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5Sd/zHmdY5DF1UNEJDDbpv5DheBj9hBQbGW575r/d3Q=; b=aVZjRE2F03YRJXU2Yiev/2th8rbWcujcsJr7DPsgDeSReBtMQxqKzzu8Q6zY709Z8q Rr24O8nMJJqAyBOc3VLBD1lunycJ23N77Wmk6hgvgGN1tYGB6gSYJG1MqYJ/5Ugs++8s J8S9lP557K74GdT6Pnoq+D1giB6WzdlvVzjIwZzaShrIOl3YdfK4rY/BM5jnMmuV8DxD ZA4ly3Wt2tRoAjE9K+Jd1JzTyaTqu0UemU1BRRz13Ene2ihBudm5zmqHmy/cbe9sFI9J jJ0THOIdjndAccFT9vkvWOrT0C9O0hSzTPzXTPsgKTZ58xOGRUyFrDiSNuTERHk8sOsM 8lPQ== X-Gm-Message-State: AOJu0YzuDeTrxg7dophgOCpctwXsLJMDTN0z55IJy2fcm7ortcVGnWit lwEKNTjtAAAjYBAdEHt1f035UKM3OWsnh02vKWZjLjnF5thrGCJ0RJFrBy988dXXuM6frcPg1J4 Ug07Z8oUMWheCtgxTEZGYuRsGvgDCWvEIoS8gvA== X-Google-Smtp-Source: AGHT+IHr6S4QMzh/UBHTBNoB4mISae+Qs13P4P0q0brTaSzkEmGjrx51NR+/vdI7f4v7IOGMKD5fFdYe4MxSGIL2w7Y= X-Received: by 2002:a2e:8756:0:b0:2ea:8442:2096 with SMTP id 38308e7fff4ca-2ea95153f82mr13602211fa.2.1717168985332; Fri, 31 May 2024 08:23:05 -0700 (PDT) MIME-Version: 1.0 References: <20240326190422.577028-1-luca.vizzarro@arm.com> <20240530152505.389167-1-luca.vizzarro@arm.com> <20240530152505.389167-7-luca.vizzarro@arm.com> In-Reply-To: <20240530152505.389167-7-luca.vizzarro@arm.com> From: Nicholas Pratte Date: Fri, 31 May 2024 11:22:53 -0400 Message-ID: Subject: Re: [PATCH v3 6/8] dts: use testpmd params for scatter test suite To: Luca Vizzarro Cc: dev@dpdk.org, =?UTF-8?Q?Juraj_Linke=C5=A1?= , Jeremy Spewock , Paul Szczepanek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Thu, May 30, 2024 at 11:25=E2=80=AFAM Luca Vizzarro wrote: > > Update the buffer scatter test suite to use TestPmdParameters > instead of the StrParams implementation. > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek > --- > dts/tests/TestSuite_pmd_buffer_scatter.py | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/dts/tests/TestSuite_pmd_buffer_scatter.py b/dts/tests/TestSu= ite_pmd_buffer_scatter.py > index 578b5a4318..6d206c1a40 100644 > --- a/dts/tests/TestSuite_pmd_buffer_scatter.py > +++ b/dts/tests/TestSuite_pmd_buffer_scatter.py > @@ -16,14 +16,14 @@ > """ > > import struct > +from dataclasses import asdict > > from scapy.layers.inet import IP # type: ignore[import-untyped] > from scapy.layers.l2 import Ether # type: ignore[import-untyped] > from scapy.packet import Raw # type: ignore[import-untyped] > from scapy.utils import hexstr # type: ignore[import-untyped] > > -from framework.params import Params > -from framework.params.testpmd import SimpleForwardingModes > +from framework.params.testpmd import SimpleForwardingModes, TestPmdParam= s > from framework.remote_session.testpmd_shell import TestPmdShell > from framework.test_suite import TestSuite > > @@ -105,16 +105,16 @@ def pmd_scatter(self, mbsize: int) -> None: > """ > testpmd =3D self.sut_node.create_interactive_shell( > TestPmdShell, > - app_params=3DParams.from_str( > - "--mbcache=3D200 " > - f"--mbuf-size=3D{mbsize} " > - "--max-pkt-len=3D9000 " > - "--port-topology=3Dpaired " > - "--tx-offloads=3D0x00008000" > + app_params=3DTestPmdParams( > + forward_mode=3DSimpleForwardingModes.mac, > + mbcache=3D200, > + mbuf_size=3D[mbsize], > + max_pkt_len=3D9000, > + tx_offloads=3D0x00008000, > + **asdict(self.sut_node.create_eal_parameters()), > ), > privileged=3DTrue, > ) > - testpmd.set_forward_mode(SimpleForwardingModes.mac) > testpmd.start() > > for offset in [-1, 0, 1, 4, 5]: > -- > 2.34.1 >