From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 119A54594A;
	Mon,  9 Sep 2024 19:54:40 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id F254741140;
	Mon,  9 Sep 2024 19:54:39 +0200 (CEST)
Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com
 [209.85.208.179])
 by mails.dpdk.org (Postfix) with ESMTP id 023884113C
 for <dev@dpdk.org>; Mon,  9 Sep 2024 19:54:37 +0200 (CEST)
Received: by mail-lj1-f179.google.com with SMTP id
 38308e7fff4ca-2f7544b016cso2351071fa.3
 for <dev@dpdk.org>; Mon, 09 Sep 2024 10:54:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=iol.unh.edu; s=unh-iol; t=1725904477; x=1726509277; darn=dpdk.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=0ncwKP6+MSQ9iXnb4Qe6fQBwlnpTNIg9CVCpk9hUyXs=;
 b=Qyyfgm4+/SYyvC4pdW+aPnq1PKtdFrp0BpP+Yimld0En2V9hG18DRUdzwYhpQ1rbLi
 Sgmfu/hiaoPnriNAeped+DI5DJpa8vfQ3z7Lf2OQeD42izcWw5oI/A3H/4P8zBLHB/5V
 dolWt0/56ox1sSbvqnTr+IhooqpNHm3mNDrgI=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1725904477; x=1726509277;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=0ncwKP6+MSQ9iXnb4Qe6fQBwlnpTNIg9CVCpk9hUyXs=;
 b=eTvjL6waJUV28F7CccA5yN9FVZliZYopcW90n2GjqaHdI/tocOlwqi/QmeXK+dgrf0
 uBbukhA/a9x9/rfuKUXT5bV6/mqc91ftSLeym2oHMFjg5TVbsFrqnLNbpZsCPFFVxHCO
 z1xgnuJt21XTXRh9+Mywjp2xXiw6pwuKrvaLkBWBlYfubZdFpMsAyrlIz0YOzKzSLR/r
 U5yVq77dYziInEuYxjN2XRgLV2BDFZxnNdGl+HRcF3qAj4tMwFB3BFo09zrrNcsKRIh+
 oKBxBZvlWqPEtj+rBnjG2OcDwtlep/lBuG12ZRud9aG2rGYXzzCS6CFWDQT1iQXRRyrF
 WMBA==
X-Gm-Message-State: AOJu0YwCSml+kI59dJM+1hMwrIADozmQJIRr0+5Z2+Thpy8n2lXB5Aj/
 xF67Ed1JziznuOkidgQ7LHsJu22Y08iAf76Hj4NZjakJKFjX8z/4DKH1JGZEYUSkKSOjteVmv+T
 Z9rLUlpLHd/dzyQ2hKsaRf4Nu/pLWaoxddXRP/Q==
X-Google-Smtp-Source: AGHT+IHCN5pge+s2ZCAX5Co3ooFj/dmSRG0f1wnaksKLwM1bIJJ6ZsxafUnh0KZJ3F+g2WY0lMrFXQ28kVI1FmhK4H0=
X-Received: by 2002:a2e:9fc9:0:b0:2f7:5c24:97b with SMTP id
 38308e7fff4ca-2f75c24197amr21886201fa.12.1725904477128; Mon, 09 Sep 2024
 10:54:37 -0700 (PDT)
MIME-Version: 1.0
References: <20240806125140.2582859-1-luca.vizzarro@arm.com>
In-Reply-To: <20240806125140.2582859-1-luca.vizzarro@arm.com>
From: Nicholas Pratte <npratte@iol.unh.edu>
Date: Mon, 9 Sep 2024 13:54:24 -0400
Message-ID: <CAKXZ7ej7fMjw=b0fuSv7mTA4M9A6kqbi8Avngfh1-JDukYfNEA@mail.gmail.com>
Subject: Re: [PATCH] dts: add l2fwd test suite
To: Luca Vizzarro <luca.vizzarro@arm.com>
Cc: dev@dpdk.org, Jeremy Spewock <jspewock@iol.unh.edu>, 
 =?UTF-8?Q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>, 
 Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
 Paul Szczepanek <paul.szczepanek@arm.com>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Just a few clarifying questions below. Otherwise,

(Test cases was run on Connect_x5 and Broadcom P225p devices).

Reviewed-by: Nicholas Pratte <npratte@iol.unh.edu>
Tested-by: Nicholas Pratte <npratte@iol.unh.edu>

<snip>
> +
> +        with TestPmdShell(
> +            self.sut_node,
> +            lcore_filter_specifier=LogicalCoreCount(cores_per_socket=4),
> +            forward_mode=SimpleForwardingModes.mac,
> +            eth_peer=[EthPeer(1, self.tg_node.ports[1].mac_address)],
> +            disable_device_start=True,

Would you be able to elaborate on the explicit lcore definition and
the eth_peer defined in the testpmd parameters above? I tried doing
some digging to understand the existence of these parameters, but
couldn't find anything insightful. Were these parameters basically
just copied over from old DTS?