DPDK patches and discussions
 help / color / mirror / Atom feed
From: Alex Markuze <alex@weka.io>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] UDP Checksum
Date: Thu, 6 Nov 2014 18:26:36 +0200	[thread overview]
Message-ID: <CAKfHP0XV0OrgpjonQozF_pN3TGTR0wsN_WF0qit8B8e7XVW3tQ@mail.gmail.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB977258213A2E79@IRSMSX105.ger.corp.intel.com>

I was setting both ip and udp scum fields to 0. PKT_TX_UDP_CKSUM ==
PKT_TX_L4_MASK = 0x6000.

I was not aware of the get_ipv4_psd_sum(ipv4_hdr);
And I'm quite frankly surprised the HW doesn't already do this. Farther
more I don't remember kernel drivers messing with
L3 Headers(bnx2x/mlx4). Is this true for all PMDs that do scum offloads?

I will give it a try now.


On Thu, Nov 6, 2014 at 6:15 PM, Ananyev, Konstantin <
konstantin.ananyev@intel.com> wrote:

>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Alex Markuze
> > Sent: Thursday, November 06, 2014 4:05 PM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] UDP Checksum
> >
> > Hi,
> > I'm seeing "UDP: bad checksum." messages(dmesg) for packets sent by my
> dpdk
> > app to a socket on a remote machine.
> > Looking at the packets the scum value is set, its just not what wireshark
> > expects.
> >
> > When sending I'm setting these fields in the egress packets.
> >
> >         pkt->pkt.vlan_macip.f.l2_len = sizeof(struct ether_hdr);
> >
> >         pkt->pkt.vlan_macip.f.l3_len = sizeof(struct ipv4_hdr);
> >
> >         pkt->ol_flags |= (PKT_TX_IP_CKSUM | PKT_TX_L4_MASK);
> > //PKT_TX_OFFLOAD_MASK;
> >
> >
> > I'm working with a 82599 VF.
> >
> >
> > Any thoughts? I'm not sure what else to check.
>
> As I remember, you have to setup  IPV4 header checksum to 0 and
> calculate and setup pseudo-header checksum for UDP.
> From app/test-pmd/csumonly.c:
> ...
> if (pkt_ol_flags & (PKT_RX_IPV4_HDR | PKT_RX_TUNNEL_IPV4_HDR)) {
>
>                         /* Do not support ipv4 option field */
>                         l3_len = sizeof(struct ipv4_hdr) ;
>
>                         ...
>
>                         /* Do not delete, this is required by HW*/
>                         ipv4_hdr->hdr_checksum = 0;
>
>                        ...
>
>                       if (l4_proto == IPPROTO_UDP) {
>                                 udp_hdr = (struct udp_hdr*)
> (rte_pktmbuf_mtod(mb,
>                                                 unsigned char *) + l2_len
> + l3_len);
>                                 if (tx_ol_flags & 0x2) {
>                                         /* HW Offload */
>                                         ol_flags |= PKT_TX_UDP_CKSUM;
>                                         if (ipv4_tunnel)
>                                                 udp_hdr->dgram_cksum = 0;
>                                         else
>                                                 /* Pseudo header sum need
> be set properly */
>                                                 udp_hdr->dgram_cksum =
>
> get_ipv4_psd_sum(ipv4_hdr);
>
>
>
>

  reply	other threads:[~2014-11-06 16:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06 16:05 Alex Markuze
2014-11-06 16:15 ` Olivier MATZ
2014-11-06 16:15 ` Ananyev, Konstantin
2014-11-06 16:26   ` Alex Markuze [this message]
     [not found]     ` <2601191342CEEE43887BDE71AB977258213A2EC5@IRSMSX105.ger.corp.intel.com>
2014-11-06 17:07       ` Ananyev, Konstantin
2019-09-24 15:11 [dpdk-dev] udp checksum Khoussi, Siham (IntlAssoc)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKfHP0XV0OrgpjonQozF_pN3TGTR0wsN_WF0qit8B8e7XVW3tQ@mail.gmail.com \
    --to=alex@weka.io \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).