From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f68.google.com (mail-oi0-f68.google.com [209.85.218.68]) by dpdk.org (Postfix) with ESMTP id 1ACCD4C88 for ; Thu, 6 Sep 2018 19:24:37 +0200 (CEST) Received: by mail-oi0-f68.google.com with SMTP id r69-v6so22050270oie.3 for ; Thu, 06 Sep 2018 10:24:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=O2ePdw/RueFUa+NfqsSgnexIjUCICK4DuFEn8GSAi3I=; b=IDnDAnGnpq4lLKjueudotK7/g8eiVqoV9IGL8wMCspc7srdZNEJkUSB7rZExve9Wvk 0Hc0ChLWhyNK2VA2bRbLvCi3XcpFoJVozWB3YXwosTeXvJTYnhs5KxvGdYs/yKCJD7P8 NCwOfSiGuNABw52YMYL7MGgqT1gIFfsp5x5WdmO+UjWrzrGZG4Y++SqDoSTrmIFtjEiL ERZ0+uc3z76dLIUZLBnLHnm9V8RoAK7tf9O0/dZSzsMm+BSaE3hUVsq2Uaqg2ZO1VCje DAhlaz2ZKENK1LgSiYm6/bLzTa/A/X5uvJYXJS99p1LJ5qfFb96r1h4gi+U6vEV62oyt FgRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=O2ePdw/RueFUa+NfqsSgnexIjUCICK4DuFEn8GSAi3I=; b=n7VMJPmmkWGZJcoPBq1YqSjfJ8u9JWo8Kk568OD2mYXid/DKJZNJyd5VpuOwv0Hgwi 4XmJP3SLaewfjZtolUtB/7SnHBuRGWvyM4QFA6TRDuUn9Br5c3gS3tEK/HMeSEdQ07r6 2t0TX5D9sEOJs9nP6FRGFA3SiISwDBuskPq2MZcOSn41EpmuLxwuPV7/5Ya+WLR3xbGS u/2Z/6R0kcYE8r6Je1xH81rbukN4oyFHyWavUvO2t+fhtFQTAbl5yXWHONy7PZkegQUl oGYBFCctxM5LTPZo6A5amY4WCd+PUUwSOj+myVPcH0riOSl50dJ7uzemz3VtdmIBZQyJ YNJw== X-Gm-Message-State: APzg51BigWvtqXFKfG2mZ1s2X6nxdAuUZl2qBjnqBEZS5FwAz2hINPiS Skpjqls5y/bfGqJ6i3iW9MaYWcLjYkHzQon6kdQ= X-Google-Smtp-Source: ANB0VdakAe6wV+OQ7G8akMDOo8cWL49LFJMLEPAZO+jz+4m1m+ng7ym0YrVeC4n9Wp13WU9U4bGLKGZYQmF+dCAWeOg= X-Received: by 2002:a54:4d9d:: with SMTP id y29-v6mr4023283oix.273.1536254676467; Thu, 06 Sep 2018 10:24:36 -0700 (PDT) MIME-Version: 1.0 References: <20180906131653.10752-1-xiaolong.ye@intel.com> <20180906131653.10752-2-xiaolong.ye@intel.com> In-Reply-To: <20180906131653.10752-2-xiaolong.ye@intel.com> From: Rami Rosen Date: Thu, 6 Sep 2018 20:24:25 +0300 Message-ID: To: xiaolong.ye@intel.com Cc: dev@dpdk.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com, xiao.w.wang@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v1 2/2] examples/vdpa: add a new sample for vdpa X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Sep 2018 17:24:37 -0000 Hi all, First, thanks for the vdpa example patches. Second, I am getting a compilation error under Ubuntu 18.04, with gcc version 7.3.0 (Ubuntu 7.3.0-16ubuntu3) ... CC main.o /work/src/dpdk/examples/vdpa/main.c: In function =E2=80=98main=E2=80=99: /work/src/dpdk/examples/vdpa/main.c:321:5: error: ignoring return value of =E2=80=98scanf=E2=80=99, declared with attribute warn_unused_resul= t [-Werror=3Dunused-result] scanf("%c", &ch); ^~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors /work/src/dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'main.o' failed make[1]: *** [main.o] Error 1 Also, it would be nice to have as part of this patch series adding the relevant info in MAINTAINERS, doc/guides/sample_app_ug/index.rst , examples/Makefile and adding a doc/guides/sample_app_ug/vdpa.rst, like most patches for examples do. See for example, commit f5188211c721688bf8530d1648d623205246e1da Author: Fan Zhang Date: Thu Apr 5 17:01:36 2018 +0100 examples/vhost_crypto: add sample application Regards, Rami Rosen