From: Rami Rosen <roszenrami@gmail.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org, john.mcnamara@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] devbind: check for lspci
Date: Thu, 8 Nov 2018 22:38:09 +0200 [thread overview]
Message-ID: <CAKoUArmSpd7wz6d-ho-dcbWPpSnW01-Nd_wX8x_y_Jy_Lp5_xw@mail.gmail.com> (raw)
In-Reply-To: <b544afca-9f01-331c-d8a6-9b85e2c1a8bd@intel.com>
Hi, Anatoly,
This is really minor nitpick, but in case you decide to send V2, I believe
it should say
>> + if ret != 0:
>> + print("'lspci' not found - please install pciutils')
as the name of the package containing lspci is pciutils in centos.
Regards,
Rami Rosen
>
next prev parent reply other threads:[~2018-11-08 20:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 13:56 [dpdk-dev] " Anatoly Burakov
2018-11-07 16:01 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2018-11-07 16:30 ` Burakov, Anatoly
2018-11-07 18:07 ` Ferruh Yigit
2018-11-08 20:38 ` Rami Rosen [this message]
2018-11-09 12:03 ` Burakov, Anatoly
2018-11-10 11:03 ` Rami Rosen
2018-11-12 9:18 ` Burakov, Anatoly
2018-11-13 16:03 ` Burakov, Anatoly
2018-11-13 16:06 ` [dpdk-dev] [PATCH v2] " Anatoly Burakov
2018-11-16 16:54 ` Rami Rosen
2018-11-18 23:05 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKoUArmSpd7wz6d-ho-dcbWPpSnW01-Nd_wX8x_y_Jy_Lp5_xw@mail.gmail.com \
--to=roszenrami@gmail.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).