From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by dpdk.org (Postfix) with ESMTP id 0CDE51150 for ; Thu, 24 Jan 2019 10:14:31 +0100 (CET) Received: by mail-ot1-f65.google.com with SMTP id t5so4644413otk.1 for ; Thu, 24 Jan 2019 01:14:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Gtpup81rXVO1RWFb7iFy1xjC1lTw/fyGBYdjAjIv+3A=; b=NjIrVo6JmeLPd2yCRRuiu+A/McfvhluEZpNqgprfauKHDvwl5Ky5kurHQsCUlY2Hrm wZEWDKIt4VK/QqzseAt1UAtUjJHq9j0eMsBfuE51t0vImez0F1grkK5k4fF8inZwAcUz lu74k2u1IEXVj/ARKiNHZ9UK0ZN5EkQnwEHKJUlcbw/tsB23R2VmueD8tFGhQcxbfW+j FxH7vxaVM3/JGi64xlsK7r0GFPHMCwxtcQF+q+teAZKYpT5+Upp9iwANUIkbMnrcsCUd J2M8Anca1RYxerozQTEAwFAkdR0BoPadP0TzQIGWc3FHt294FYmPu+4vhH1HbNDxTSWC uazA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gtpup81rXVO1RWFb7iFy1xjC1lTw/fyGBYdjAjIv+3A=; b=NNZ57DKE6Iz9eVhHk478UgLYCF7A/IsBj8JQhJ48RDEU3o5P7uJE72rEduOHFyQ1R0 wnQz2LQASqXEn0rdMLBcN3p1a5AjsprDyyFnaXi2LLhzZqFvQXzl/DjI8vN+zhrW909n FPzQwVEBj3A24Rm0jbAmYOrLQwL7ag+/Sfes5JFCRsJ2X9pTLc91lK6EJnzzxDnKong9 0awUuY2GmQ2hOl0DZyFgz0swO2VRAhvcyNuvM80ozCEzJd/MrCE2CqlIvWaXsFOJ3I2h ue40DVD1mWNy3ODLSMsjXB7iDusdEpKcoEPmfJ6nXUCX/jyF1s/g2W9XMxh3XM6Q4ZMR iNQg== X-Gm-Message-State: AJcUukcSvQnvrOVwHPW/0Z5lCH8x5TjeV8hQLtlQiXVKmatOWVgFIwdA TZZohaPV4lEews/TXGHBnV3PLiqt8loStKu7eEs= X-Google-Smtp-Source: ALg8bN6x8LD1w/j4kLzIUlKTF8ANpNz0nEgNfHwk/q4/MWgcEE1faSk3UC5AsCGirGy4lqGMDAf14IzvUdaf/iEKEzw= X-Received: by 2002:a9d:7ac6:: with SMTP id m6mr3925630otn.62.1548321270329; Thu, 24 Jan 2019 01:14:30 -0800 (PST) MIME-Version: 1.0 References: <1489008729-28784-2-git-send-email-rkerur@gmail.com> <1489179491-9401-1-git-send-email-rkerur@gmail.com> <26db3c19-9321-ebd0-c732-54a05ed15a54@intel.com> <2510395.XNuST6rEQr@xps> <2601191342CEEE43887BDE71AB977258010D907202@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB977258010D907202@irsmsx105.ger.corp.intel.com> From: Rami Rosen Date: Thu, 24 Jan 2019 11:14:21 +0200 Message-ID: To: "Ananyev, Konstantin" Cc: Thomas Monjalon , "Yigit, Ferruh" , Ravi Kerur , dpdk-dev , "Mcnamara, John" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6 0/3] examples/l3fwd: merge l3fwd-acl code into l3fwd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jan 2019 09:14:31 -0000 Hi all, >My vote is definitely for merging. +1 for this, this seems very reasonable Regards, Rami Rosen On Wed, 23 Jan 2019 at 19:20, Ananyev, Konstantin wrote: > > > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Wednesday, January 23, 2019 5:11 PM > > To: Yigit, Ferruh ; Ananyev, Konstantin > > Cc: Ravi Kerur ; dpdk-dev ; Mcnamara, John > > Subject: Re: [dpdk-dev] [PATCH v6 0/3] examples/l3fwd: merge l3fwd-acl code into l3fwd > > > > 23/01/2019 17:32, Ferruh Yigit: > > > On 3/10/2017 8:58 PM, rkerur at gmail.com (Ravi Kerur) wrote: > > > > This patchset merges l3fwd-acl and l3fwd code into common directory. > > > > Adds config file read option to build LPM and EM tables. > > > > > > > > Ravi Kerur (3): > > > > examples/l3fwd: merge l3fwd-acl code into l3fwd > > > > examples/l3fwd: add config file support for lpm > > > > examples/l3fwd: add config file support for exact > > > > > > Hi Ravi, > > > > > > These l3fwd patches are in patchwork for a long time, I am updating the patchset > > > as rejected, if it is still relevant please send a new version on top of latest > > > repo. > > > > > > Sorry for any inconvenience caused. > > > > > > For reference patches: > > > https://patches.dpdk.org/patch/21696/ > > > https://patches.dpdk.org/patch/21695/ > > > https://patches.dpdk.org/patch/21697/ > > > > > > doc one: > > > https://patches.dpdk.org/patch/24211/ > > > > This work was going in the right direction. > > > > Totally agree. > > > Konstantin, as the maintainer of the ACL library, > > do you think it is worth to keep this example as standalone or merged? > > My vote is definitely for merging. > That would give us single l3fwd app with 3 different routing methods > (lpm, hash, acl) selectable at run-time, plus routing tables in config file. > Konstantin > > > > > > > >