From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <roszenrami@gmail.com>
Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com
 [209.85.167.194]) by dpdk.org (Postfix) with ESMTP id 63EC64C99
 for <dev@dpdk.org>; Mon, 17 Dec 2018 16:43:07 +0100 (CET)
Received: by mail-oi1-f194.google.com with SMTP id y23so10503823oia.4
 for <dev@dpdk.org>; Mon, 17 Dec 2018 07:43:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=1gUpbqAjWc3Nx29xXKHcSHepveqkVkduqM4eW+vN/y8=;
 b=eyyzYgW7t/XNf6TY6mBG7uXUtFW1srTDCT8Gy1GMPut4f5Vji2mZLCz8Qv/exOt9ja
 YFw+UDYU8f8fH+wGnOXMCFTEmIyU+RTt6lKB9JznjS2ubg9YeYjuXoy9+B1tfAIRJFkq
 SpR/ubToIiHuFp1vsUYCCbY0aVkwZqo2Wi2Koz0ZIdAEYxaW1gJPUZ11h9fZ7dm1T7G6
 KG/DcNf1B2e+qoR5ZDsG+MtBXJm7dv+TcwgEJ/qMYQ69GCbC+EXHW1TT8JmuS37i7y0F
 OhaWcvI6WRs1RiCSaij4mkyPUh6EgviYj7NV3Z7sG8/qxErJ8zZHzxEyX12wIFrIJJa6
 LMUw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=1gUpbqAjWc3Nx29xXKHcSHepveqkVkduqM4eW+vN/y8=;
 b=dIqoa8h3FbexXzAoNFxUqsbQ6jfPqlvhhBkGQLNS81/EU0/K3kBTPCGKBflJaQGpBp
 UI6nrEnR+Qm6Nvvde8VHcywVNa/nI0WR9joKchwxbDbcKFtFh8770qdaeDlSKdTk2Aja
 VzY9pMEJhsqKR0Q6bjLW9eaZHxUhyKBACq3jBxlb3zIDjpwMEITal0Ano6FMNq320917
 xJop0zEIzYCsN9rOF7fJW70aWjCW4dfbxJ+50+pD1XF4HyiUvItzmsYMgyGic04dLrwp
 Rm9Jjl26QvzykbFo3KHvr2KYEQKgSN9BWGltgLG4dk2oss49o4mUjANi9mGRyFvHMURC
 somQ==
X-Gm-Message-State: AA+aEWbEg07lFwXGQrKT4agMqomGxBJlDCQEXwAG3lWeCp8hXF/XGXDr
 SAUH4g7eM4ck20OSyme2CLCfwT/fxFVtsidB3/M=
X-Google-Smtp-Source: AFSGD/VcxY9NB4/p+KaoDdZTdW8piSe3Bp6MiXqIee5qXc32x9UaDu2wb3Zz1lnxx5Wfj7CFhjhjtLmECkCiLpw95Bc=
X-Received: by 2002:aca:c142:: with SMTP id r63mr5917214oif.98.1545061386577; 
 Mon, 17 Dec 2018 07:43:06 -0800 (PST)
MIME-Version: 1.0
References: <20181214164000.9667-1-jeffrey.b.shaw@intel.com>
In-Reply-To: <20181214164000.9667-1-jeffrey.b.shaw@intel.com>
From: Rami Rosen <roszenrami@gmail.com>
Date: Mon, 17 Dec 2018 17:42:55 +0200
Message-ID: <CAKoUArnTHFe6eFM=RaFsZjZbCNxaVA4BFf+ZDKV+dQ-eh6wBgw@mail.gmail.com>
To: Jeff Shaw <jeffrey.b.shaw@intel.com>
Cc: dev@dpdk.org
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] eal: remove unnecessary dirent.h include
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Dec 2018 15:43:07 -0000

Reviewed-by: Rami Rosen <ramirose@gmail.com>

On Fri, 14 Dec 2018 at 18:43, Jeff Shaw <jeffrey.b.shaw@intel.com> wrote:
>
> Prior to this patch, the two affected .c files include <dirent.h>
> unnecessarily. This commit removes the include lines.
>
> Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> ---
>  lib/librte_eal/common/eal_common_lcore.c | 1 -
>  lib/librte_eal/common/rte_service.c      | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_lcore.c b/lib/librte_eal/common/eal_common_lcore.c
> index 3167e9d79..1cbac4228 100644
> --- a/lib/librte_eal/common/eal_common_lcore.c
> +++ b/lib/librte_eal/common/eal_common_lcore.c
> @@ -5,7 +5,6 @@
>  #include <unistd.h>
>  #include <limits.h>
>  #include <string.h>
> -#include <dirent.h>
>
>  #include <rte_errno.h>
>  #include <rte_log.h>
> diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c
> index 0f3695c4b..03fde97a9 100644
> --- a/lib/librte_eal/common/rte_service.c
> +++ b/lib/librte_eal/common/rte_service.c
> @@ -7,7 +7,6 @@
>  #include <inttypes.h>
>  #include <limits.h>
>  #include <string.h>
> -#include <dirent.h>
>
>  #include <rte_compat.h>
>  #include <rte_service.h>
> --
> 2.14.3
>