From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-f195.google.com (mail-oi1-f195.google.com [209.85.167.195]) by dpdk.org (Postfix) with ESMTP id 632491B53E for ; Thu, 10 Jan 2019 02:39:39 +0100 (CET) Received: by mail-oi1-f195.google.com with SMTP id r62so8039054oie.1 for ; Wed, 09 Jan 2019 17:39:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZwJqFPSTXt97eixcV/iXEsmfASWaViSecX5sQt+ScZ4=; b=XXCpW35NyMIubcUNtYk60k7NgBa1uhtYeNGmx5+s2ZHCCUX9vADnVDANhkkao28VX4 a53X4NnEF1ACHc6pOOHY855nm/6oM3CruTzVk5rjPJq0vornPCDsc3AVrkbnKh1XYcm/ Gf5ixOlJmMtHR6/Jib0SAhzrmIAxqOeV8nnw5LGp5k0NxgWgwRfV7z/zFuJa8ZBW/8E+ be9Y4aLuPa1l2se205Y4DEIRfrvv81KVkA5LKloId7RNszHQzOoFc6ROlXbPGFyNSc/t TYRA5NavUJjlCG+i8cp6ZRSHIa8O8aepw8K5IZfEgdk7kUCPXmQQyQOhQynZKVgHvv6c 4lCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZwJqFPSTXt97eixcV/iXEsmfASWaViSecX5sQt+ScZ4=; b=YbIPy0U2/5bv6Tvm7AihGkuVIBQa+E8ONVO3psZNqgzGbFHJuoUy2dGMBOAb8TZ07b mh8diS6aeycTChnel+/qiWogBJZj2COzPpmx0IcVTbTWI7qPn5SlI6KI+bvn3Ku/ZMxU LHRdY0fjDORuBT8CqkZmgytiIL4bFszoHhvo2DU5dqM7wi7qIqgkEOgI/+ybqI7ui9FQ /wvGY4fLOqZmBRvPN+IcvcO9tUSBZseEz48VJZ1jwG6DRR9s5BOy0c6COwLKkCXlmgvx qpYwRpxLFmi/xkSEuABIhXQazBqNwJ5Y1z82HUTdQsiElB1sYZ2yOPf2TNYxlWvmyvGj f3HA== X-Gm-Message-State: AJcUukcAXZVo+I9YRFeSzZURxmCtB5/DeDrIbhTha7nHy+wBgG3UFVMc GylSPB3wo+0+yRnen1wzY69FbePoZrj0GWZfWjA= X-Google-Smtp-Source: ALg8bN6sD3G+LnESY8FNYBF/K6k4GWMF9B5DXtZVI6qPKQIqfeSmkQliIP0iH7y5AEqcWIDAW4bty9ST4wLJUs9caKA= X-Received: by 2002:aca:31cb:: with SMTP id x194mr5157273oix.213.1547084378539; Wed, 09 Jan 2019 17:39:38 -0800 (PST) MIME-Version: 1.0 References: <20190109085426.39965-1-yskoh@mellanox.com> <20190109131908.4949-1-yskoh@mellanox.com> In-Reply-To: From: Rami Rosen Date: Thu, 10 Jan 2019 03:39:29 +0200 Message-ID: To: David Marchand Cc: Yongseok Koh , Olivier Matz , Shahaf Shuler , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 1/2] mbuf: add function returning default buffer address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 01:39:39 -0000 Hi, Yongseok, Maybe you should consider using the pool member of the mbuf, instead of passing it as a parameter for rte_mbuf_buf_addr_default(). The pool member of mbuf indicates the pool from which it was allocated. See http://git.dpdk.org/dpdk/tree/lib/librte_mbuf/rte_mbuf.h#n631 And actually the is exactly what you do in the second method, rte_mbuf_data_baddr_default(), when invoking the first, this is also kind of non consistency. >> David Marchand wrote: > So for me s/rte_mbuf_buf_addr_default/rte_mbuf_buf_addr/g > Or just rte_mbuf_data_addr_default() ? + 1 >> David Marchand wrote: >Those are new functions, they should go through the EXPERIMENTAL api >marking process. +1 Regards, Rami Rosen =D7=91=D7=AA=D7=90=D7=A8=D7=99=D7=9A =D7=99=D7=95=D7=9D =D7=93=D7=B3, 9 =D7= =91=D7=99=D7=A0=D7=95=D7=B3 2019, 15:47, =D7=9E=D7=90=D7=AA David Marchand = < david.marchand@redhat.com>: > On Wed, Jan 9, 2019 at 2:19 PM Yongseok Koh wrote: > > > This patch introduces two new functions - rte_mbuf_buf_addr_default() a= nd > > rte_mbuf_data_baddr_default(). > > > > rte_mbuf_buf_addr_default() reutrns the default buffer address of given > > mbuf which comes after mbuf structure and private data. > > > > The buffer address should always be the same for a given mbuf, there is n= o > "default" value for it, there is only one value. > So for me s/rte_mbuf_buf_addr_default/rte_mbuf_buf_addr/g. > > > > rte_mbuf_data_baddr_default() returns the default address of mbuf data > > taking the headroom into account. > > > > Or just rte_mbuf_data_addr_default() ? > > > > Signed-off-by: Yongseok Koh > > > > Those are new functions, they should go through the EXPERIMENTAL api > marking process. > > > -- > David Marchand >