From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A871FA0544; Tue, 25 Oct 2022 20:01:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 900E741133; Tue, 25 Oct 2022 20:01:17 +0200 (CEST) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by mails.dpdk.org (Postfix) with ESMTP id EDB2E410D2 for <dev@dpdk.org>; Tue, 25 Oct 2022 20:01:15 +0200 (CEST) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-36a4b86a0abso106078557b3.7 for <dev@dpdk.org>; Tue, 25 Oct 2022 11:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1MSX+BG7PSh5V0Vko84PyaGFbB+vRYwzACtuySRidjE=; b=OP4l/V4qXncT059GwzkqxGZ9dTDsdjeSlw4l1rBZeWsPPQzLQpoeySnOBUm+1wIEhL 5VbAzm4TuBBsIP/HloLmfwzuen4RXyTrjAFOTT/DvkE15DWPnq0uTK04GIfIp26zfhvV yjgzFIclMjB7TR6KjWgL6I0L2JQ58tQ6/czO97xVjblfKHG0vLxzdGMVJKogiT2YeO7R Kw7OImEUEYWk7dX/baekj+tzK99qlv3H1aDRBq/Rw1sADuNPmix31mGx1ylO8wCgw18s rp9gwcGGS2SwOat2EIf0q6PFG+yoKmueVqMAttYKtsZkQiEUVPq7l02yThwU6YTuX1aT TnWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1MSX+BG7PSh5V0Vko84PyaGFbB+vRYwzACtuySRidjE=; b=fcqsw/bvpbcppaaGXrz0riE8hRrErwwdN7NNwru5LGECACME2qD8tOXzp5bkzNPRo1 F/MfW5IqVnKQ5tZKdV7+LWh6UE4FmLec28vuAezJu06EGuST2O8Ue14+puMBeVxIA8gz WIa0P0iL+D8+Xa+IKNqvV/pzpYnOB/Ga0OganwQT6VhlID8Tg/hLGbPfGEr+wPB0uqaL QZWhqsK+8ffBBOXJkno+md0hJH9mK5A9F+rx9BijVMGWM+87CjMs3+0fpcAnqJAf4Q2w e+zCnKeh7D65f1/VsWS2BlUn6zHgf0y674Dhj7NmfkIE5Nl1XhnXHG4qdyRC8y8bmuZN JuBA== X-Gm-Message-State: ACrzQf3JKyELsGNYL84YfVoGjk81OzS7MhTAcvOYbfcxzesnzMl3BmOA O2Isz9QdcVlkGRXujooAjbH1xW8vi6cQyPYg3QmQpGBLzXI= X-Google-Smtp-Source: AMsMyM65QPSMZAzzVyYmyCTCHB4Z2A9/BRC+K1lkbL/45OUflsM3PakXOADy7Khc5756mVGW9trum3svsJ2JYheVsMc= X-Received: by 2002:a81:9a8f:0:b0:36f:d05d:b59a with SMTP id r137-20020a819a8f000000b0036fd05db59amr2525371ywg.180.1666720875288; Tue, 25 Oct 2022 11:01:15 -0700 (PDT) MIME-Version: 1.0 References: <20220726213618.142173-1-stephen@networkplumber.org> <20221021130525.46732044@hermes.local> In-Reply-To: <20221021130525.46732044@hermes.local> From: Ben Magistro <koncept1@gmail.com> Date: Tue, 25 Oct 2022 14:01:04 -0400 Message-ID: <CAKx8PBhwBvN84Q1xONWa_sPnKm_Aza80+rrY4F6Tj0LtX1SiNg@mail.gmail.com> Subject: Re: [RFC] pcapng: record received RSS hash in pcap file To: Stephen Hemminger <stephen@networkplumber.org> Cc: dev@dpdk.org Content-Type: multipart/alternative; boundary="000000000000b62bd405ebdfb1be" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org --000000000000b62bd405ebdfb1be Content-Type: text/plain; charset="UTF-8" Tested with Wireshark 4.1.0rc0-599-g708da4852678 (and older version to confirm no issues) Tested-by: Ben Magistro <koncept1@gmail.com> On Fri, Oct 21, 2022 at 4:05 PM Stephen Hemminger < stephen@networkplumber.org> wrote: > On Tue, 26 Jul 2022 14:36:19 -0700 > Stephen Hemminger <stephen@networkplumber.org> wrote: > > > There is an option for recording RSS hash with packets in the > > pcapng standard. This implements this for all received packets. > > > > There is a corner case that can not be addressed with current > > DPDK API's. If using rte_flow() and some hardware it is possible > > to write a flow rule that uses another hash function like XOR. > > But there is no API that records this, or provides the algorithm > > info on a per-packet basis. > > > > The current version of wireshark does not display the recorded > > hash option. But if we build it they will come. > > Support for displaying RSS hash in record has been merged into > Wireshark for 4.1 release. > > Could this please be acked and merged. > --000000000000b62bd405ebdfb1be Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Tested with Wireshark=C2=A04.1.0rc0-599-g708da4852678 (and= older version to confirm no issues)<div><br></div><div>Tested-by: Ben Magi= stro <<a href=3D"mailto:koncept1@gmail.com" target=3D"_blank">koncept1@g= mail.com</a>></div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr"= class=3D"gmail_attr">On Fri, Oct 21, 2022 at 4:05 PM Stephen Hemminger <= ;<a href=3D"mailto:stephen@networkplumber.org">stephen@networkplumber.org</= a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0p= x 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On= Tue, 26 Jul 2022 14:36:19 -0700<br> Stephen Hemminger <<a href=3D"mailto:stephen@networkplumber.org" target= =3D"_blank">stephen@networkplumber.org</a>> wrote:<br> <br> > There is an option for recording RSS hash with packets in the<br> > pcapng standard. This implements this for all received packets.<br> > <br> > There is a corner case that can not be addressed with current<br> > DPDK API's. If using rte_flow() and some hardware it is possible<b= r> > to write a flow rule that uses another hash function like XOR.<br> > But there is no API that records this, or provides the algorithm<br> > info on a per-packet basis.<br> > <br> > The current version of wireshark does not display the recorded<br> > hash option. But if we build it they will come.<br> <br> Support for displaying RSS hash in record has been merged into<br> Wireshark for 4.1 release.<br> <br> Could this please be acked and merged.<br> </blockquote></div> --000000000000b62bd405ebdfb1be--