From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81061A0507; Fri, 1 Apr 2022 17:13:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 205C040E03; Fri, 1 Apr 2022 17:13:45 +0200 (CEST) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by mails.dpdk.org (Postfix) with ESMTP id 26E4A4067E for ; Fri, 1 Apr 2022 17:13:44 +0200 (CEST) Received: by mail-yb1-f174.google.com with SMTP id u103so5524530ybi.9 for ; Fri, 01 Apr 2022 08:13:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to:cc; bh=RxGCCTQaI2AI7/iBKZsXSsZYaBjCMTciMzOYLmkpJm8=; b=Vw+jLuBLboU5zdH7/bjtN4rryybhOt9aDtZC7UfaDJuR2lrpeGLeMW8kMwfyYbVl5X RMMRQ9ZtYCkfVxCAfueXaX9gaHAxEk31BTdaGCskM/5fbnNxozo0LFvMChHGmQCHtG5l S0WlvhMuwvTK4nyQeVZHjk4UwqV68Gl1oriFnzXBaDyViADPYawwmGIpusvQDX7SN6Ds zHD9d+4tIx030YtOzogy39fBsWSlLKtRv7j3DkSyfr37RonKmwQruIvR91H631kIp0JB RJb7bxkE4TW2+DQT0L1O+e/vyyR3K+fJaMwib+5BXfAKk3Ygf/OT7rCPAFcZWRDrZvl1 +goA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=RxGCCTQaI2AI7/iBKZsXSsZYaBjCMTciMzOYLmkpJm8=; b=Gb2H8EnHO0HgCoXSJg19AEjkxML5RYIOr1/qBeQ9cQ21Bt2EqK7Ffxx+WPv6WJRvcr RXjAXSoJan618zayIJmqgSenNo/GGKydw6vRHjoUYSw91Fer7SGquODBvkQlBHW50Gko XQK1fDJWTQEvMbEjhlonTqpUeSkNYS8/6AYQvOaDcxhqWKaSOMn4gdTrjheOjiVQjELX Dyr6CrP597fiLYGq8ip219Wklv0PslO0UP9Naxyo0XpSEUhKRZntlK+hragkmgU/yoEb bgEfaTD6GH3jjz0YsELzOLl05S0Lcad70Gv46Gj8OXsN09xzgvY41h1kQMbcJO5eKnpy u2VA== X-Gm-Message-State: AOAM532S3iQkl2HpIJnzr+B/npLaeYml/yNB//5R8oILM1vSeWJPiWxN TYxKd40QG7fDjiP/rfossrKkYnedqKNKnjsXnuXctouZP6g= X-Google-Smtp-Source: ABdhPJyRlhTi5WYzc8bUcqbxKBXVZDbDKd2I9ZqH2boWVbEFm/+T3QzGYJc1VuKe1i5tNExIgkVDDX7aZRy/z9ZPa/c= X-Received: by 2002:a25:24d:0:b0:633:6b37:bea1 with SMTP id 74-20020a25024d000000b006336b37bea1mr8854830ybc.427.1648826023087; Fri, 01 Apr 2022 08:13:43 -0700 (PDT) MIME-Version: 1.0 From: Ben Magistro Date: Fri, 1 Apr 2022 11:13:32 -0400 Message-ID: Subject: i40e QinQ Offload w/ NVM 8.40 not working To: dev@dpdk.org Cc: ben.magistro@trinitycyber.com, Stefan Baranoff Content-Type: multipart/alternative; boundary="00000000000067112f05db9939c9" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000067112f05db9939c9 Content-Type: text/plain; charset="UTF-8" Hello, We recently needed to apply a firmware upgrade for some XXV710s to resolve a FEC issue (I'd have to find the details in email) but applied this same firmware to other nics (XL710s) to maintain a consistent baseline. In testing we have seen the NVM 8.40 resolve the FEC issue but it introduces an issue with QinQ offloading + stripping. When running NVM 8.15 (previous version), we could send QinQ traffic, and the nic would properly strip and store the values into vlan_tci and vlan_tci_outer as expected. When running NVM 8.40 (FEC fix version) sending QinQ traffic is only stripping the inner tag. The code we are using has not changed. I added some additional lines to drivers/net/i40e/i40e_rxtx.c to help troubleshoot this, specifically one to log the vlans and one to log ext_status. In comparing the two, ext_status is 0 under 8.40 while it is 1 under 8.15. This does correspond with not running the second layer processing code in the i40e_rxtx.c (line ~87). We will continue to investigate but would like to get this out there sooner and ask for assistance in confirming this behavior. This is a Dell based card so the firmware package used to update/downgrade the card is coming from Dell and not Intel directly. It is our assumption that the firmware in general should be pretty consistent between the two. Traffic is being generated by trex with the vlan nesting being pushed by some Juniper switches. Both vlan tags are 0x8100. OS: CentOS 7.9 DPDK: 20.08 (we know it's not supported anymore, but were trying to put off that upgrade until some other changes were also completed) NIC: i40e XL710 -- net_i40e / firmware 8.15 0x800096d0 20.0.17 If there are any additional details needed please let us know. Thanks, Ben --00000000000067112f05db9939c9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

We recently needed to apply a fi= rmware upgrade for some XXV710s to resolve a FEC issue (I'd have to fin= d the details in email) but applied this same firmware to other=C2=A0nics (= XL710s) to maintain a consistent=C2=A0baseline.=C2=A0 In testing we have se= en the NVM 8.40 resolve the FEC issue but it introduces an issue with QinQ = offloading + stripping.=C2=A0 When running NVM 8.15 (previous version), we = could send QinQ traffic, and the nic would properly=C2=A0strip and store th= e values into vlan_tci and vlan_tci_outer as expected.=C2=A0 When running N= VM 8.40 (FEC fix version) sending QinQ traffic is only stripping the inner = tag.=C2=A0 The code we are using has not changed.

= I added some additional lines to drivers/net/i40e/i40e_rxtx.c to help troub= leshoot this, specifically one to log the vlans and one to log ext_status.= =C2=A0 In comparing the two, ext_status is 0 under 8.40 while it is 1 under= 8.15.=C2=A0 This does correspond with not running the second layer process= ing code in the i40e_rxtx.c (line ~87).=C2=A0 We will continue to investiga= te but would like to get this out there=C2=A0sooner and ask for assistance = in confirming this behavior.

This is a Dell based card so the firmware package used to update/= downgrade the card is coming from Dell and not Intel directly.=C2=A0 It is = our assumption that the firmware in general should be pretty consistent bet= ween the two.

Traffic is being generated by tr= ex with the vlan nesting being pushed by some Juniper switches.=C2=A0 Both = vlan tags are 0x8100.

OS: CentOS 7.9
DPD= K: 20.08 (we know it's not supported anymore, but were trying to put of= f that upgrade until some other changes were also completed)
NIC:= i40e XL710 -- net_i40e / firmware 8.15 0x800096d0 20.0.17

If there are any additional details needed please let us know.

Thanks,

Ben
--00000000000067112f05db9939c9--