From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f178.google.com (mail-ob0-f178.google.com [209.85.214.178]) by dpdk.org (Postfix) with ESMTP id DD6695424 for ; Fri, 29 Apr 2016 22:00:51 +0200 (CEST) Received: by mail-ob0-f178.google.com with SMTP id j9so60926021obd.3 for ; Fri, 29 Apr 2016 13:00:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=E8OfQnkVhip2N+9H6bmP9WppPdPhOPF+6damaw1llQw=; b=ohYojAZxPA68XxgFCzZRiW7pF4YqRFRdFiaL39yQn5swg6vb2z64X9yIBMZ30n49Mb virXntl4SiWIi9rX7tMj3xntAKFvcYGYflLhCEPmjbWjHjadUwUoYA/VPWJuE2Pt6t96 oiVXFUb1uUsMbnyi1+OF3zfaPips7vgwI/GopIEROgzHfg1m6IACXpbo0M7E4kJ48PDZ 8yXbY4eeAYyzoZcOmJVdyHuHv9yTrWhVHO87ZEsO4U36uaYaWWBSOwLtF336UZOsddep lgSfJ5CB2O4u6dxKOTQUKn8wDPNVtFcao9/jGmr+NLFCWKgwnvzKyGudvsknHcsCWNQZ xJVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=E8OfQnkVhip2N+9H6bmP9WppPdPhOPF+6damaw1llQw=; b=BnvGy6gWEjVLoiJZDFx3hc0IsJVGPWMEwBHHL3JRcbU3ApobWB5s5/MuTMy+5oNtLe sS0m6xFUWb+ARiiVAD4uR8UrJkG+VhLT3P/ifOpSgbqXu9/a+MYuhJ3HXqautzb4tN/g Z8/XJK8FC0+9XiLEtGZ/KvmxPV92Ac0eHm/AiuEYnD9CUHDcbUON7zKRDreUTZ3Gdpzz mwIWhIsvbDUdVyBfXL0MCDk2UDQKBwoqhrXvIfg8dNKjFpOTkDVQ2Yb6SCvn3F9avtB9 3WAccAeXVEg1vUqkagx33HQXvuQQHX3xGewQlqkSXaUYRkaKPGlbDcJ74AddBQknBqid i0sw== X-Gm-Message-State: AOPr4FUvn2HKOOJXPZIJA8aqDdijLi6OYh5BIgaLY6oFHGuiaNZLm1P7vsOkD4Rj2US5ArMp1dng5KqBJbcLTw== MIME-Version: 1.0 X-Received: by 10.182.38.226 with SMTP id j2mr2344120obk.24.1461960051364; Fri, 29 Apr 2016 13:00:51 -0700 (PDT) Received: by 10.202.106.84 with HTTP; Fri, 29 Apr 2016 13:00:51 -0700 (PDT) In-Reply-To: References: <572352A3.6030400@6wind.com> Date: Fri, 29 Apr 2016 23:00:51 +0300 Message-ID: From: Arnon Warshavsky To: Jay Rolette Cc: Don Provan , Olivier Matz , "dev@dpdk.org" , "Zhang, Helin" , "Ananyev, Konstantin" , John Daley Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] removing mbuf error flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2016 20:00:52 -0000 On Fri, Apr 29, 2016 at 9:24 PM, Jay Rolette wrote: > On Fri, Apr 29, 2016 at 1:16 PM, Don Provan wrote: > > > >From: Olivier Matz [mailto:olivier.matz@6wind.com] > > >Subject: [dpdk-dev] removing mbuf error flags > > > > > >My opinion is that invalid packets should not be given to the > application > > and only a statistic counter should be incremented. > > > > The idea of an application that handles bad packets is perfectly valid. > > Most applications don't want to see them, of course, but, conceptually, > > some applications would want to ask for bad packets because they are > > specifically designed to handle various networking problems including > those > > that result in bad packets that the application can look at and report. > > Furthermore, it makes technical sense for DPDK to support such > applications. > > > > Having said that, I have no idea if that's why that field was added, an= d > I > > don=E2=80=99t myself care if DPDK provides that feature in the future. = I just > > thought I'd put the idea out there in case it makes any difference to > you. > > If it were me, I'd probably decide it isn't hurting anything and not > bother > > to remove it in case some day someone wants to implement that feature i= n > > one driver or another. > > > > Yep. Pretty much any networking security product needs to see malformed > packets. > > Jay > +1 for letting the application see bad packets and decide what to do with them. We had some zero order insertion issues in the past where the ability to let the application capture malformed/unexpected packets was very helpful. /Arnon.