From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by dpdk.org (Postfix) with ESMTP id 546A31B4C0 for ; Sun, 21 Apr 2019 21:16:29 +0200 (CEST) Received: by mail-io1-f45.google.com with SMTP id a23so4340433iot.4 for ; Sun, 21 Apr 2019 12:16:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2hUSz9rFWKM4/MORruleEZcrcVg6jsHNlnbO14QGnEc=; b=t/1c3pG/uDvi26Ap9tXQDG7zNRsnqHiSWsXJ+LcWCSI2L2xdSJVfCrk+5LoQzcfgQV 9H0IC+D1en2AwOX7lJ2guNKigEIwRgJ7clKravkausUvOjM2FvDWxumY83WK3JVGryg5 nVhUSVfschli3bH3VKz426glh98DbhnlXHgTPUm/ncpS0rv3HBdZq4s9scjoss0HGjxt 7BF64ZpOa9JzdkxoPl//4tPcph1raPsP+7JYU/jMBhGy0ZkZTfdjUCsuakVIE40BaYrC d/WTllvFqKJ9LmAPecWwR4aVmiMwDvAEEAaD1UiFKDq4BbXjnHF6CAlDPnWMIhOP567a 6QYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2hUSz9rFWKM4/MORruleEZcrcVg6jsHNlnbO14QGnEc=; b=dWLotQpd8Izl9IyvXDCoYzq3pb/FD3G0ejJj6LjwkJG4av9Cg0VbpEzR/7QRjaJ9Tv QzhqPFEtFjjRwKBn+XRRW0EEft6ltj7Sp68udwEZkb/DlpKwNSJhG5poptSRQZv4wwET 8duddw2JdlBRpb1jsDGDUMCHSfx7N1ij3h0tYDWiHuAIYYJ1pjJQGUc2i67vZ82+++0H L/3pNr8yi6lZG2DiaO54qSly/kt0sZQ0cndiuOBQ79TR97eaKMddWsZPGNsqvxjqv5rf nbjC0tBzf6wWDje0+Jh0PGBSqFEP5Q9sNiV/se4/mSniTS9yusIGm2UaZYrbWtIBD0TZ Xx5A== X-Gm-Message-State: APjAAAWas4SJR1lUG0xgxEg0qTACAeM5rvJffJD4+spEs8b/KfigBYBJ zM3U7keXEHZk7vItqM/HT2HQvHcgRo4mGinmbwMgFA== X-Google-Smtp-Source: APXvYqyytQP2tJpp7xpXuFQ7IqGAZhNvrYGr74yK/PcGzt33tw91VpEvi7y3pOow7vR71j5yHM7PpxnD7Lbh+Gne4/k= X-Received: by 2002:a6b:3b0d:: with SMTP id i13mr9538670ioa.82.1555874188582; Sun, 21 Apr 2019 12:16:28 -0700 (PDT) MIME-Version: 1.0 References: <1524552123-31378-1-git-send-email-arnon@qwilt.com> <3131803.2ETXjPmY0d@xps> In-Reply-To: <3131803.2ETXjPmY0d@xps> From: Arnon Warshavsky Date: Sun, 21 Apr 2019 22:16:19 +0300 Message-ID: To: Thomas Monjalon Cc: dev@dpdk.org, "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , Jerin Jacob , Bruce Richardson , "Yigit, Ferruh" , ranjit.menon@intel.com, anand.rawat@intel.com, Pallavi Kadam , Harini Ramakrishnan , "O'Hare, Cathal" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v6 00/11] al: replace calls to rte_panic and refrain from new instances X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Apr 2019 19:16:29 -0000 > > > What happened to this patchset? > > This is definitely an improvement. We must remove rte_panic from libs. > Arnon, are you still available to rebase this patchset in preparation > of 19.08? Or someone else? > > What are the required API breakages? I see one in ethdev which requires > a deprecation notice to be sent for publishing in 19.05. > > Is there more rte_panic to remove? > > > Hi, I should be able to address this for 19.08, at least the straight forward parts. I need to touch base again with this patchset later this week, to see what changed since then, and see what deprecation notices are required. I would like to address the ones that are a direct part of the initialization sequence, and mostly change functions and their callers from void to return a value that propagates upwards. The 2nd kind under lib that I wanted to remove at the time are the ones that live in threads and I would not like to handle them now. Given a 3rd kind that is found inside PMDs that may panic during callbacks, the former poses a similar challenge of managing the device state after a panic event which is not trivial, and tmho deserves either a separate patchset or a defeat recognition. In this respect , In addition to removing the ones from the initialization sequence, I would like to revive my original proposal to add a callback registration to the panic event. As I do not expect all the PMD callback panics to disappear completely, I still need to allow the running process to do some kind of orderly tear-down to other modules when possible. Does this sound ok for 19.08? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C2C7AA05D3 for ; Sun, 21 Apr 2019 21:16:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6A0DE1B4C1; Sun, 21 Apr 2019 21:16:30 +0200 (CEST) Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by dpdk.org (Postfix) with ESMTP id 546A31B4C0 for ; Sun, 21 Apr 2019 21:16:29 +0200 (CEST) Received: by mail-io1-f45.google.com with SMTP id a23so4340433iot.4 for ; Sun, 21 Apr 2019 12:16:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2hUSz9rFWKM4/MORruleEZcrcVg6jsHNlnbO14QGnEc=; b=t/1c3pG/uDvi26Ap9tXQDG7zNRsnqHiSWsXJ+LcWCSI2L2xdSJVfCrk+5LoQzcfgQV 9H0IC+D1en2AwOX7lJ2guNKigEIwRgJ7clKravkausUvOjM2FvDWxumY83WK3JVGryg5 nVhUSVfschli3bH3VKz426glh98DbhnlXHgTPUm/ncpS0rv3HBdZq4s9scjoss0HGjxt 7BF64ZpOa9JzdkxoPl//4tPcph1raPsP+7JYU/jMBhGy0ZkZTfdjUCsuakVIE40BaYrC d/WTllvFqKJ9LmAPecWwR4aVmiMwDvAEEAaD1UiFKDq4BbXjnHF6CAlDPnWMIhOP567a 6QYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2hUSz9rFWKM4/MORruleEZcrcVg6jsHNlnbO14QGnEc=; b=dWLotQpd8Izl9IyvXDCoYzq3pb/FD3G0ejJj6LjwkJG4av9Cg0VbpEzR/7QRjaJ9Tv QzhqPFEtFjjRwKBn+XRRW0EEft6ltj7Sp68udwEZkb/DlpKwNSJhG5poptSRQZv4wwET 8duddw2JdlBRpb1jsDGDUMCHSfx7N1ij3h0tYDWiHuAIYYJ1pjJQGUc2i67vZ82+++0H L/3pNr8yi6lZG2DiaO54qSly/kt0sZQ0cndiuOBQ79TR97eaKMddWsZPGNsqvxjqv5rf nbjC0tBzf6wWDje0+Jh0PGBSqFEP5Q9sNiV/se4/mSniTS9yusIGm2UaZYrbWtIBD0TZ Xx5A== X-Gm-Message-State: APjAAAWas4SJR1lUG0xgxEg0qTACAeM5rvJffJD4+spEs8b/KfigBYBJ zM3U7keXEHZk7vItqM/HT2HQvHcgRo4mGinmbwMgFA== X-Google-Smtp-Source: APXvYqyytQP2tJpp7xpXuFQ7IqGAZhNvrYGr74yK/PcGzt33tw91VpEvi7y3pOow7vR71j5yHM7PpxnD7Lbh+Gne4/k= X-Received: by 2002:a6b:3b0d:: with SMTP id i13mr9538670ioa.82.1555874188582; Sun, 21 Apr 2019 12:16:28 -0700 (PDT) MIME-Version: 1.0 References: <1524552123-31378-1-git-send-email-arnon@qwilt.com> <3131803.2ETXjPmY0d@xps> In-Reply-To: <3131803.2ETXjPmY0d@xps> From: Arnon Warshavsky Date: Sun, 21 Apr 2019 22:16:19 +0300 Message-ID: To: Thomas Monjalon Cc: dev@dpdk.org, "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , Jerin Jacob , Bruce Richardson , "Yigit, Ferruh" , ranjit.menon@intel.com, anand.rawat@intel.com, Pallavi Kadam , Harini Ramakrishnan , "O'Hare, Cathal" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v6 00/11] al: replace calls to rte_panic and refrain from new instances X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190421191619.6fuf6P5QxMf3sG5D5WMMBxfTRO3ashtTMMK4kR0oTMo@z> > > > What happened to this patchset? > > This is definitely an improvement. We must remove rte_panic from libs. > Arnon, are you still available to rebase this patchset in preparation > of 19.08? Or someone else? > > What are the required API breakages? I see one in ethdev which requires > a deprecation notice to be sent for publishing in 19.05. > > Is there more rte_panic to remove? > > > Hi, I should be able to address this for 19.08, at least the straight forward parts. I need to touch base again with this patchset later this week, to see what changed since then, and see what deprecation notices are required. I would like to address the ones that are a direct part of the initialization sequence, and mostly change functions and their callers from void to return a value that propagates upwards. The 2nd kind under lib that I wanted to remove at the time are the ones that live in threads and I would not like to handle them now. Given a 3rd kind that is found inside PMDs that may panic during callbacks, the former poses a similar challenge of managing the device state after a panic event which is not trivial, and tmho deserves either a separate patchset or a defeat recognition. In this respect , In addition to removing the ones from the initialization sequence, I would like to revive my original proposal to add a callback registration to the panic event. As I do not expect all the PMD callback panics to disappear completely, I still need to allow the running process to do some kind of orderly tear-down to other modules when possible. Does this sound ok for 19.08?