From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f68.google.com (mail-it0-f68.google.com [209.85.214.68]) by dpdk.org (Postfix) with ESMTP id 1E4CB1C891 for ; Wed, 4 Apr 2018 22:43:15 +0200 (CEST) Received: by mail-it0-f68.google.com with SMTP id u62-v6so374624ita.5 for ; Wed, 04 Apr 2018 13:43:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=LNOhc+C01PqaH2YxuJeL546CH9o0wH6A0t0pdvuV3vU=; b=YiHCimXKKEXIpXxmudaxfWI5xVk8KGOaD11QXfdokfM3TYXCQbLHypyc9mIZXu5DKS fqM8HIZfn+1uaug+z9vyP3w3Crv9s5bxxmyy6ka8OKcklAHFJ6YHpbWctix2rorls6iZ QkFDE30XCoh7wtd+IK51sQMqMC+xD0BBW0tuOumBysIpeRSDjUomdBgLBxbw9z8Z3qNB Ki8Au6Y6Ien0IWXqejyljuHBIQTcesU58Jr69+7fElDMxhKrg1vWwARK8Cq6QxkXsxCG pdBw1VFVcDiQ2mcPd/rrkWr4bk/gORbMu0jHNnCDl5xJZlG67ttrHmP9lWV8kW8d7z7I EU0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LNOhc+C01PqaH2YxuJeL546CH9o0wH6A0t0pdvuV3vU=; b=TuXc23Y7BZTJ+o1h/ZgziPfpbkRkL1NcOlakCBf1XS8YIKds9RwirF3ZdcLp1ruy1C JEe99kBXKo+bNqJoxyBodwXP5P8IB+ZD9m4Z+yOZWRuFc5X/A77c2voUlazS4JAmQoL4 e7k9yLSlxuU4a2ydLfWdkCQB55ukOx/bC/FhLOsehfC8k+DIsPQ79HWkfHJjI8W+shvA eVLbv4B6iPDpl16O/M7YVTD5auTooTnNjFrsN4gqIfDvNTy52cy20N3GLDMJiFbFDmZ7 DbS0pe3skO7oIHlcBtKHEFaMLK4stn+UY0dfGd2svRbEKR8z56d0En/9E6VT9LLNF6+V QysQ== X-Gm-Message-State: AElRT7GPofUzs50udo67zqkJL5I703u2c9t40XfC7Gs5N3Afri8O/KCI esX0/jL17FKm29cXhGaLbTQogUA/rJE9kFo0q4tVKQ== X-Google-Smtp-Source: AIpwx4/0L0oC2e9i9Rl5WAfLAYhXkmvN0e4nWZTHCw/MMrit92NEosXhyZyzESs8tUr1QmjwjdB6H1t3TgmzNEzWHWU= X-Received: by 2002:a24:76c4:: with SMTP id z187-v6mr11058836itb.138.1522874594462; Wed, 04 Apr 2018 13:43:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.142.202 with HTTP; Wed, 4 Apr 2018 13:43:13 -0700 (PDT) In-Reply-To: <20180404131030.GA30584@bricha3-MOBL.ger.corp.intel.com> References: <1522841257-11826-1-git-send-email-arnon@qwilt.com> <1522841257-11826-2-git-send-email-arnon@qwilt.com> <20180404131030.GA30584@bricha3-MOBL.ger.corp.intel.com> From: Arnon Warshavsky Date: Wed, 4 Apr 2018 23:43:13 +0300 Message-ID: To: Bruce Richardson Cc: Thomas Monjalon , "Burakov, Anatoly" , wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, ferruh.yigit@intel.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 01/13] crypto: replace rte_panic instances in crypto driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 20:43:15 -0000 Cool.I assumed worst than needed when the checkpatches lady was not satisfied. Will fix that. On Wed, Apr 4, 2018 at 4:10 PM, Bruce Richardson wrote: > On Wed, Apr 04, 2018 at 02:27:25PM +0300, Arnon Warshavsky wrote: > > Signed-off-by: Arnon Warshavsky > > --- > > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +++++--- > > drivers/crypto/dpaa_sec/dpaa_sec.c | 8 +++++--- > > 2 files changed, 10 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > > index 784b96d..37a5727 100644 > > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > > @@ -2861,9 +2861,11 @@ struct rte_security_ops dpaa2_sec_security_ops = { > > RTE_CACHE_LINE_SIZE, > > rte_socket_id()); > > > > - if (cryptodev->data->dev_private == NULL) > > - rte_panic("Cannot allocate memzone for private " > > - "device data"); > > + if (cryptodev->data->dev_private == NULL) { > > + RTE_LOG(ERR, PMD, "%s() Cannot allocate memzone > for " > > + "private device data", __func__); > > + return -1; > > + } > > } > This is the right change to make, but can you please avoid wrapping literal > strings across lines. It means that the error message cannot be grepped. > Just put the __func__ on the second line. > > Checkpatch and similar tools should ignore long lines if the long line is > simply caused by a literal string. > > /Bruce > -- *Arnon Warshavsky* *Qwilt | work: +972-72-2221634 | mobile: +972-50-8583058 | arnon@qwilt.com *